Findit has detected a flake at test TCPSocketTest.ReadAndWriteMultiple. Culprit (100.0% confidence): https://chromium-review.googlesource.com/q/I56e2702c02b9c86a72eba68c85391c3b017a4d64 Regression range: https://crrev.com/7c856b25cc4d1a0c39a08cd27a0be504bf545f65..f35977d97eb6a79330aa1ff3b8aeaa4cf6ec9589?pretty=fuller Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyoAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJqY2hyb21pdW0ud2luL1dpbiA3IFRlc3RzIHg2NCAoMSkvMzU3MjIvc2VydmljZXNfdW5pdHRlc3RzL1ZFTlFVMjlqYTJWMFZHVnpkQzVTWldGa1FXNWtWM0pwZEdWTmRXeDBhWEJzWlE9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM If this result was incorrect, apply the label Findit-Incorrect-Result, mark the bug as Untriaged and the component Tools>Test>Findit>Flakiness.
-> xunjieli@ [ RUN ] TCPSocketTest.ReadAndWriteMultiple [1/1] TCPSocketTest.ReadAndWriteMultiple (TIMED OUT) 1 test timed out: TCPSocketTest.ReadAndWriteMultiple (../../services/network/tcp_socket_unittest.cc:479)
Issue 821224 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/32c4f747a52a8dc6e91ca384f15c640d6fabbbcc commit 32c4f747a52a8dc6e91ca384f15c640d6fabbbcc Author: Trent Apted <tapted@chromium.org> Date: Tue Mar 13 02:17:04 2018 Revert "Add TCP socket API to network service" This reverts commit f35977d97eb6a79330aa1ff3b8aeaa4cf6ec9589. Reason for revert: causes TCPSocketTest.ReadAndWriteMultiple to flake (timeout) Bug: 821232 Original change's description: > Add TCP socket API to network service > > This CL adds TCP socket API to network service. > This is partly based on mandoline implementation > (https://codereview.chromium.org/1873463003/) > > Two TCP socket interfaces are added. > - TCPConnectedSocket > - TCPServerSocket > > TBR=miu@chromium.org > > Bug: 721401 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > Change-Id: I56e2702c02b9c86a72eba68c85391c3b017a4d64 > Reviewed-on: https://chromium-review.googlesource.com/868711 > Reviewed-by: Helen Li <xunjieli@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Ramin Halavati <rhalavati@chromium.org> > Commit-Queue: Helen Li <xunjieli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542606} TBR=miu@chromium.org,mmenke@chromium.org,tsepez@chromium.org,xunjieli@chromium.org,rhalavati@chromium.org Change-Id: Id31caa2f5cc54993735586555e68bd3c345600bb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 721401 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/958943 Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#542696} [modify] https://crrev.com/32c4f747a52a8dc6e91ca384f15c640d6fabbbcc/media/cast/net/udp_socket_client_unittest.cc [modify] https://crrev.com/32c4f747a52a8dc6e91ca384f15c640d6fabbbcc/services/network/BUILD.gn [modify] https://crrev.com/32c4f747a52a8dc6e91ca384f15c640d6fabbbcc/services/network/network_context.cc [modify] https://crrev.com/32c4f747a52a8dc6e91ca384f15c640d6fabbbcc/services/network/network_context.h [modify] https://crrev.com/32c4f747a52a8dc6e91ca384f15c640d6fabbbcc/services/network/public/mojom/BUILD.gn [modify] https://crrev.com/32c4f747a52a8dc6e91ca384f15c640d6fabbbcc/services/network/public/mojom/network_service.mojom [delete] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/services/network/public/mojom/tcp_socket.mojom [delete] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/services/network/socket_factory.cc [delete] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/services/network/socket_factory.h [delete] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/services/network/tcp_connected_socket.cc [delete] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/services/network/tcp_connected_socket.h [delete] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/services/network/tcp_server_socket.cc [delete] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/services/network/tcp_server_socket.h [delete] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/services/network/tcp_socket_unittest.cc [modify] https://crrev.com/32c4f747a52a8dc6e91ca384f15c640d6fabbbcc/services/network/udp_socket.cc [modify] https://crrev.com/32c4f747a52a8dc6e91ca384f15c640d6fabbbcc/services/network/udp_socket.h [add] https://crrev.com/32c4f747a52a8dc6e91ca384f15c640d6fabbbcc/services/network/udp_socket_factory.cc [add] https://crrev.com/32c4f747a52a8dc6e91ca384f15c640d6fabbbcc/services/network/udp_socket_factory.h [add] https://crrev.com/32c4f747a52a8dc6e91ca384f15c640d6fabbbcc/services/network/udp_socket_factory_unittest.cc [modify] https://crrev.com/32c4f747a52a8dc6e91ca384f15c640d6fabbbcc/services/network/udp_socket_unittest.cc
Comment 1 by tapted@chromium.org
, Mar 13 2018Status: Assigned (was: Available)
-> xunjieli@ [ RUN ] TCPSocketTest.ReadAndWriteMultiple [1/1] TCPSocketTest.ReadAndWriteMultiple (TIMED OUT) 1 test timed out: TCPSocketTest.ReadAndWriteMultiple (../../services/network/tcp_socket_unittest.cc:479)