New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 821224 link

Starred by 3 users

Issue metadata

Status: Fixed
Merged: issue 821232
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: TCPSocketTest.ServerReceivesMultipleAccept



Sign in to add a comment

TCPSocketTest.ServerReceivesMultipleAccept is Flaky

Project Member Reported by Findit, Mar 13 2018

Issue description

Comment 1 by tapted@chromium.org, Mar 13 2018

Mergedinto: 821232
Status: Duplicate (was: Available)
Labels: -Sheriff-Chromium
Owner: xunji...@chromium.org
Status: Assigned (was: Duplicate)
[ RUN      ] TCPSocketTest.ServerReceivesMultipleAccept
../../services/network/tcp_socket_unittest.cc:556: Failure
Expected equality of these values:
  net::OK
    Which is: 0
  callback->WaitForResult()
    Which is: -15

https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8952215324994575776%2F%2B%2Fsteps%2Ftest_f35977d%2F0%2Fsteps%2Fservices_unittests__f35977d__on_Mac-10.12%2F0%2Flogs%2FTCPSocketTest.ServerReceivesMultipleAccept%2F0

Project Member

Comment 3 by chromium...@appspot.gserviceaccount.com, Mar 15 2018

Labels: Sheriff-Chromium
Detected 8 new flakes for test/step "TCPSocketTest.ServerReceivesMultipleAccept". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNQsSBUZsYWtlIipUQ1BTb2NrZXRUZXN0LlNlcnZlclJlY2VpdmVzTXVsdGlwbGVBY2NlcHQM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Labels: -Sheriff-Chromium
the "culprit" was already reverted: https://chromium-review.googlesource.com/c/chromium/src/+/958943
CL to disable https://chromium-review.googlesource.com/c/chromium/src/+/964614
I am investigating the flake.
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/080959b729974bc2676438f04b4ada15008027fc

commit 080959b729974bc2676438f04b4ada15008027fc
Author: Helen Li <xunjieli@chromium.org>
Date: Thu Mar 15 18:46:05 2018

Disable TCPSocketTest.ServerReceivesMultipleAccept temporarily

This test is flaky on Mac. This CL disables it temporarily.

Bug:  821224 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I909087ed5102631fdca68b45d9a0c4b6810410fc
Reviewed-on: https://chromium-review.googlesource.com/964614
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543459}
[modify] https://crrev.com/080959b729974bc2676438f04b4ada15008027fc/services/network/tcp_socket_unittest.cc

Cc: crouleau@chromium.org
 Issue 822408  has been merged into this issue.
Cc: -crouleau@chromium.org mmenke@chromium.org
Status: Started (was: Assigned)
I am able to repro this locally today. I will look into it.
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/753174b03d5cb75d5d673e0c4f3a82dcc36e7014

commit 753174b03d5cb75d5d673e0c4f3a82dcc36e7014
Author: Helen Li <xunjieli@chromium.org>
Date: Fri Mar 16 17:21:35 2018

Fix and re-enable TCPSocketTest.ServerReceivesMultipleAccept

This test is flaky because the test closes client connection during each
for-loop iteration. When server checks whether the connection is still connected
using accepted_socket_->GetPeerAddress() in
network::TCPServerSocket::OnAcceptCompleted(), it will get
net::ERR_SOCKET_NOT_CONNECTED (-15).

This test keeps the client sockets alive and delay disconnecting them until
server finishes all Accept() callbacks.

Bug:  821224 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I7bf12704272f9ccc23c085c6d72db28a3d0dbe67
Reviewed-on: https://chromium-review.googlesource.com/966802
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543743}
[modify] https://crrev.com/753174b03d5cb75d5d673e0c4f3a82dcc36e7014/services/network/tcp_socket_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment