New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 821220 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Proj-XR



Sign in to add a comment

Vr omnibox rendered too high when using fallback assets

Project Member Reported by bsheedy@chromium.org, Mar 13 2018

Issue description

When using the VR browser with the fallback assets, the omnibox is rendered much higher than usual, ~in the middle of the content quad (see attached screenshot). This does not reproduce when using the actual assets.

Assigning to tiborg@ since this seems to be at least somewhat related to assets/components.
 
Screenshot_20180312-165614.png
717 KB View Download

Comment 1 by tiborg@chromium.org, Mar 14 2018

Labels: Hotlist-VRB-MVP
I'm not able to reproduce during normal usage (inserting phone into headset with a page loaded), although I'm also not seeing the ~2 seconds of black that normally occurred when no assets were available.
Got the 2 second wait (apparently I had the wrong APK installed), but still no repro during normal usage. Still reproduces when running Telemetry tests without the assets.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1ccbb60bbcb063fd9b1f614dfad89e6fcdbe9fd

commit a1ccbb60bbcb063fd9b1f614dfad89e6fcdbe9fd
Author: Ian Vollick <vollick@chromium.org>
Date: Thu Mar 15 14:02:04 2018

[vr] handle sizing to children and anchoring

Previously we would not relayout children if the size changed. This is
problematic for children that wish to anchor to their parent.

Bug:  821220 
Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I3cbc91fd9a4d4d398d8ef3eba5f42b1f577f46f2
Reviewed-on: https://chromium-review.googlesource.com/962972
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543361}
[modify] https://crrev.com/a1ccbb60bbcb063fd9b1f614dfad89e6fcdbe9fd/chrome/browser/vr/elements/ui_element.cc
[modify] https://crrev.com/a1ccbb60bbcb063fd9b1f614dfad89e6fcdbe9fd/chrome/browser/vr/elements/ui_element_unittest.cc

Comment 5 by tiborg@chromium.org, Mar 15 2018

Owner: vollick@chromium.org
Status: Fixed (was: Assigned)
Labels: Test-Complete
Components: Internals>XR

Sign in to add a comment