Currently, many components in device/fido modules has prefix "U2f". For components that applies to both U2F and CTAP, change prefix to "Fido.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed572c2b742c58dfcb172b0e5b339a7119654440 commit ed572c2b742c58dfcb172b0e5b339a7119654440 Author: Jun Choi <hongjunchoi@chromium.org> Date: Thu Mar 15 16:35:55 2018 Consolidate shared device constants Clean up {Hid, Ble}Device by consolidating shared constructs and rename constants with prefix U2f to have prefix Fido. More specifically, 1) Consolidate HidDevice::State / BleDevice::State into U2fDevice interface. 2) Rename BLE constants (e.g. service id) to have fido as prefix. 3) Move U2fDevice::ProtocolVersion to fido_constants.h 4) Delete u2f_command_type.h file. This contents in this file is neither U2F nor correct. U2fCommandType enum currently mixes HID command type and BLE command types. Remove the file and add separate command type enums in fido_constants.h Bug: 821215 Change-Id: I45bce9323ac95d83c31e7b90a2548b745d9e00b2 Reviewed-on: https://chromium-review.googlesource.com/961618 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#543400} [modify] https://crrev.com/ed572c2b742c58dfcb172b0e5b339a7119654440/device/fido/BUILD.gn [add] https://crrev.com/ed572c2b742c58dfcb172b0e5b339a7119654440/device/fido/fido_ble_uuids.cc [add] https://crrev.com/ed572c2b742c58dfcb172b0e5b339a7119654440/device/fido/fido_ble_uuids.h [modify] https://crrev.com/ed572c2b742c58dfcb172b0e5b339a7119654440/device/fido/fido_constants.cc [modify] https://crrev.com/ed572c2b742c58dfcb172b0e5b339a7119654440/device/fido/fido_constants.h [modify] https://crrev.com/ed572c2b742c58dfcb172b0e5b339a7119654440/device/fido/fido_hid_message.cc [modify] https://crrev.com/ed572c2b742c58dfcb172b0e5b339a7119654440/device/fido/fido_hid_message.h [modify] https://crrev.com/ed572c2b742c58dfcb172b0e5b339a7119654440/device/fido/fido_hid_message_unittest.cc [modify] https://crrev.com/ed572c2b742c58dfcb172b0e5b339a7119654440/device/fido/fido_hid_packet.cc [modify] https://crrev.com/ed572c2b742c58dfcb172b0e5b339a7119654440/device/fido/fido_hid_packet.h [modify] https://crrev.com/ed572c2b742c58dfcb172b0e5b339a7119654440/device/fido/u2f_ble_connection.cc [modify] https://crrev.com/ed572c2b742c58dfcb172b0e5b339a7119654440/device/fido/u2f_ble_connection_unittest.cc [modify] https://crrev.com/ed572c2b742c58dfcb172b0e5b339a7119654440/device/fido/u2f_ble_device.cc [modify] https://crrev.com/ed572c2b742c58dfcb172b0e5b339a7119654440/device/fido/u2f_ble_device.h [modify] https://crrev.com/ed572c2b742c58dfcb172b0e5b339a7119654440/device/fido/u2f_ble_device_unittest.cc [modify] https://crrev.com/ed572c2b742c58dfcb172b0e5b339a7119654440/device/fido/u2f_ble_discovery.cc [modify] https://crrev.com/ed572c2b742c58dfcb172b0e5b339a7119654440/device/fido/u2f_ble_frames.cc [modify] https://crrev.com/ed572c2b742c58dfcb172b0e5b339a7119654440/device/fido/u2f_ble_frames.h [modify] https://crrev.com/ed572c2b742c58dfcb172b0e5b339a7119654440/device/fido/u2f_ble_frames_fuzzer.cc [modify] https://crrev.com/ed572c2b742c58dfcb172b0e5b339a7119654440/device/fido/u2f_ble_frames_unittest.cc [modify] https://crrev.com/ed572c2b742c58dfcb172b0e5b339a7119654440/device/fido/u2f_ble_transaction.cc [delete] https://crrev.com/e81170d2478fc54b9113d1310524983be33f7a53/device/fido/u2f_ble_uuids.cc [delete] https://crrev.com/e81170d2478fc54b9113d1310524983be33f7a53/device/fido/u2f_ble_uuids.h [delete] https://crrev.com/e81170d2478fc54b9113d1310524983be33f7a53/device/fido/u2f_command_type.h [modify] https://crrev.com/ed572c2b742c58dfcb172b0e5b339a7119654440/device/fido/u2f_device.cc [modify] https://crrev.com/ed572c2b742c58dfcb172b0e5b339a7119654440/device/fido/u2f_device.h [modify] https://crrev.com/ed572c2b742c58dfcb172b0e5b339a7119654440/device/fido/u2f_hid_device.cc [modify] https://crrev.com/ed572c2b742c58dfcb172b0e5b339a7119654440/device/fido/u2f_hid_device.h [modify] https://crrev.com/ed572c2b742c58dfcb172b0e5b339a7119654440/device/fido/u2f_hid_device_unittest.cc [modify] https://crrev.com/ed572c2b742c58dfcb172b0e5b339a7119654440/device/fido/u2f_request.cc [modify] https://crrev.com/ed572c2b742c58dfcb172b0e5b339a7119654440/device/fido/u2f_request.h [modify] https://crrev.com/ed572c2b742c58dfcb172b0e5b339a7119654440/device/fido/u2f_request_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c5201b6c23fd99358ef26b9a37f0b0974bc70fb6 commit c5201b6c23fd99358ef26b9a37f0b0974bc70fb6 Author: Jun Choi <hongjunchoi@chromium.org> Date: Fri Mar 23 01:32:56 2018 Rename U2fReturnCode to FidoReturnCode Change U2fReturnCode to FidoReturnCode as U2fReturnCode represents response return code for both U2F and CTAP protocols. Also, remove device/fido/u2f_return_code.h and put FidoReturnCode into device/fido_constants.h Bug: 821215 Change-Id: I36d0700659434c3ce4dca94493064fa4f21a32d8 Reviewed-on: https://chromium-review.googlesource.com/959675 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#545330} [modify] https://crrev.com/c5201b6c23fd99358ef26b9a37f0b0974bc70fb6/content/browser/webauth/authenticator_impl.cc [modify] https://crrev.com/c5201b6c23fd99358ef26b9a37f0b0974bc70fb6/content/browser/webauth/authenticator_impl.h [modify] https://crrev.com/c5201b6c23fd99358ef26b9a37f0b0974bc70fb6/device/fido/BUILD.gn [modify] https://crrev.com/c5201b6c23fd99358ef26b9a37f0b0974bc70fb6/device/fido/fido_constants.h [modify] https://crrev.com/c5201b6c23fd99358ef26b9a37f0b0974bc70fb6/device/fido/u2f_register.cc [modify] https://crrev.com/c5201b6c23fd99358ef26b9a37f0b0974bc70fb6/device/fido/u2f_register.h [modify] https://crrev.com/c5201b6c23fd99358ef26b9a37f0b0974bc70fb6/device/fido/u2f_register_unittest.cc [delete] https://crrev.com/790e7a85773ebdd4e2f2a25409a5eb4bda8c964d/device/fido/u2f_return_code.h [modify] https://crrev.com/c5201b6c23fd99358ef26b9a37f0b0974bc70fb6/device/fido/u2f_sign.cc [modify] https://crrev.com/c5201b6c23fd99358ef26b9a37f0b0974bc70fb6/device/fido/u2f_sign.h [modify] https://crrev.com/c5201b6c23fd99358ef26b9a37f0b0974bc70fb6/device/fido/u2f_sign_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6627d311229295258e386fb8ff8912a5810bab75 commit 6627d311229295258e386fb8ff8912a5810bab75 Author: Balazs Engedy <engedy@chromium.org> Date: Mon Mar 26 08:58:44 2018 Rename VirtualU2fDevice -> VirtualFidoDevice. Rename the last holdout that is using the old name. Bug: 821215 Change-Id: I45cafaab27f7ef42eaef748088910d8d28f5260c Reviewed-on: https://chromium-review.googlesource.com/979450 Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#545742} [modify] https://crrev.com/6627d311229295258e386fb8ff8912a5810bab75/content/browser/webauth/authenticator_impl_unittest.cc [modify] https://crrev.com/6627d311229295258e386fb8ff8912a5810bab75/device/fido/BUILD.gn [add] https://crrev.com/6627d311229295258e386fb8ff8912a5810bab75/device/fido/scoped_virtual_fido_device.cc [add] https://crrev.com/6627d311229295258e386fb8ff8912a5810bab75/device/fido/scoped_virtual_fido_device.h [delete] https://crrev.com/472c686372447fce13f78ccfbffec06e1da2f4ee/device/fido/scoped_virtual_u2f_device.cc [delete] https://crrev.com/472c686372447fce13f78ccfbffec06e1da2f4ee/device/fido/scoped_virtual_u2f_device.h [modify] https://crrev.com/6627d311229295258e386fb8ff8912a5810bab75/device/fido/u2f_register_unittest.cc [modify] https://crrev.com/6627d311229295258e386fb8ff8912a5810bab75/device/fido/u2f_request.cc [modify] https://crrev.com/6627d311229295258e386fb8ff8912a5810bab75/device/fido/u2f_sign_unittest.cc [rename] https://crrev.com/6627d311229295258e386fb8ff8912a5810bab75/device/fido/virtual_fido_device.cc [rename] https://crrev.com/6627d311229295258e386fb8ff8912a5810bab75/device/fido/virtual_fido_device.h
Comment 1 by hongjunchoi@chromium.org
, Mar 15 2018