New issue
Advanced search Search tips

Issue 821200 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Better error messages for tryjobs picking patch from wrong branch

Project Member Reported by jwer...@chromium.org, Mar 12 2018

Issue description

What steps will reproduce the problem?
(1) Upload a Gerrit patch for one branch (e.g. ToT)
(2) Run a tryjob with a -g argument referencing that patch and a -b argument referencing a different branch (e.g. some firmware branch)

What is the expected result?

The tryjob fails with a clear error, e.g. "CL:XXX is not compatible with branch Y". Bonus points if this check is done during the execution of the cros tryjob command and not 30 minutes later on the server. Extra bonus points if the tryjob just runs correctly instead when the patch can be cleanly cherry-picked across branches.

What happens instead?

https://logs.chromium.org/v/?s=chromeos%2Fbb%2Fchromiumos.tryserver%2Ffirmware%2F228%2F%2B%2Frecipes%2Fsteps%2FPatchChanges%2F0%2Fstdout

This tryjob was started with:

 cros tryjob -g 957711 -b firmware-oak-8438.B hana-firmware

The most clear indication about what the problem is is the enigmatic line:

ChangeNotInManifest: CL:957711 could not be found in the repo manifest.
 
Status: Available (was: Untriaged)
I think cros tryjob already has all the data to detect that the patch is from a different branch. If so adding a warning or error for that should be easy.

Improving the error message in sync stage is reasonable, but may be harder than it sounds.

PS: I thought the tryjob would run on a clean cherry-pick.

> PS: I thought the tryjob would run on a clean cherry-pick.

Well... the patch I tried to pick there applies cleanly to that branch (when I try it locally), so if that was supposed to work can you figure out why it didn't?

Sign in to add a comment