Khalil, Gabe, do you have any input on Accessibility Announcements text?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f02f6d09f28edc5bcfce5c38f1bbe19c58809e1b

commit f02f6d09f28edc5bcfce5c38f1bbe19c58809e1b
Author: Eugene But <eugenebut@google.com>
Date: Tue Mar 13 15:12:51 2018

Added A11y announcements for New Download Manager.

The strings has not beed finalized yet, and will be updated in a
separate CL.

Bug:  821188 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I28e4883e84ec07e003c6a799d7a060640ee41038
Reviewed-on: https://chromium-review.googlesource.com/959589
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Louis Romero <lpromero@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542802}
[modify] https://crrev.com/f02f6d09f28edc5bcfce5c38f1bbe19c58809e1b/ios/chrome/app/strings/ios_strings.grd
[modify] https://crrev.com/f02f6d09f28edc5bcfce5c38f1bbe19c58809e1b/ios/chrome/browser/ui/download/download_manager_mediator.h
[modify] https://crrev.com/f02f6d09f28edc5bcfce5c38f1bbe19c58809e1b/ios/chrome/browser/ui/download/download_manager_mediator.mm

Khalil, Gabe, do you have any suggestions, or you are good with proposed strings?

Shimi, do you have any suggestions here? Or proposed language is good enough?

Tested this in Canary, where the "File download is available" voiceover keeps getting cut off by the "zero percent" voiceover before it's done being read off. Not sure if this is just an issue with Canary or will happen in stable.

Also, when I tapped on the download link, it was hard to imagine how (if I was blind) I would know that the next button I should tap on would be "Download" in the infobar. Is there any way to select the "Download" button as the next button that's highlighted by Voiceover? I'm afraid users won't realize that they're not done with the download flow if they don't realize they have to tap on the infobar to initiate it.

Otherwise seemed good and compared well to Safari and current Chrome stable implementation on Voiceover.

#1. Regarding cut off problem. That's how Voice Over works, I'm not sure what we can do here.

#2. Seems like expected behavior. The user performs flick gesture to navigate between controls.

Shimi, could you please advice on strings.

Laura, what do you think of the 2nd point in Comment 7? Would it be unduly hard for a Voiceover user to get to their download given that they have to find out about step 2 of having to hit download again but in an infobar? 

The inforbar is not the next contol in line as the user flicks right to navigate controls. In fact, I wasn't able to reach it at all except by tapping directly on the infobar.

Is there some way to focus on the infobar "Download" control as the next control to highlight?

Re: strings, one small edit in the interest of brevity: remove the word "successfully".

- "File download is available" (when UI shows up)
- "Download finished" (when download is successfully finished)
- "Download failed" (when download failed)

I seem to recall in other cases we say "Showing infobar" to alert the user to the presence of an infobar on the screen. Laura, WDYT about that?

Eugene, if you can remove the "Successfully" in time for the release, that would be good.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c676673f665a9208768dfa3231fd491a8022a963

commit c676673f665a9208768dfa3231fd491a8022a963
Author: Eugene But <eugenebut@chromium.org>
Date: Mon Apr 09 15:48:06 2018

Update accessibility anouncement for Download Manager.

s/Download sucessfully finished/Download finished

Bug:  821188 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4b5bb837ed2c228b8b173010489d0db0b9251516
Reviewed-on: https://chromium-review.googlesource.com/1000100
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549186}
[modify] https://crrev.com/c676673f665a9208768dfa3231fd491a8022a963/ios/chrome/app/strings/ios_strings.grd