New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 821178 link

Starred by 1 user
Status: Verified
Owner:
lijeffrey@chromium.org
Closed: Apr 2018
Cc:
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Findit] Flake Analyzer - try_job.TriggerTryJob expects dimensions as a list, not ListOfBasestring

Project Member Reported by lijeffrey@chromium.org, Mar 12 2018 
TriggerTryJob expects the raw list rather than a list of basestring.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/4b9c3e1d41b9f03fb6e8243fd61fb749a61c4759

commit 4b9c3e1d41b9f03fb6e8243fd61fb749a61c4759
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Tue Mar 13 20:45:33 2018

[Findit] Flake Analyzer - Pass dimensions as raw list when triggering try job

services/try_job.py's TriggerTryJob expects dimensions to be passed as a raw list,
not the dto ListOfBasestring which is used for input validation when passing
between pipelines.

Bug:  821178 
Change-Id: I853a66d6bb946447de5e2fc1163e58031ce5b4cb
Reviewed-on: https://chromium-review.googlesource.com/959556
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>

[modify] https://crrev.com/4b9c3e1d41b9f03fb6e8243fd61fb749a61c4759/appengine/findit/services/try_job.py
[modify] https://crrev.com/4b9c3e1d41b9f03fb6e8243fd61fb749a61c4759/appengine/findit/services/flake_failure/flake_try_job.py

Comment 2 by lijeffrey@chromium.org, Apr 23 2018

Status: Verified (was: Assigned)
►

Sign in to add a comment