New issue
Advanced search Search tips

Issue 821176 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on: View detail
issue 822857
issue 822859
issue 924369

Blocking:
issue 644851



Sign in to add a comment

Skia Renderer should pass same pixel tests as GL Renderer

Project Member Reported by weiliangc@chromium.org, Mar 12 2018

Issue description

Current failing list including:
    RendererPixelTest/2.EnlargedRenderPassTextureWithAntiAliasing (../../components/viz/service/display/renderer_pixeltest.cc:2111)
    RendererPixelTest/2.FastPassColorFilterAlpha (../../components/viz/service/display/renderer_pixeltest.cc:1785)
    RendererPixelTest/2.FastPassColorFilterAlphaTranslation (../../components/viz/service/display/renderer_pixeltest.cc:1985)
    RendererPixelTest/2.FastPassFilterChain (../../components/viz/service/display/renderer_pixeltest.cc:1923)
    RendererPixelTest/2.FastPassSaturateFilter (../../components/viz/service/display/renderer_pixeltest.cc:1863)
    RendererPixelTest/2.RenderPassAndMaskWithPartialQuad (../../components/viz/service/display/renderer_pixeltest.cc:2167)
    RendererPixelTest/2.RenderPassAndMaskWithPartialQuad2 (../../components/viz/service/display/renderer_pixeltest.cc:2266)
    RendererPixelTest/2.TileDrawQuadNearestNeighbor (../../components/viz/service/display/renderer_pixeltest.cc:3211)


Also need list of GLRendererPixelTest* passed with SkiaRenderer as well.
 
Blockedon: 822857
Blockedon: 822859
Now Skia supports RGB, the current list of failing tests include:    
    RendererPixelTest/2.FastPassColorFilterAlpha (../../components/viz/service/display/renderer_pixeltest.cc:1756)
    RendererPixelTest/2.FastPassColorFilterAlphaTranslation (../../components/viz/service/display/renderer_pixeltest.cc:1956)
    RendererPixelTest/2.FastPassFilterChain (../../components/viz/service/display/renderer_pixeltest.cc:1894)
    RendererPixelTest/2.FastPassSaturateFilter (../../components/viz/service/display/renderer_pixeltest.cc:1834)
    RendererPixelTest/2.RenderPassAndMaskWithPartialQuad (../../components/viz/service/display/renderer_pixeltest.cc:2139)
    RendererPixelTest/2.RenderPassAndMaskWithPartialQuad2 (../../components/viz/service/display/renderer_pixeltest.cc:2238)
    RendererPixelTest/2.TileDrawQuadNearestNeighbor (../../components/viz/service/display/renderer_pixeltest.cc:3185)

As well as:
2 tests failed:
    IntersectingQuadPixelTest/2.RenderPassQuads (../../components/viz/service/display/renderer_pixeltest.cc:1256)
    IntersectingQuadPixelTest/2.TexturedQuads (../../components/viz/service/display/renderer_pixeltest.cc:1180)
Project Member

Comment 4 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73106f3287c215e0b12d4870e3fd1661f093850c

commit 73106f3287c215e0b12d4870e3fd1661f093850c
Author: Xu Xing <xing.xu@intel.com>
Date: Thu May 24 00:29:11 2018

viz: Fix IntersectingQuadPixelTest on SkiaRenderer

BUG=821176

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: If78dca0b4526fb85f09ff6a641b5dc7e18bb12b3
Reviewed-on: https://chromium-review.googlesource.com/1068649
Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: Xing Xu <xing.xu@intel.com>
Cr-Commit-Position: refs/heads/master@{#561330}
[modify] https://crrev.com/73106f3287c215e0b12d4870e3fd1661f093850c/components/viz/service/display/renderer_pixeltest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a02ed7abb26db43cc75b064a7ede722609583a95

commit a02ed7abb26db43cc75b064a7ede722609583a95
Author: Xu Xing <xing.xu@intel.com>
Date: Thu May 31 01:43:24 2018

viz: SkColor to uint32_t

The color here is not a real SkColor, use uint32_t instead.
This is a follow up for(Brian Salomon comments):
https://chromium-review.googlesource.com/c/chromium/src/+/1068649

BUG=821176

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I69adc5cebffee772634186fc8d9438de8e3e8523
Reviewed-on: https://chromium-review.googlesource.com/1074831
Reviewed-by: Brian Salomon <bsalomon@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: Xing Xu <xing.xu@intel.com>
Cr-Commit-Position: refs/heads/master@{#563114}
[modify] https://crrev.com/a02ed7abb26db43cc75b064a7ede722609583a95/components/viz/service/display/renderer_pixeltest.cc

Double checking for renderer_pixeltest.cc file, failures that would happen right now:
    NonSkiaRendererPixelTest/2.TileDrawQuadNearestNeighbor (../../components/viz/service/display/renderer_pixeltest.cc:3389)
    NonSkiaRendererPixelTest/3.TileDrawQuadNearestNeighbor (../../components/viz/service/display/renderer_pixeltest.cc:3389)

    IntersectingQuadGLPixelTest/1.Y16VideoQuads (../../components/viz/service/display/renderer_pixeltest.cc:1523)
    IntersectingQuadGLPixelTest/1.YUVVideoQuads (../../components/viz/service/display/renderer_pixeltest.cc:1494)

Still need to check other pixel tests.

Comment 7 by weiliangc@chromium.org, Today (13 hours ago)

Blockedon: 924369

Comment 8 by weiliangc@chromium.org, Today (13 hours ago)

Trying to convert GLRendererPixelTest into testing with SkiaRenderer as well, got another list of failures:
9 tests failed:
    GLCapableRendererPixelTest/1.AntiAliasing (../../components/viz/service/display/renderer_pixeltest.cc:2787)
    GLCapableRendererPixelTest/1.AntiAliasingPerspective (../../components/viz/service/display/renderer_pixeltest.cc:3031)
    GLCapableRendererPixelTest/1.AxisAligned (../../components/viz/service/display/renderer_pixeltest.cc:2826)
    GLCapableRendererPixelTest/1.NonPremultipliedTextureWithBackground (../../components/viz/service/display/renderer_pixeltest.cc:1575)
    GLCapableRendererPixelTest/1.PremultipliedTextureWithBackgroundAndVertexOpacity (../../components/viz/service/display/renderer_pixeltest.cc:1140)
    GLCapableRendererPixelTest/1.RenderPassDrawQuadForceAntiAliasingOff (../../components/viz/service/display/renderer_pixeltest.cc:2908)
    GLCapableRendererPixelTest/1.SolidColorDrawQuadForceAntiAliasingOff (../../components/viz/service/display/renderer_pixeltest.cc:2871)
    GLCapableRendererPixelTest/1.TileDrawQuadForceAntiAliasingOff (../../components/viz/service/display/renderer_pixeltest.cc:2966)
    GLCapableRendererPixelTest/1.TileQuadClamping (../../components/viz/service/display/renderer_pixeltest.cc:3915)
1 test crashed:
    GLCapableRendererPixelTest/1.TrilinearFiltering (../../components/viz/service/display/renderer_pixeltest.cc:3067)

Comment 9 by weiliangc@chromium.org, Today (13 hours ago)

Cc: backer@chromium.org penghuang@chromium.org
Well with in flight color space change there is one less test.
8 tests failed:
    GLCapableRendererPixelTest/1.AntiAliasing (../../components/viz/service/display/renderer_pixeltest.cc:2787)
    GLCapableRendererPixelTest/1.AntiAliasingPerspective (../../components/viz/service/display/renderer_pixeltest.cc:3031)
    GLCapableRendererPixelTest/1.AxisAligned (../../components/viz/service/display/renderer_pixeltest.cc:2826)
    GLCapableRendererPixelTest/1.PremultipliedTextureWithBackgroundAndVertexOpacity (../../components/viz/service/display/renderer_pixeltest.cc:1140)
    GLCapableRendererPixelTest/1.RenderPassDrawQuadForceAntiAliasingOff (../../components/viz/service/display/renderer_pixeltest.cc:2908)
    GLCapableRendererPixelTest/1.SolidColorDrawQuadForceAntiAliasingOff (../../components/viz/service/display/renderer_pixeltest.cc:2871)
    GLCapableRendererPixelTest/1.TileDrawQuadForceAntiAliasingOff (../../components/viz/service/display/renderer_pixeltest.cc:2966)
    GLCapableRendererPixelTest/1.TileQuadClamping (../../components/viz/service/display/renderer_pixeltest.cc:3915)
1 test crashed:
    GLCapableRendererPixelTest/1.TrilinearFiltering (../../components/viz/service/display/renderer_pixeltest.cc:3067)
Tests took 7 seconds.

But it is pretty obvious that AA is not set up correctly. :/

Sign in to add a comment