Issue metadata
Sign in to add a comment
|
10713.5% regression in smoothness.tough_scrolling_cases at 541270:541412 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Mar 12 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14ec4636440000
,
Mar 13 2018
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/14ec4636440000 Android: WindowAndroid returns mouse wheel scroll factor by jinsukkim@chromium.org https://chromium.googlesource.com/chromium/src/+/00e4698b772d9c266b88b69ea7f0824afe194f2e Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Mar 14 2018
Issue 821102 has been merged into this issue.
,
Mar 14 2018
,
Mar 14 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14cd949e440000
,
Mar 14 2018
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/14cd949e440000 Fix scrolling perf regression by jinsukkim@chromium.org https://chromium-review.googlesource.com/c/chromium/src/+/961503/1 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Mar 14 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14b757ce440000
,
Mar 14 2018
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/14b757ce440000 Fix scrolling perf regression by jinsukkim@chromium.org https://chromium-review.googlesource.com/c/chromium/src/+/961503/3 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Mar 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4583ba5da2ed63d2565da9b91feac50a574647ab commit 4583ba5da2ed63d2565da9b91feac50a574647ab Author: Jinsuk Kim <jinsukkim@chromium.org> Date: Wed Mar 14 04:58:56 2018 Fix scrolling perf regression pixels per mouse_scroll_wheel_tick was being set wrong (should have been wheel_scroll_factor but was the value divided by dip_scale was set), hence decreased the scroll rate and caused the regression. This CL fixes the issue. Now WindowAndroid stores wheel_scroll_factor (instead of tick multiplier) which is accessed much more often, for efficiency's sake. Bug: 821101 Change-Id: I99e81fdfc21ec101a99092c50555be4f429d7a20 Reviewed-on: https://chromium-review.googlesource.com/961503 Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#543013} [modify] https://crrev.com/4583ba5da2ed63d2565da9b91feac50a574647ab/content/browser/renderer_host/render_widget_host_view_android.cc [modify] https://crrev.com/4583ba5da2ed63d2565da9b91feac50a574647ab/ui/android/event_forwarder.cc [modify] https://crrev.com/4583ba5da2ed63d2565da9b91feac50a574647ab/ui/android/window_android.cc [modify] https://crrev.com/4583ba5da2ed63d2565da9b91feac50a574647ab/ui/android/window_android.h
,
Mar 14 2018
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Mar 12 2018