New issue
Advanced search Search tips

Issue 821099 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

fastmail.com doesn't accept generic U2F certificates

Project Member Reported by agl@chromium.org, Mar 12 2018

Issue description

fastmail.com expects to be able to parse a valid ECDSA signature out of the self-signed part of a U2F certificate. Thus we should give it one. Bug filed for tracking merge into M66.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da6c0322c00f20b81bb7176000f5fc92b50659b3

commit da6c0322c00f20b81bb7176000f5fc92b50659b3
Author: Adam Langley <agl@chromium.org>
Date: Mon Mar 12 20:27:58 2018

cryptotoken: provide parsable certificate signature.

The replacement attestation certificates didn't provide a self-signature
because nobody can validate our certificates. However, fastmail.com
expects to be able to parse an ECDSA signature even if they don't check
it.

Therefore this change provides a syntactically valid signature in the
certificate and fixes enrollment on fastmail.com

Bug:  821099 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I332e078227eb36ba81e4cb089bd1f63ceb0bcbea
Reviewed-on: https://chromium-review.googlesource.com/959304
Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542583}
[modify] https://crrev.com/da6c0322c00f20b81bb7176000f5fc92b50659b3/chrome/browser/resources/cryptotoken/enroller.js

Comment 2 by agl@chromium.org, Mar 14 2018

Labels: Merge-Request-66
Requesting merge to M66 for the change linked to this bug. The change has been on Canary for a day without issues.

Risks: This change makes our synthesised attestation certificates look more like a real one, so the compatibility risks are minimal. Additionally, it fixes one user of U2F (fastmail.com) and hasn't affected any of the other sites that I've tested.
Labels: -Merge-Request-66 Merge-Approved-66
Approving merge for M66. Branch:3359
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 14 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bc138f85d63a1873113357006f325d8ceeeb1ef

commit 3bc138f85d63a1873113357006f325d8ceeeb1ef
Author: Adam Langley <agl@chromium.org>
Date: Wed Mar 14 20:21:08 2018

cryptotoken: provide parsable certificate signature.

The replacement attestation certificates didn't provide a self-signature
because nobody can validate our certificates. However, fastmail.com
expects to be able to parse an ECDSA signature even if they don't check
it.

Therefore this change provides a syntactically valid signature in the
certificate and fixes enrollment on fastmail.com

Bug:  821099 
Change-Id: I332e078227eb36ba81e4cb089bd1f63ceb0bcbea
Reviewed-on: https://chromium-review.googlesource.com/959304
Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/963229
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#246}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/3bc138f85d63a1873113357006f325d8ceeeb1ef/chrome/browser/resources/cryptotoken/enroller.js

Comment 5 by agl@chromium.org, Mar 14 2018

Status: Fixed (was: Assigned)

Sign in to add a comment