New issue
Advanced search Search tips

Issue 821094 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: ----


Previous locations:
gerrit:8492


Sign in to add a comment

Gerrit unable to convert Change-Id CQ-DEPENDS to links to another server

Project Member Reported by dbehr@chromium.org, Mar 6 2018

Issue description

Affected Version:

What steps will reproduce the problem?
1. Create CLs on chromium-review and chrome-internal-review
2. Link them with CQ-DEPENDS using Change-Id and * for Change-Id on internal server.
3. Upload them.
4. Click on CQ-DEPEND on either server, it does not take you to the other. It thinks the CL is on local server.

What is the expected output?
The link points to the other server.

What do you see instead?
Link pointing to local server instead of the other.

Please provide any additional information below.
Start from this CL https://chrome-internal-review.googlesource.com/#/c/chromeos/vendor/mali-ddk/+/576977/
 
I don't see any evidence of there ever having been an autolink regex for CQ-DEPEND lines. Is this supposed to work? What makes you think that stars before change-ids would cause it to autolink to a different host? Is this documented anywhere? Where?

Comment 2 by dbehr@chromium.org, Mar 6 2018

I don't know about evidence ;-) but if you open this URL for instance https://chrome-internal-review.googlesource.com/#/c/chromeos/vendor/mali-ddk/+/576977/ you can see clickable links created from Change-Ids.
It also works when you use CQ-DEPEND=CL:[*]cl_number notation. 
Everywhere in gerrit * (and cbuildbot too) is used as notation for marking internal changes that go to chrome-internal-review instead of chromium-review. It is not regex expression.

You can see for instance this CL for example on how CQ-DEPEND with star works https://chromium-review.googlesource.com/#/c/chromiumos/overlays/chromiumos-overlay/+/912048/ and takes you to internal server.

The problem is this does not work properly in Gerrit when using Change-Id instead of CL:xxxx or CL:*xxxx notation.
I see, so this isn't a regression, it's a feature requests to support the * syntax in more forms.

Are there places where the * form points from chrome-internal to chromium? Or is it only used on external reviews to indicate that the item it internal?

For future reference, it is regexes. The way those hyperlinks are automatically generated is via a set of regexes which are stored in the Gerrit host's base configuration. Some of the regexes (like automatically linking "I<40 character sha1>" to a change-id on the same server) are built-in to gerrit itself, while others (like automatically linking "CL:*123456" to a review on the internal host, or linking Bug: lines to Monorail) are custom specified by our own configuration.

Comment 4 by dbehr@chromium.org, Mar 6 2018

CL with star always creates a link to internal gerrit CL
CL without star always points to external open source gerrit
For instance this is an internal CL that has dependency on external (open source) CL https://chrome-internal-review.googlesource.com/#/c/chromeos/overlays/project-cheets-private/+/567098/
Star is always used to denote CL that resides on internal gerrit.
Those statements are not universally true; for example, on the change you just linked to, the Change-Id without a star links to the internal host.

It looks to me like there's good support for "CL:123" and "CL:*123", but not for change-ids. Do people expect this to work for change-ids? I don't believe it has ever worked for change-ids.

Comment 6 by dbehr@chromium.org, Mar 6 2018

I guess they are not universally true.

On this change https://chrome-internal-review.googlesource.com/#/c/chromeos/overlays/project-cheets-private/+/567098/
CQ-DEPEND=CL:912048 links to https://chromium-review.googlesource.com/#/q/912048

Change-Id in Change-Id: line links to internal host as expected.
I am askinga about Change-Ids in CQ-DEPEND lines. Not in Change-Id line.

I expect it (star) to work for change-ids in CQ-DEPEND line.
Otherwise it is not possible to upload changes with CQ-DEPENDS at upload time.
One would have to upload changes, look for CL numbers in both gerrits, add CQ-DEPENDS and re-upload changes again.

Comment 7 by logan@google.com, Mar 12 2018

Moving this over to the chromium project.

Comment 8 by logan@google.com, Mar 12 2018

Project: chromium
Moved issue gerrit:8492 to now be issue chromium:821094.

Comment 9 by logan@google.com, Mar 12 2018

Components: Infra>Codereview>Gerrit
Labels: Pri-3
Status: Available (was: New)

Sign in to add a comment