New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 821072 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Dec 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 802892



Sign in to add a comment

Consider moving HistogramTester to TaskTestBase

Project Member Reported by carlosk@chromium.org, Mar 12 2018

Issue description

Creating a HistogramTester instance in a test seems to be a heavyweight operation. We must balance that with the fact that many task tests do use it to check proper metrics reporting.

Once we have some time let's test how much of an impact creating an instance of it in every SetUp introduces and see how much slower become the tests that don't use it.


 

Comment 1 by carl...@google.com, Mar 12 2018

As we'll be would be running this time test anyway, we could also confirm the effect of creating the temporary dir for the OfflineItem generator as not all task tests actually need to save a file there. We this proves too expensive (whatever that means) we can reconsider having that initialization on SetUp.
Owner: carlosk@chromium.org
Status: Assigned (was: Available)
triage -> carlosk
Labels: Hotlist-Fixit
Personally, I think this class works out well as a local variable. It's one extra line in the test, and it gives you more control of when you want the UMA snapshotted.
Status: WontFix (was: Assigned)
I agree with that even though I have yet to encounter a case where that is actually needed for a test.

But as this didn't get much traction at all, marking as won't fix.

Sign in to add a comment