Consider moving HistogramTester to TaskTestBase |
||||
Issue descriptionCreating a HistogramTester instance in a test seems to be a heavyweight operation. We must balance that with the fact that many task tests do use it to check proper metrics reporting. Once we have some time let's test how much of an impact creating an instance of it in every SetUp introduces and see how much slower become the tests that don't use it.
,
Mar 21 2018
triage -> carlosk
,
Aug 14
,
Nov 30
Personally, I think this class works out well as a local variable. It's one extra line in the test, and it gives you more control of when you want the UMA snapshotted.
,
Dec 3
I agree with that even though I have yet to encounter a case where that is actually needed for a test. But as this didn't get much traction at all, marking as won't fix. |
||||
►
Sign in to add a comment |
||||
Comment 1 by carl...@google.com
, Mar 12 2018