New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 821063 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[POLICY TOOL] Post task 'rename' could be unsafe

Project Member Reported by rodmartin@google.com, Mar 12 2018

Issue description

Chrome Version: 66

'OnSessionRenamed' function can be cancelled if the object 'DoRenameSession' is deleted before 'OnSessionRename' ran.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56623302eeec884b893638e418f87b2f86f8e924

commit 56623302eeec884b893638e418f87b2f86f8e924
Author: rodmartin <rodmartin@google.com>
Date: Tue Mar 13 16:15:48 2018

Added rename session feature.

Bugs:  820546 , 820554,  821063 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0022b28d5b3289e9b87f2f06498cbd03212d19c4
Reviewed-on: https://chromium-review.googlesource.com/929754
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Georges Khalil <georgesak@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Martin Rodriguez <rodmartin@google.com>
Cr-Commit-Position: refs/heads/master@{#542818}
[modify] https://crrev.com/56623302eeec884b893638e418f87b2f86f8e924/chrome/browser/resources/policy_tool.css
[modify] https://crrev.com/56623302eeec884b893638e418f87b2f86f8e924/chrome/browser/resources/policy_tool.html
[modify] https://crrev.com/56623302eeec884b893638e418f87b2f86f8e924/chrome/browser/resources/policy_tool.js
[modify] https://crrev.com/56623302eeec884b893638e418f87b2f86f8e924/chrome/browser/ui/webui/policy_tool_ui.cc
[modify] https://crrev.com/56623302eeec884b893638e418f87b2f86f8e924/chrome/browser/ui/webui/policy_tool_ui_browsertest.cc
[modify] https://crrev.com/56623302eeec884b893638e418f87b2f86f8e924/chrome/browser/ui/webui/policy_tool_ui_handler.cc
[modify] https://crrev.com/56623302eeec884b893638e418f87b2f86f8e924/chrome/browser/ui/webui/policy_tool_ui_handler.h
[modify] https://crrev.com/56623302eeec884b893638e418f87b2f86f8e924/components/policy_strings.grdp

Status: Verified (was: Assigned)

Sign in to add a comment