New issue
Advanced search Search tips

Issue 821047 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 6
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-07-04
OS: iOS
Pri: 1
Type: Task
Q2



Sign in to add a comment

Support "reduce motion" acessibility setting in tab grid animations

Project Member Reported by marq@chromium.org, Mar 12 2018

Issue description

All animations associated with the tab grid should respect the "reduce motion" settings:

• Zooming in/out of the tab grid in transitions should use the simpler fade-and-enlarge animation.
• Tab grid element motion when deleting or reordering should use the collection view default behavior for this setting.

 

Comment 2 by marq@chromium.org, May 24 2018

NextAction: 2018-06-06
The NextAction date has arrived: 2018-06-06

Comment 4 by marq@chromium.org, Jun 27 2018

Labels: -Pri-2 Pri-1

Comment 5 by marq@chromium.org, Jun 27 2018

NextAction: 2018-06-18

Comment 6 by marq@chromium.org, Jun 27 2018

NextAction: 2018-07-04
Moving open tasks to the current sprint.
The NextAction date has arrived: 2018-07-04
Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c565bb768d327050ac2abe949bc243253ff6d35

commit 3c565bb768d327050ac2abe949bc243253ff6d35
Author: Mark Cogan <marq@google.com>
Date: Fri Jul 06 13:32:01 2018

[iOS] Support Reduce Motion in tag grid transitions.

This CL adds support for motion-reduced tab grid transitions.

The major change is to update the GridToHiddenTabAnimator to support
both presentation and dismissal, and rename it to ReducedMotionAnimator.

This animator is now used when reduced motion is enabled, as well as
for the prior case where the active tab isn't visible in the grid when
a tab is presented. The animation itself is unchanged.

Bug:  821047 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie78a8c089f333e3767ee9f88c0c3283d9f82326e
Reviewed-on: https://chromium-review.googlesource.com/1127043
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572954}
[modify] https://crrev.com/3c565bb768d327050ac2abe949bc243253ff6d35/ios/chrome/browser/ui/tab_grid/tab_grid_transition_handler.mm
[modify] https://crrev.com/3c565bb768d327050ac2abe949bc243253ff6d35/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
[modify] https://crrev.com/3c565bb768d327050ac2abe949bc243253ff6d35/ios/chrome/browser/ui/tab_grid/transitions/BUILD.gn
[delete] https://crrev.com/3921a8ad5dcd4bc79355d73145fc8d29dfc10b92/ios/chrome/browser/ui/tab_grid/transitions/grid_to_hidden_tab_animator.h
[delete] https://crrev.com/3921a8ad5dcd4bc79355d73145fc8d29dfc10b92/ios/chrome/browser/ui/tab_grid/transitions/grid_to_hidden_tab_animator.mm
[add] https://crrev.com/3c565bb768d327050ac2abe949bc243253ff6d35/ios/chrome/browser/ui/tab_grid/transitions/reduced_motion_animator.h
[add] https://crrev.com/3c565bb768d327050ac2abe949bc243253ff6d35/ios/chrome/browser/ui/tab_grid/transitions/reduced_motion_animator.mm

Status: Fixed (was: Started)

Sign in to add a comment