Issue metadata
Sign in to add a comment
|
Update to Chrome 65 breaks react js web app
Reported by
mgilli...@decisiv.com,
Mar 12 2018
|
||||||||||||||||||||||||
Issue description
UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
Steps to reproduce the problem:
1. Log into web app
2. Click on any link to other pages, wizards, etc.
3. Nothing happens, errors displayed in dev console
What is the expected behavior?
Clicking links should open the right pages
What went wrong?
Details of error messages:
index.js:53 Uncaught TypeError: this.props.loadBrandValues is not a function
at t.value (index.js:53)
at e.notifyAll (CallbackQueue.js:74)
at o.close (ReactReconcileTransaction.js:78)
at o.closeAll (Transaction.js:207)
at o.perform (Transaction.js:154)
at i (ReactMount.js:124)
at o.perform (Transaction.js:141)
at Object.batchedUpdates (ReactDefaultBatchingStrategy.js:60)
at Object.s [as batchedUpdates] (ReactUpdates.js:95)
at Object._renderNewRootComponent (ReactMount.js:317)
Uncaught TypeError: n is not a function
at t.o.initialize (Component.js:54)
at t.value (Component.js:33)
at d.performInitialMount (ReactCompositeComponent.js:348)
at d.mountComponent (ReactCompositeComponent.js:255)
at Object.mountComponent (ReactReconciler.js:43)
at d.performInitialMount (ReactCompositeComponent.js:368)
at d.mountComponent (ReactCompositeComponent.js:255)
at Object.mountComponent (ReactReconciler.js:43)
at d.performInitialMount (ReactCompositeComponent.js:368)
at d.mountComponent (ReactCompositeComponent.js:255)
And others similar
Did this work before? Yes Version 64.0.3282.140 (Official Build) (64-bit)
Chrome version: 65.0.3325.146 (Official Build) (64-bit). Channel: stable
OS Version: 10.0
Flash Version: None/built-in
,
Mar 12 2018
Our users have confirmed that this problem occurs on MacOS as well, not just Windows.
,
Mar 12 2018
,
Mar 12 2018
,
Mar 12 2018
mgilligan@ can you please provide us with a reduced testcase for further triage of the bug.
,
Mar 12 2018
Steps to Reproduce 1. In Chrome 65, open dev tools to Console tab 2. Navigate to fleet-web.decisivapps.com 3. You will be redirected to the SSO portal 4. Look at the console and see error message: Uncaught TypeError: this.props.loadBrandValues is not a function at t.value (fleet-web-qa.decisivapps.com/app-99635f340a96a736c1d3.js:1) at e.notifyAll (fleet-web-qa.decisivapps.com/vendor-ed2ea7b0accdfe5de509.js:1) at o.close (fleet-web-qa.decisivapps.com/vendor-ed2ea7b0accdfe5de509.js:1) at o.closeAll (fleet-web-qa.decisivapps.com/vendor-ed2ea7b0accdfe5de509.js:1) at o.perform (fleet-web-qa.decisivapps.com/vendor-ed2ea7b0accdfe5de509.js:1) at i (fleet-web-qa.decisivapps.com/vendor-ed2ea7b0accdfe5de509.js:1) at o.perform (fleet-web-qa.decisivapps.com/vendor-ed2ea7b0accdfe5de509.js:1) at Object.batchedUpdates (fleet-web-qa.decisivapps.com/vendor-ed2ea7b0accdfe5de509.js:1) at Object.s [as batchedUpdates] (fleet-web-qa.decisivapps.com/vendor-ed2ea7b0accdfe5de509.js:1) at Object._renderNewRootComponent (fleet-web-qa.decisivapps.com/vendor-ed2ea7b0accdfe5de509.js:1) The problem is actually invisible to the end user at this point, but once a user logs in and begins attempting to navigate the site, pages don't load and similar error messages are displayed in the console. I might be able to get a hotjar recording of this if that's necessary but hopefully this will help.
,
Mar 12 2018
Sorry about the above, I gave you the URL to production and actually copied the error from my QA server, but I think you get the picture. You can actually use either URL. :)
,
Mar 12 2018
Thank you for providing more feedback. Adding the requester to the cc list. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 12 2018
Please find the bisect result below : You are probably looking for a change made after 528597 (known good), but no later than 528598 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/0823211ed4a4abbd26ecb7df1408fe010ecb3412..4c1abec94b8ccef0ded4c1b110efded89713f5ff
,
Mar 12 2018
Please ignore the bisect from comment#9 which isn't right. mgilligan@ here is what I see. Steps to Reproduce 1. In Chrome 65, open dev tools to Console tab 2. Navigate to fleet-web.decisivapps.com Observed behavior : After I visit the url from step 2, I get redirected to SSO page but the "Uncaught TypeError" just flashes and go's off. All I see is "GET https://login.decisivapps.com/favicon.ico 404 (Not Found)"
,
Mar 12 2018
To repro you'll have to turn on "preserve log" in dev-tools before navigating to that URL. With that my bisect points to: You are probably looking for a change made after 528593 (known good), but no later than 528595 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/3d4d84928567f74d93d951932eafa1b3d779923b..a36bfd61bb03bc4a29510e628146963e85f74d9d
,
Mar 12 2018
Yes pbomm..., I saw the same thing. For some reason the Uncaught TypeError doesn't always get preserved in the log before being overwritten by that missing favicon message. Annoying! However, I just looked at http://fleet-web.decisivapps.com/ again and this time I see the Uncaught TypeError and not the 404 error. Weird? BTW, our lead dev has found a SHORT TERM WORKAROUND which I am testing internally now. Note from his PR: ===begin quoted text=== Chrome 65 is failing with the production version of React 15. This changes to use `NODE_ENV=development`, which causes the application to use the non-production version of React. It does however still get the minification etc included in our webpack config. ===end quoted text===
,
Mar 12 2018
According to the revision range from #11, https://chromium.googlesource.com/v8/v8/+log/919e79fd..d61daa4a is the v8 revision range, which contains only https://chromium.googlesource.com/v8/v8/+/03e9d415c2fbb51f6276b4abbb76d840f4106531 ("Reland: Reimplement Object.entries/values as CSA to optimize performance."). So this looks like a duplicate, marking as such.
,
Mar 12 2018
We rolled out the workaround (NODE_ENV=development) to https://fleet-web-qa.decisivapps.com and confirmed that it works. At some point we will probably also deploy this to the production environment(https://fleet-web.decisivapps.com). But we are hoping this is only a short term workaround because of the performance implications, etc. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by mgilli...@decisiv.com
, Mar 12 2018