New issue
Advanced search Search tips

Issue 821037 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Feature
Team-Security-UX



Sign in to add a comment

Add UMA histogram for nonsecure download content types

Project Member Reported by est...@chromium.org, Mar 12 2018

Issue description

We have a UMA histogram for the connection security state of a download (Download.TargetConnectionSecurity), and for the content type of a download (Download.Start.ContentType), but we don't have a histogram for nonsecure downloads broken down by content type. We should add this so we can tell how realistic it is to start blocking nonsecure downloads of dangerous file types.
 

Comment 1 by est...@chromium.org, Mar 12 2018

Labels: Hotlist-GoodFirstBug

Comment 2 by cthomp@chromium.org, Mar 20 2018

Owner: cthomp@chromium.org
Status: Started (was: Available)
Cc: est...@chromium.org
Labels: -Type-Bug -Pri-3 Pri-2 Type-Launch
Labels: -Type-Launch Type-Feature
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2360c69de7668e93f237c6ae2574f203aae3ad3

commit d2360c69de7668e93f237c6ae2574f203aae3ad3
Author: Christopher Thompson <cthomp@chromium.org>
Date: Wed Apr 11 18:35:35 2018

Add histogram for insecure download content type

This adds a new histogram for tracking the content types of downloads
started over insecure connections (or with insecure redirects). This
will help us determine how realistic it would be to start blocking
nonsecure downloads of dangerous file types.

Bug:  821037 
Change-Id: I43484490c46be37dfbcb2e039b3c43584b884d77
Reviewed-on: https://chromium-review.googlesource.com/972375
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549933}
[modify] https://crrev.com/d2360c69de7668e93f237c6ae2574f203aae3ad3/components/download/internal/common/download_stats.cc
[modify] https://crrev.com/d2360c69de7668e93f237c6ae2574f203aae3ad3/components/download/public/common/download_stats.h
[modify] https://crrev.com/d2360c69de7668e93f237c6ae2574f203aae3ad3/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/d2360c69de7668e93f237c6ae2574f203aae3ad3/tools/metrics/histograms/histograms.xml

Comment 6 by cthomp@chromium.org, Apr 16 2018

Status: Fixed (was: Started)

Sign in to add a comment