modifying a null mojo::ScopedDataPipeProducerHandle doesn't result in an error |
||||||||
Issue descriptionI have a mojo::ScopedDataPipeProducerHandle handle_. At some point, I did std::move(handle_), so handle_ is null. Then I did handle_->EndReadData() on that null handle. Mojo didn't give me any error. rockot@ suggested that this might be unintentional and we can add a DCHECK in https://cs.chromium.org/chromium/src/mojo/public/cpp/system/handle.h?rcl=44d54dc0c98f03c1fc731eaacd3a9497ef219292&l=97
,
Mar 12 2018
Not surprisingly, some tests are failing. CQ run is at https://chromium-review.googlesource.com/c/chromium/src/+/957918. I will take a look at the tests.
,
Mar 21 2018
,
Mar 22 2018
,
Apr 9 2018
,
Apr 10 2018
All blocking bugs have been fixed. The DCHECK CL (https://chromium-review.googlesource.com/c/chromium/src/+/957918) is cleared to land.
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/258b4c2761f30fc3b93041fc97cdc70fe461f217 commit 258b4c2761f30fc3b93041fc97cdc70fe461f217 Author: Helen Li <xunjieli@chromium.org> Date: Fri Apr 13 02:03:01 2018 Add a DCHECK in mojo/public/cpp/system/handle.h Bug: 821030 Change-Id: Iec0c32ba9cc7cb0335e7c320179e2689ab59bba6 Reviewed-on: https://chromium-review.googlesource.com/957918 Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#550477} [modify] https://crrev.com/258b4c2761f30fc3b93041fc97cdc70fe461f217/content/browser/renderer_host/clipboard_host_impl_unittest.cc [modify] https://crrev.com/258b4c2761f30fc3b93041fc97cdc70fe461f217/mojo/public/cpp/system/handle.h
,
Apr 13 2018
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/258b4c2761f30fc3b93041fc97cdc70fe461f217 commit 258b4c2761f30fc3b93041fc97cdc70fe461f217 Author: Helen Li <xunjieli@chromium.org> Date: Fri Apr 13 02:03:01 2018 Add a DCHECK in mojo/public/cpp/system/handle.h Bug: 821030 Change-Id: Iec0c32ba9cc7cb0335e7c320179e2689ab59bba6 Reviewed-on: https://chromium-review.googlesource.com/957918 Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#550477} [modify] https://crrev.com/258b4c2761f30fc3b93041fc97cdc70fe461f217/content/browser/renderer_host/clipboard_host_impl_unittest.cc [modify] https://crrev.com/258b4c2761f30fc3b93041fc97cdc70fe461f217/mojo/public/cpp/system/handle.h |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by xunji...@chromium.org
, Mar 12 2018