Issue 821025 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	mlamouri@chromium.org
Closed:	May 2018
Cc:	liber...@chromium.org
Components:	Blink>Media>Controls
EstimatedDays:	----
NextAction:	----
OS:	Windows
Pri:	3
Type:	Bug

Some media layout tests fail on win7

Project Member Reported by liber...@chromium.org, Mar 12 2018

Issue description

A rebaseline of blink layout tests didn't work for Win7.  it's unclear why.

media/audio-controls-rendering.html [ Failure ]
media/controls-after-reload.html [ Failure ]
media/controls-layout-direction.html [ Failure ]
media/controls-styling.html [ Failure ]
media/controls-styling-strict.html [ Failure ]
media/controls-without-preload.html [ Failure ]
media/media-controls-clone.html [ Failure ]
media/video-controls-rendering.html [ Failure ]
media/video-display-toggle.html [ Failure ]
media/video-empty-source.html [ Failure ]

i couldn't find a bug on it specifically, so i'm putting them all under this bug in TestExpectations, and will hopefully find the duplicate.

Comment 1 by liber...@chromium.org, Mar 12 2018

Labels: -OS-Mac

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7be4df953a97f8508fb8fe70679031ce3913b52e

commit 7be4df953a97f8508fb8fe70679031ce3913b52e
Author: liberato@chromium.org <liberato@chromium.org>
Date: Mon Mar 12 16:57:24 2018

Rebaseline some video tests.

This rebaselines the following tests, which had minor visual
differences from their refs:

media/audio-controls-rendering.html
media/controls-after-reload.html
media/controls-layout-direction.html
media/controls-styling.html
media/controls-styling-strict.html
media/controls-without-preload.html
media/media-controls-clone.html
media/video-controls-rendering.html
media/video-display-toggle.html
media/video-empty-source.html

Change-Id: Ic664381c7d16a85f94724d69fa65cb179ef5ea66
Bug:  612442 , 654477,  821025 
Reviewed-on: https://chromium-review.googlesource.com/956227
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542512}
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/audio-controls-rendering-expected.png
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/audio-controls-rendering-expected.txt
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/controls-after-reload-expected.png
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/controls-after-reload-expected.txt
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/controls-layout-direction-expected.png
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/controls-strict-expected.png
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/controls-strict-expected.txt
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-expected.png
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-expected.txt
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-strict-expected.png
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-strict-expected.txt
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/controls-without-preload-expected.png
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/controls-without-preload-expected.txt
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/media-controls-clone-expected.png
[delete] https://crrev.com/8d6af533c71cc145c291b7e62a02b5b2de197241/third_party/WebKit/LayoutTests/platform/linux/media/media-controls-clone-expected.txt
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/video-controls-rendering-expected.png
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/video-controls-rendering-expected.txt
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/video-display-toggle-expected.png
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/video-display-toggle-expected.txt
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/video-empty-source-expected.png
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/video-empty-source-expected.txt
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/video-no-audio-expected.png
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/linux/media/video-no-audio-expected.txt
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/audio-controls-rendering-expected.png
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/audio-controls-rendering-expected.txt
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/controls-after-reload-expected.png
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/controls-after-reload-expected.txt
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/controls-layout-direction-expected.png
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/controls-strict-expected.png
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/controls-strict-expected.txt
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/controls-styling-expected.png
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/controls-styling-expected.txt
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/controls-styling-strict-expected.png
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/controls-styling-strict-expected.txt
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/controls-without-preload-expected.png
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/controls-without-preload-expected.txt
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/media-controls-clone-expected.png
[rename] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/media-controls-clone-expected.txt
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/video-controls-rendering-expected.png
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/video-controls-rendering-expected.txt
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/video-display-toggle-expected.png
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/video-display-toggle-expected.txt
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/video-empty-source-expected.png
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/video-empty-source-expected.txt
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/video-no-audio-expected.png
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/mac/media/video-no-audio-expected.txt
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/audio-controls-rendering-expected.png
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/audio-controls-rendering-expected.txt
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/controls-after-reload-expected.png
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/controls-after-reload-expected.txt
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/controls-layout-direction-expected.png
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/controls-strict-expected.png
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/controls-strict-expected.txt
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/controls-styling-expected.png
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/controls-styling-expected.txt
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/controls-styling-strict-expected.png
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/controls-styling-strict-expected.txt
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/controls-without-preload-expected.png
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/controls-without-preload-expected.txt
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/media-controls-clone-expected.png
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/media-controls-clone-expected.txt
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/video-controls-rendering-expected.png
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/video-controls-rendering-expected.txt
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/video-display-toggle-expected.png
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/video-display-toggle-expected.txt
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/video-empty-source-expected.png
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/video-empty-source-expected.txt
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/video-no-audio-expected.png
[modify] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win/media/video-no-audio-expected.txt
[delete] https://crrev.com/8d6af533c71cc145c291b7e62a02b5b2de197241/third_party/WebKit/LayoutTests/platform/win7/media/controls-strict-expected.png
[delete] https://crrev.com/8d6af533c71cc145c291b7e62a02b5b2de197241/third_party/WebKit/LayoutTests/platform/win7/media/controls-strict-expected.txt
[copy] https://crrev.com/7be4df953a97f8508fb8fe70679031ce3913b52e/third_party/WebKit/LayoutTests/platform/win7/media/media-controls-clone-expected.txt
[delete] https://crrev.com/8d6af533c71cc145c291b7e62a02b5b2de197241/third_party/WebKit/LayoutTests/platform/win7/media/video-no-audio-expected.png
[delete] https://crrev.com/8d6af533c71cc145c291b7e62a02b5b2de197241/third_party/WebKit/LayoutTests/platform/win7/media/video-no-audio-expected.txt

Comment 3 by mlamouri@chromium.org, Apr 30 2018

Components: -Internals>Media>Video Blink>Media>Controls
Owner: mlamouri@chromium.org
Status: Started (was: Available)

Fixing this because it's on the way.

Project Member

Comment 4 by bugdroid1@chromium.org, May 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99e21d42ca74addc5f52c64064fc5962447b882d

commit 99e21d42ca74addc5f52c64064fc5962447b882d
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Tue May 01 23:55:37 2018

Media Controls: enable some tests that were disabled on Windows.

These tests needed to be marked as failing for the new virtual test
suite for video-surface-layer and it seemed as good to simply fix them.

Bug:  821025 
Change-Id: I4e350f15a937bfcea80b61340573534ccada8022
Reviewed-on: https://chromium-review.googlesource.com/1035268
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555235}
[modify] https://crrev.com/99e21d42ca74addc5f52c64064fc5962447b882d/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/99e21d42ca74addc5f52c64064fc5962447b882d/third_party/WebKit/LayoutTests/platform/win7/media/audio-controls-rendering-expected.png
[modify] https://crrev.com/99e21d42ca74addc5f52c64064fc5962447b882d/third_party/WebKit/LayoutTests/platform/win7/media/audio-controls-rendering-expected.txt
[modify] https://crrev.com/99e21d42ca74addc5f52c64064fc5962447b882d/third_party/WebKit/LayoutTests/platform/win7/media/controls-after-reload-expected.png
[modify] https://crrev.com/99e21d42ca74addc5f52c64064fc5962447b882d/third_party/WebKit/LayoutTests/platform/win7/media/controls-after-reload-expected.txt
[modify] https://crrev.com/99e21d42ca74addc5f52c64064fc5962447b882d/third_party/WebKit/LayoutTests/platform/win7/media/controls-layout-direction-expected.png
[modify] https://crrev.com/99e21d42ca74addc5f52c64064fc5962447b882d/third_party/WebKit/LayoutTests/platform/win7/media/controls-styling-expected.png
[modify] https://crrev.com/99e21d42ca74addc5f52c64064fc5962447b882d/third_party/WebKit/LayoutTests/platform/win7/media/controls-styling-expected.txt
[modify] https://crrev.com/99e21d42ca74addc5f52c64064fc5962447b882d/third_party/WebKit/LayoutTests/platform/win7/media/controls-styling-strict-expected.png
[modify] https://crrev.com/99e21d42ca74addc5f52c64064fc5962447b882d/third_party/WebKit/LayoutTests/platform/win7/media/controls-styling-strict-expected.txt
[modify] https://crrev.com/99e21d42ca74addc5f52c64064fc5962447b882d/third_party/WebKit/LayoutTests/platform/win7/media/controls-without-preload-expected.png
[modify] https://crrev.com/99e21d42ca74addc5f52c64064fc5962447b882d/third_party/WebKit/LayoutTests/platform/win7/media/controls-without-preload-expected.txt
[modify] https://crrev.com/99e21d42ca74addc5f52c64064fc5962447b882d/third_party/WebKit/LayoutTests/platform/win7/media/media-controls-clone-expected.png
[modify] https://crrev.com/99e21d42ca74addc5f52c64064fc5962447b882d/third_party/WebKit/LayoutTests/platform/win7/media/media-controls-clone-expected.txt
[modify] https://crrev.com/99e21d42ca74addc5f52c64064fc5962447b882d/third_party/WebKit/LayoutTests/platform/win7/media/video-controls-rendering-expected.png
[modify] https://crrev.com/99e21d42ca74addc5f52c64064fc5962447b882d/third_party/WebKit/LayoutTests/platform/win7/media/video-controls-rendering-expected.txt
[modify] https://crrev.com/99e21d42ca74addc5f52c64064fc5962447b882d/third_party/WebKit/LayoutTests/platform/win7/media/video-display-toggle-expected.png
[modify] https://crrev.com/99e21d42ca74addc5f52c64064fc5962447b882d/third_party/WebKit/LayoutTests/platform/win7/media/video-display-toggle-expected.txt
[modify] https://crrev.com/99e21d42ca74addc5f52c64064fc5962447b882d/third_party/WebKit/LayoutTests/platform/win7/media/video-empty-source-expected.png
[modify] https://crrev.com/99e21d42ca74addc5f52c64064fc5962447b882d/third_party/WebKit/LayoutTests/platform/win7/media/video-empty-source-expected.txt

Comment 5 by mlamouri@chromium.org, May 2 2018

Status: Fixed (was: Started)

►

Issue 821025 link

Issue metadata

Some media layout tests fail on win7

Issue description

Comment 1 by liber...@chromium.org, Mar 12 2018

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Mar 12 2018

Comment 2 Deleted

Comment 3 by mlamouri@chromium.org, Apr 30 2018

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, May 1 2018

Comment 4 Deleted

Comment 5 by mlamouri@chromium.org, May 2 2018

Comment 5 Deleted

Sign in to add a comment