New issue
Advanced search Search tips

Issue 821015 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Mar 2018
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Debug build of chromium for android on mips fails during linking

Reported by djordje....@mips.com, Mar 12 2018

Issue description

UserAgent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0

Steps to reproduce the problem:
1. gn gen out/Debug --args="target_os=\"android\" target_cpu=\"mipsel\" is_debug=true"
2. ninja -j8 -C out/Debug libremoting_client_jni.cr.so

What is the expected behavior?

What went wrong?
Linker complains about undefined reference to __atomic_fetch_add_8.

Did this work before? N/A 

Chrome version: <Copy from: 'about:version'>  Channel: n/a
OS Version: top of the tree
Flash Version: Shockwave Flash 28.0 r0

MIPS targets should be explicitly linked against libatomic when using fetch_add_8 on 32bit cpu.
 
Components: Blink>WebRTC
Labels: Needs-Milestone
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dca3bb156241044d634b5a34ce1516a55e1ab4d3

commit dca3bb156241044d634b5a34ce1516a55e1ab4d3
Author: Djordje Golubovic <djordje.golubovic@mips.com>
Date: Mon Mar 12 18:59:04 2018

Explicitly link against libatomic for 32bit mips target cpu.

Bug:  821015 
Change-Id: I60824857a26ea8660b80aa22dafd33bb3fc42289
Reviewed-on: https://chromium-review.googlesource.com/959120
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542545}
[modify] https://crrev.com/dca3bb156241044d634b5a34ce1516a55e1ab4d3/build/config/android/BUILD.gn

Comment 3 by guidou@chromium.org, Mar 13 2018

Components: -Blink>WebRTC
Status: Fixed (was: Unconfirmed)

Sign in to add a comment