Issue metadata
Sign in to add a comment
|
Write a net::HttpServer using Network Service's tcp_socket.mojom |
||||||||||||||||||||||
Issue descriptionAs a part of network servicification, all interactions with //net will be done through network service's mojo APIs. net::HttpServer (net/server/http_server.h) is currently used by DevTools. Now that network service's TCP socket APIs (https://chromium-review.googlesource.com/c/chromium/src/+/868711) is ready, we need to write an implementation (with net::HttpServer functionalities) that is built using tcp_socket.mojom. This client-side implementation can live services/network/public/cpp/, and DevTools can be converted to using it.
,
Mar 12 2018
Yes, DevTools need it to support remote debugging. This seems to be orthogonal to the rest of NetworkService transition, though, and I'm not sure I see any practical benefit in having the HttpServer outside of the browser process, so perhaps we could postpone or WontFix it ineed?
,
Mar 13 2018
If leaving this in net is a problem, my suggestion would be to move HttpServer from net to components. WDYT? There should be no need to put this behind a service - it's only used for debugging currently.
,
Mar 13 2018
net::HttpServer uses network sockets (tcp_server_socket.h and tcp_client_socket.h). With network service, socket access is privileged and should be done using network service's mojo APIs (tcp_socket.mojom). The idea here is to build a client-side class that uses tcp_socket.mojom. DevTools will be converted to using this client-side class instead of net::HttpServer. This is probably of low priority but I don't think this is orthogonal to network servicificiation. My understanding is that restricting network socket access is a goal for network servicification. +jam to confirm
,
Mar 15 2018
+lilyhoughton@ from our team can take this.
,
Mar 28 2018
Our goal is to move networking requests by the browser to run in a network process. If devtools is instantiating net::HttpServer in the browser only when devtools is used, we don't need to change that. i.e. we'll still be calling various net/ helper classes in the browser. So I think we don't need to do anything here.
,
Mar 28 2018
John, this is very different from my understanding of the overall goal for network servicification. Let's sync offline. +mmenke@
,
Mar 28 2018
Helen and I chatted offline and she explained to me that this httpserver for devtools can be used from other machines (i thought it was just local). Since it's networking requests, then I agree that we want to make it go through the network process.
,
Mar 28 2018
It's actually responding to networking requests, not making them, but I don't think that changes the conclusion. I don't think this work needs to block the launch of a network service on any platform.
,
Mar 28 2018
+1 to what jam@ and mmenke@ say. WRT the server being accessed from other machines -- to the best of my knowledge, we're supposed to bind to localhost and even lately check that the client was connecting to localhost (as a matter of protection from DNS cache poisoning attack). There's no other authentication/authorization involved, aside from the fact that this is all behind a flag. So this is definitely shouldn't be used in prod environment, the feature is intended for automation frameworks -- testing and the like. To support remote access we typically recommend SSH tunneling.
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/389d32303aab5ef13b561430d7461147391ede09 commit 389d32303aab5ef13b561430d7461147391ede09 Author: Lily Houghton <lilyhoughton@chromium.org> Date: Thu Apr 19 23:40:01 2018 Adds a HttpServer class to network service based on net::HttpServer. This CL implements an HttpServer class for the network service, modeled after net::HttpServer, but using mojo tcp sockets. The goal is to convert existing embedders of net::HttpServer to using this wrapper class and eventually remove net::HttpServer. Bug: 821000 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I0b567a932da0b4572d65f99e81c98ce1c79a1bb5 Reviewed-on: https://chromium-review.googlesource.com/973698 Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> Reviewed-by: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#552203} [modify] https://crrev.com/389d32303aab5ef13b561430d7461147391ede09/services/network/public/cpp/BUILD.gn [add] https://crrev.com/389d32303aab5ef13b561430d7461147391ede09/services/network/public/cpp/server/http_connection.cc [add] https://crrev.com/389d32303aab5ef13b561430d7461147391ede09/services/network/public/cpp/server/http_connection.h [add] https://crrev.com/389d32303aab5ef13b561430d7461147391ede09/services/network/public/cpp/server/http_server.cc [add] https://crrev.com/389d32303aab5ef13b561430d7461147391ede09/services/network/public/cpp/server/http_server.h [add] https://crrev.com/389d32303aab5ef13b561430d7461147391ede09/services/network/public/cpp/server/http_server_request_info.cc [add] https://crrev.com/389d32303aab5ef13b561430d7461147391ede09/services/network/public/cpp/server/http_server_request_info.h [add] https://crrev.com/389d32303aab5ef13b561430d7461147391ede09/services/network/public/cpp/server/http_server_response_info.cc [add] https://crrev.com/389d32303aab5ef13b561430d7461147391ede09/services/network/public/cpp/server/http_server_response_info.h [add] https://crrev.com/389d32303aab5ef13b561430d7461147391ede09/services/network/public/cpp/server/http_server_unittest.cc [add] https://crrev.com/389d32303aab5ef13b561430d7461147391ede09/services/network/public/cpp/server/web_socket.cc [add] https://crrev.com/389d32303aab5ef13b561430d7461147391ede09/services/network/public/cpp/server/web_socket.h [add] https://crrev.com/389d32303aab5ef13b561430d7461147391ede09/services/network/public/cpp/server/web_socket_encoder.cc [add] https://crrev.com/389d32303aab5ef13b561430d7461147391ede09/services/network/public/cpp/server/web_socket_encoder.h [modify] https://crrev.com/389d32303aab5ef13b561430d7461147391ede09/services/network/public/mojom/tcp_socket.mojom [modify] https://crrev.com/389d32303aab5ef13b561430d7461147391ede09/services/network/tcp_server_socket.cc [modify] https://crrev.com/389d32303aab5ef13b561430d7461147391ede09/services/network/tcp_server_socket.h [modify] https://crrev.com/389d32303aab5ef13b561430d7461147391ede09/tools/traffic_annotation/summary/annotations.xml
,
May 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/84c0618a0af296d36aea5378140daa5c81e51612 commit 84c0618a0af296d36aea5378140daa5c81e51612 Author: Lily Houghton <lilyhoughton@chromium.org> Date: Tue May 01 20:33:53 2018 Add defintions for network::server::HttpServer::Set*BufferSize functions. Bug: 821000 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I73d89322a3fb7a965000d7eff9e76edf07924c94 Reviewed-on: https://chromium-review.googlesource.com/1033422 Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> Reviewed-by: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#555172} [modify] https://crrev.com/84c0618a0af296d36aea5378140daa5c81e51612/services/network/public/cpp/server/http_connection.h [modify] https://crrev.com/84c0618a0af296d36aea5378140daa5c81e51612/services/network/public/cpp/server/http_server.cc [modify] https://crrev.com/84c0618a0af296d36aea5378140daa5c81e51612/services/network/public/cpp/server/http_server.h [modify] https://crrev.com/84c0618a0af296d36aea5378140daa5c81e51612/services/network/public/cpp/server/http_server_unittest.cc
,
May 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f7b2fb9aba0974a05dd97d55430397953440e46 commit 7f7b2fb9aba0974a05dd97d55430397953440e46 Author: Lily Houghton <lilyhoughton@chromium.org> Date: Tue May 01 21:40:46 2018 Replace the HTTP server in DevTools with the one from the network service, as eventually net::HttpServer will be removed entirely. Bug: 821000 Change-Id: I7ab51997887f6cfbb3aa3d18eeec130b115a685d Reviewed-on: https://chromium-review.googlesource.com/1027808 Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Helen Li <xunjieli@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#555187} [modify] https://crrev.com/7f7b2fb9aba0974a05dd97d55430397953440e46/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc [modify] https://crrev.com/7f7b2fb9aba0974a05dd97d55430397953440e46/components/ui_devtools/BUILD.gn [modify] https://crrev.com/7f7b2fb9aba0974a05dd97d55430397953440e46/components/ui_devtools/DEPS [modify] https://crrev.com/7f7b2fb9aba0974a05dd97d55430397953440e46/components/ui_devtools/devtools_server.cc [modify] https://crrev.com/7f7b2fb9aba0974a05dd97d55430397953440e46/components/ui_devtools/devtools_server.h
,
May 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1fa1cc40003f9203f30d74f1275d1c69228d0f58 commit 1fa1cc40003f9203f30d74f1275d1c69228d0f58 Author: Helen Li <xunjieli@chromium.org> Date: Thu May 03 17:40:32 2018 Clarify StoragePartition::GetNetworkContext() contract and fix devtools_server.cc The raw pointer returned by GetNetworkContext() shouldn't be hold onto. This CL adds documentation to the method and fixes devtools_server.cc to not hold onto the raw pointer as a member. Bug: 821000 Change-Id: If6e1a7c9a6742980755ffabd4c3b0d8fe0fa392e Reviewed-on: https://chromium-review.googlesource.com/1042352 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#555792} [modify] https://crrev.com/1fa1cc40003f9203f30d74f1275d1c69228d0f58/components/ui_devtools/devtools_server.cc [modify] https://crrev.com/1fa1cc40003f9203f30d74f1275d1c69228d0f58/components/ui_devtools/devtools_server.h [modify] https://crrev.com/1fa1cc40003f9203f30d74f1275d1c69228d0f58/content/public/browser/storage_partition.h
,
May 14 2018
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/249f81132fc450887ea6b488bf47935c08f8e5a1 commit 249f81132fc450887ea6b488bf47935c08f8e5a1 Author: Lily Houghton <lilyhoughton@chromium.org> Date: Wed May 16 16:41:28 2018 Add check to HttpServer::OnReadable to make sure that the pipe is still open. Bug: 821000 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ic11a4756101fa597c2779e5b82c93e62738c657d Reviewed-on: https://chromium-review.googlesource.com/1055742 Reviewed-by: Helen Li <xunjieli@chromium.org> Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> Cr-Commit-Position: refs/heads/master@{#559137} [modify] https://crrev.com/249f81132fc450887ea6b488bf47935c08f8e5a1/services/network/public/cpp/server/http_server.cc [modify] https://crrev.com/249f81132fc450887ea6b488bf47935c08f8e5a1/services/network/public/cpp/server/http_server.h [modify] https://crrev.com/249f81132fc450887ea6b488bf47935c08f8e5a1/services/network/public/cpp/server/http_server_unittest.cc
,
May 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/85765d50799709fc3efbebaecfd726a62fda3dbb commit 85765d50799709fc3efbebaecfd726a62fda3dbb Author: Lily Houghton <lilyhoughton@chromium.org> Date: Mon May 21 18:22:28 2018 Convert Chromedriver tests to use the HttpServer class from the network service. This refactors the chromedriver unit tests, particularly those in net_util_unittest, sync_websocket_unittest, and websocket_unittest, as well as the TestHttpServer class, to use the network service's HttpServer class (instead of the one in net/). Bug: 821000 Change-Id: Icc4479b656936f38e86d104004d1dd703d845dda Reviewed-on: https://chromium-review.googlesource.com/1038544 Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> Reviewed-by: John Chen <johnchen@chromium.org> Reviewed-by: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#560310} [modify] https://crrev.com/85765d50799709fc3efbebaecfd726a62fda3dbb/chrome/test/chromedriver/BUILD.gn [modify] https://crrev.com/85765d50799709fc3efbebaecfd726a62fda3dbb/chrome/test/chromedriver/chrome/devtools_http_client.cc [modify] https://crrev.com/85765d50799709fc3efbebaecfd726a62fda3dbb/chrome/test/chromedriver/net/net_util.cc [modify] https://crrev.com/85765d50799709fc3efbebaecfd726a62fda3dbb/chrome/test/chromedriver/net/net_util.h [modify] https://crrev.com/85765d50799709fc3efbebaecfd726a62fda3dbb/chrome/test/chromedriver/net/net_util_unittest.cc [modify] https://crrev.com/85765d50799709fc3efbebaecfd726a62fda3dbb/chrome/test/chromedriver/net/sync_websocket_impl_unittest.cc [modify] https://crrev.com/85765d50799709fc3efbebaecfd726a62fda3dbb/chrome/test/chromedriver/net/test_http_server.cc [modify] https://crrev.com/85765d50799709fc3efbebaecfd726a62fda3dbb/chrome/test/chromedriver/net/test_http_server.h [modify] https://crrev.com/85765d50799709fc3efbebaecfd726a62fda3dbb/chrome/test/chromedriver/net/websocket_unittest.cc [add] https://crrev.com/85765d50799709fc3efbebaecfd726a62fda3dbb/chrome/test/chromedriver/run_all_unittests.cc
,
May 22 2018
this will not block canary.
,
May 22 2018
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b74c059906bf0c705076b0cdf7e0e4e6a4c8a927 commit b74c059906bf0c705076b0cdf7e0e4e6a4c8a927 Author: Lily Houghton <lilyhoughton@chromium.org> Date: Wed May 23 15:39:03 2018 Revert "Convert Chromedriver tests to use the HttpServer class from the network service." This reverts commit 85765d50799709fc3efbebaecfd726a62fda3dbb. Reason for revert: Crashes on Mac builder in ChromeDriver waterfall (b/2433) Original change's description: > Convert Chromedriver tests to use the HttpServer class from the network service. > > This refactors the chromedriver unit tests, particularly those in net_util_unittest, > sync_websocket_unittest, and websocket_unittest, as well as the TestHttpServer class, > to use the network service's HttpServer class (instead of the one in net/). > > Bug: 821000 > Change-Id: Icc4479b656936f38e86d104004d1dd703d845dda > Reviewed-on: https://chromium-review.googlesource.com/1038544 > Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Reviewed-by: Helen Li <xunjieli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#560310} TBR=xunjieli@chromium.org,lilyhoughton@chromium.org,johnchen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 821000 Change-Id: I17c679ac550c17bc75d0e48a2ddfa37f45066ce0 Reviewed-on: https://chromium-review.googlesource.com/1070348 Reviewed-by: Helen Li <xunjieli@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#561103} [modify] https://crrev.com/b74c059906bf0c705076b0cdf7e0e4e6a4c8a927/chrome/test/chromedriver/BUILD.gn [modify] https://crrev.com/b74c059906bf0c705076b0cdf7e0e4e6a4c8a927/chrome/test/chromedriver/chrome/devtools_http_client.cc [modify] https://crrev.com/b74c059906bf0c705076b0cdf7e0e4e6a4c8a927/chrome/test/chromedriver/net/net_util.cc [modify] https://crrev.com/b74c059906bf0c705076b0cdf7e0e4e6a4c8a927/chrome/test/chromedriver/net/net_util.h [modify] https://crrev.com/b74c059906bf0c705076b0cdf7e0e4e6a4c8a927/chrome/test/chromedriver/net/net_util_unittest.cc [modify] https://crrev.com/b74c059906bf0c705076b0cdf7e0e4e6a4c8a927/chrome/test/chromedriver/net/sync_websocket_impl_unittest.cc [modify] https://crrev.com/b74c059906bf0c705076b0cdf7e0e4e6a4c8a927/chrome/test/chromedriver/net/test_http_server.cc [modify] https://crrev.com/b74c059906bf0c705076b0cdf7e0e4e6a4c8a927/chrome/test/chromedriver/net/test_http_server.h [modify] https://crrev.com/b74c059906bf0c705076b0cdf7e0e4e6a4c8a927/chrome/test/chromedriver/net/websocket_unittest.cc [delete] https://crrev.com/349158ec7d7da1de29628c682e1b26a476e6381d/chrome/test/chromedriver/run_all_unittests.cc
,
May 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a0e2d7ef3d59c482e7c50177dae6ccbce240772f commit a0e2d7ef3d59c482e7c50177dae6ccbce240772f Author: Lily Houghton <lilyhoughton@chromium.org> Date: Fri May 25 14:15:10 2018 Reland "Convert Chromedriver tests to use the HttpServer class from the network service." This is a reland of 85765d50799709fc3efbebaecfd726a62fda3dbb Original change's description: > Convert Chromedriver tests to use the HttpServer class from the network service. > > This refactors the chromedriver unit tests, particularly those in net_util_unittest, > sync_websocket_unittest, and websocket_unittest, as well as the TestHttpServer class, > to use the network service's HttpServer class (instead of the one in net/). > > Bug: 821000 > Change-Id: Icc4479b656936f38e86d104004d1dd703d845dda > Reviewed-on: https://chromium-review.googlesource.com/1038544 > Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Reviewed-by: Helen Li <xunjieli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#560310} Bug: 821000, 2433 Change-Id: I6ec7ac84b988f90a93c86c6eeecfb2d7ee53bad5 Reviewed-on: https://chromium-review.googlesource.com/1070349 Reviewed-by: Helen Li <xunjieli@chromium.org> Reviewed-by: John Chen <johnchen@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#561858} [modify] https://crrev.com/a0e2d7ef3d59c482e7c50177dae6ccbce240772f/chrome/test/chromedriver/BUILD.gn [modify] https://crrev.com/a0e2d7ef3d59c482e7c50177dae6ccbce240772f/chrome/test/chromedriver/net/net_util_unittest.cc [modify] https://crrev.com/a0e2d7ef3d59c482e7c50177dae6ccbce240772f/chrome/test/chromedriver/net/sync_websocket_impl_unittest.cc [modify] https://crrev.com/a0e2d7ef3d59c482e7c50177dae6ccbce240772f/chrome/test/chromedriver/net/test_http_server.cc [modify] https://crrev.com/a0e2d7ef3d59c482e7c50177dae6ccbce240772f/chrome/test/chromedriver/net/test_http_server.h [modify] https://crrev.com/a0e2d7ef3d59c482e7c50177dae6ccbce240772f/chrome/test/chromedriver/net/websocket_unittest.cc [add] https://crrev.com/a0e2d7ef3d59c482e7c50177dae6ccbce240772f/chrome/test/chromedriver/run_all_unittests.cc
,
May 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2283ce89d460bbeec29c24e080246bf2bb1ec348 commit 2283ce89d460bbeec29c24e080246bf2bb1ec348 Author: Lily Houghton <lilyhoughton@chromium.org> Date: Tue May 29 17:32:15 2018 Revert "Reland "Convert Chromedriver tests to use the HttpServer class from the network service."" This reverts commit a0e2d7ef3d59c482e7c50177dae6ccbce240772f. Reason for revert: <INSERT REASONING HERE> Original change's description: > Reland "Convert Chromedriver tests to use the HttpServer class from the network service." > > This is a reland of 85765d50799709fc3efbebaecfd726a62fda3dbb > > Original change's description: > > Convert Chromedriver tests to use the HttpServer class from the network service. > > > > This refactors the chromedriver unit tests, particularly those in net_util_unittest, > > sync_websocket_unittest, and websocket_unittest, as well as the TestHttpServer class, > > to use the network service's HttpServer class (instead of the one in net/). > > > > Bug: 821000 > > Change-Id: Icc4479b656936f38e86d104004d1dd703d845dda > > Reviewed-on: https://chromium-review.googlesource.com/1038544 > > Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> > > Reviewed-by: John Chen <johnchen@chromium.org> > > Reviewed-by: Helen Li <xunjieli@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#560310} > > Bug: 821000, 2433 > Change-Id: I6ec7ac84b988f90a93c86c6eeecfb2d7ee53bad5 > Reviewed-on: https://chromium-review.googlesource.com/1070349 > Reviewed-by: Helen Li <xunjieli@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: Helen Li <xunjieli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561858} TBR=xunjieli@chromium.org,lilyhoughton@chromium.org,johnchen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 821000, chromedriver:2433 Change-Id: I5fd1ac7d8665ac658651e35b04d984039aaae154 Reviewed-on: https://chromium-review.googlesource.com/1076447 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by: Helen Li <xunjieli@chromium.org> Reviewed-by: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#562489} [modify] https://crrev.com/2283ce89d460bbeec29c24e080246bf2bb1ec348/chrome/test/chromedriver/BUILD.gn [modify] https://crrev.com/2283ce89d460bbeec29c24e080246bf2bb1ec348/chrome/test/chromedriver/net/net_util_unittest.cc [modify] https://crrev.com/2283ce89d460bbeec29c24e080246bf2bb1ec348/chrome/test/chromedriver/net/sync_websocket_impl_unittest.cc [modify] https://crrev.com/2283ce89d460bbeec29c24e080246bf2bb1ec348/chrome/test/chromedriver/net/test_http_server.cc [modify] https://crrev.com/2283ce89d460bbeec29c24e080246bf2bb1ec348/chrome/test/chromedriver/net/test_http_server.h [modify] https://crrev.com/2283ce89d460bbeec29c24e080246bf2bb1ec348/chrome/test/chromedriver/net/websocket_unittest.cc [delete] https://crrev.com/1ed840452bc75430c5f6c14b6b481b19b2b1bd15/chrome/test/chromedriver/run_all_unittests.cc
,
May 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4367c62a3f7f64bd4d324256892aa1c9d4b652e6 commit 4367c62a3f7f64bd4d324256892aa1c9d4b652e6 Author: Lily Houghton <lilyhoughton@chromium.org> Date: Tue May 29 17:48:37 2018 Export http server classes properly Bug: 821000 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ieeeb830a0fda886f6e99ecd1182d8a409c3e6bcf Reviewed-on: https://chromium-review.googlesource.com/1076499 Reviewed-by: Helen Li <xunjieli@chromium.org> Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> Cr-Commit-Position: refs/heads/master@{#562497} [modify] https://crrev.com/4367c62a3f7f64bd4d324256892aa1c9d4b652e6/services/network/public/cpp/server/http_server.h [modify] https://crrev.com/4367c62a3f7f64bd4d324256892aa1c9d4b652e6/services/network/public/cpp/server/http_server_response_info.h
,
Aug 2
Matt, could you triage this?
,
Aug 2
I think this one is fine just leaving in our queue - it doesn't need to block rolling out the network service to Canary (Or even to stable), since this isn't attached to the URLRequestContext in any way, so can be migrated independently. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by xunji...@chromium.org
, Mar 12 2018