Return boolean from DOMTokenList's replace() method
Reported by
c...@zirro.se,
Mar 12 2018
|
|||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:60.0) Gecko/20100101 Firefox/60.0 Steps to reproduce the problem: A proposed change to the specification for DOMTokenList's replace() method which would make it return a boolean - indicating true if a token was replaced and false otherwise - has received positive responses from implementers. Pull request and discussion: https://github.com/whatwg/dom/pull/582 Tests: https://github.com/w3c/web-platform-tests/pull/9920 What is the expected behavior? What went wrong? - Did this work before? N/A Does this work in other browsers? N/A Chrome version: Channel: n/a OS Version: OS X 10.13 Flash Version:
,
Mar 15 2018
,
Mar 15 2018
,
Mar 19 2018
The patch has been uploaded, and is under review. That is https://chromium-review.googlesource.com/c/chromium/src/+/965683
,
Mar 22 2018
chromestatus.com entry for this feature: https://www.chromestatus.com/feature/5690841569951744
,
Mar 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2de5a77d724dc3185e39ae7d4adfc2d976ded95c commit 2de5a77d724dc3185e39ae7d4adfc2d976ded95c Author: Yuhong Sha <yuhong.sha@samsung.com> Date: Thu Mar 22 09:04:41 2018 Return boolean for the replace method in DOMTokenList The specification for DOMTokenList's replace() method which would make it return a boolean. Indicating true if a token was replaced, and false otherwise. Bug: 820988 Signed-off-by: Yuhong Sha <yuhong.sha@samsung.com> Change-Id: I8e500a74a2504e13522c4e85b17d441cd2d4299f Reviewed-on: https://chromium-review.googlesource.com/965683 Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#545018} [delete] https://crrev.com/ba7b02ff0cbe99e37c7a587858412c62a64fb549/third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Element-classlist-expected.txt [modify] https://crrev.com/2de5a77d724dc3185e39ae7d4adfc2d976ded95c/third_party/WebKit/Source/core/dom/DOMTokenList.cpp [modify] https://crrev.com/2de5a77d724dc3185e39ae7d4adfc2d976ded95c/third_party/WebKit/Source/core/dom/DOMTokenList.h [modify] https://crrev.com/2de5a77d724dc3185e39ae7d4adfc2d976ded95c/third_party/WebKit/Source/core/dom/DOMTokenList.idl
,
Mar 22 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by krajshree@chromium.org
, Mar 12 2018