Issue metadata
Sign in to add a comment
|
ContentSettingsTest.BasicCookies flaky on network_service_browser_tests |
||||||||||||||||||||||
Issue descriptionContentSettingsTest.BasicCookies is very flaky on network_service_browser_tests The test loads setcookie.html, which creates a cookie in the onload handler and then checks if there is any cookie in c++. This check frequently fails on network_service_browser_tests. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=network_service_browser_tests&tests=ContentSettingsTest.*BasicCookies Example: http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/68258 [ RUN ] ContentSettingsTest.BasicCookies Xlib: extension "RANDR" missing on display ":99". Fontconfig warning: "/etc/fonts/fonts.conf", line 146: blank doesn't take any effect anymore. please remove it from your fonts.conf [18628:18665:0312/040907.258025:ERROR:bus.cc(394)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix") [18628:18628:0312/040907.263699:WARNING:password_store_factory.cc(240)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options. (browser_tests:18628): LIBDBUSMENU-GLIB-WARNING **: Unable to get session bus: Unknown or unsupported transport 'disabled' for address 'disabled:' ../../chrome/browser/content_settings/content_settings_browsertest.cc:135: Failure Value of: GetCookies(browser()->profile(), url).empty() Actual: true Expected: false
,
Mar 12 2018
,
Mar 12 2018
[+cmumford]: Looks like it was enabled in https://chromium-review.googlesource.com/931925
,
Mar 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/755598f7b44ab671f4135a45ebb058fa9cdf0e9c commit 755598f7b44ab671f4135a45ebb058fa9cdf0e9c Author: Christian Dullweber <dullweber@chromium.org> Date: Mon Mar 12 14:39:20 2018 Disable ContentSettingsTest.BasicCookies in network_service_browser_tests Disable ContentSettingsTest.BasicCookies and BasicCookiesHttps because they are flaky in network_service_browser_tests. TBR=jam@chromium.org Bug: 820969 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I99e73d50942b04f680750abf0ad40e5dd21b6913 Reviewed-on: https://chromium-review.googlesource.com/958909 Reviewed-by: Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#542477} [modify] https://crrev.com/755598f7b44ab671f4135a45ebb058fa9cdf0e9c/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
,
May 22 2018
jam@, can you check if this is fixed.
,
May 22 2018
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9edd464609b0353046c0f11a3594329e7ba958a7 commit 9edd464609b0353046c0f11a3594329e7ba958a7 Author: John Abd-El-Malek <jam@chromium.org> Date: Wed May 23 04:24:28 2018 Fix waiting for network process at browser shutdown. The previous fix in r560368 didn't work, as the BrowserChildProcessHostImpl::TerminateAll removed all the UtilityProcessHost objects first. Bug: 820996 , 820969 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I88ba647e911c8f7e8d9458b60021aa6d915ccfa0 Reviewed-on: https://chromium-review.googlesource.com/1069668 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#560938} [modify] https://crrev.com/9edd464609b0353046c0f11a3594329e7ba958a7/base/threading/thread_restrictions.h [modify] https://crrev.com/9edd464609b0353046c0f11a3594329e7ba958a7/content/browser/browser_process_sub_thread.cc [modify] https://crrev.com/9edd464609b0353046c0f11a3594329e7ba958a7/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
,
May 24 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dullweber@chromium.org
, Mar 12 2018Components: Internals>Services>Network