New issue
Advanced search Search tips

Issue 820963 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

viz_browser_tests very flaky on Win10 Tests x64

Project Member Reported by dullweber@chromium.org, Mar 12 2018

Issue description

viz_browser tests is failing very frequently on https://ci.chromium.org/buildbot/chromium.win/Win10%20Tests%20x64/

All flakes seem to hit a NOTIMPLEMENTED() in DelegatedFrameHost::SetNeedsBeginFrames.

Please take a look and try to fix the issue quickly as the builder is almost never green.

Example:
https://ci.chromium.org/buildbot/chromium.win/Win10%20Tests%20x64/21647
[ RUN      ] PrefHashBrowserTestUntrustedAdditionToPrefsInstance/PrefHashBrowserTestUntrustedAdditionToPrefs.UntrustedAdditionToPrefs/0
[3740:6000:0312/044602.385:WARNING:discovery_network_list_win.cc(195)] Failed to open Wlan client handle: 1062
[3740:1628:0312/044602.401:WARNING:chrome_browser_main_win.cc(630)] Command line too long for RegisterApplicationRestart:  --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=PrefHashBrowserTestUntrustedAdditionToPrefsInstance/PrefHashBrowserTestUntrustedAdditionToPrefs.UntrustedAdditionToPrefs/0 --single_process --test-launcher-bot-mode --test-launcher-filter-file=../../testing/buildbot/filters/viz.browser_tests.filter --test-launcher-output="C:\Users\CHROME~1\AppData\Local\Temp\scoped_dir2804_2256\results2804_28983\test_results.xml" --test-launcher-summary-output="C:\b\s\w\io2xd4lo\output.json" --user-data-dir="C:\Users\CHROME~1\AppData\Local\Temp\scoped_dir2804_2256\d2804_401" --disable-offline-auto-reload --force-fieldtrials=SettingsEnforcement/no_enforcement/ --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-compositor-ukm-for-tests --enable-features=TestFeatureForBrowserTest1,VizDisplayCompositor --disable-features=NetworkPrediction,TestFeatureForBrowserTest2 --flag-switches-begin --flag-switches-end --restore-last-session about:blank
[3740:1628:0312/044602.416:ERROR:delegated_frame_host.cc(207)] NOT IMPLEMENTED
 
Cc: jonr...@chromium.org
Status: Started (was: Assigned)
The NOTIMPLEMENTED is unrelated. I'm not sure why the tests are failing but I'm disabling the failing tests in viz.browser_tests.filter now.
Cc: -jonr...@chromium.org kylec...@chromium.org
Owner: jonr...@chromium.org
Actually we are getting flake in many many tests. We are going to remove viz_browser_tests from Windows trybots and investigate.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d72287fc22596600f5a80ac6815384744221a88e

commit d72287fc22596600f5a80ac6815384744221a88e
Author: jonross <jonross@chromium.org>
Date: Mon Mar 12 13:49:20 2018

Disable viz_browser_tests on Windows

Something introduced a lot of flakiness to viz_browser_tests on Windows. So I'm
disabling them until we can isolate the cause.

TBR=dprank@chromium.org
TEST=viz_browser_tests

Bug:  820963 
Change-Id: I8fc4929ffa7499115928101badbc96f2a7c4dd72
Reviewed-on: https://chromium-review.googlesource.com/957757
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542471}
[modify] https://crrev.com/d72287fc22596600f5a80ac6815384744221a88e/testing/buildbot/chromium.win.json
[modify] https://crrev.com/d72287fc22596600f5a80ac6815384744221a88e/testing/buildbot/test_suite_exceptions.pyl

Status: Fixed (was: Started)
I've disabled the tests on windows to free up the CQ. I'll investigate the flakes separate and log bugs

Sign in to add a comment