New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 820962 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: "Saved password details" overlay doesn’t shift towards left side when focus reaches to Username/Password fields.

Reported by dchau...@etouch.net, Mar 12 2018

Issue description

Chrome Version: 66.0.3359.26 (Official Build) Revision	b3471a2c378d1cfc5be97bb38b9c32038d1aef14-refs/branch-heads/3359@{#146} 32/64-bit.
OS: Windows(7,8,8.1,10), Mac(10.12.6,10.13.1,10.13.4) and Linux(14.04).

What steps will reproduce the problem?
1. Launch Chrome, login to www.gmail.com with valid credentials and save the password.
2. Navigate to chrome://settings/passwords and click on 'Details’ option from more actions menu list.
3. Completely resize the browser towards LHS, multiple times press ‘Tab’ key from keyboard and observe the overlay	

Actual: 'Saved password details’ overlay doesn’t shift towards left side when focus reaches to Username/Password fields.
Expected: 'Saved password details’ overlay should shift towards left side when focus reaches to Username/Password fields.

This is a regression issue, broken in M-65, below is manual regression range.

Good build: 65.0.3318.0 (Revision: 528542)
Bad build: 65.0.3319.0 (Revision: 528844)

Using the per-revision bisect providing the bisect results:

You are probably looking for a change made after 528748 (known good), but no later than 528749 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/0a7ce7463ceae66f14cbacabd236fea7f56b5bf1..e17fd7199e57c383c2a1fdbf4b26826fb0de546b

Suspecting: https://chromium.googlesource.com/chromium/src/+/e17fd7199e57c383c2a1fdbf4b26826fb0de546b

@scottchen: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

NOTE: This issue is also reproducible on M-65 Stable (build # 65.0.3325.146), M-65 Beta (build # 65.0.3325.125) and M-67 Canary (build # 67.0.3368.0).

Kindly review the attached screen-cast for reference.

Thank you.
 
Actual behavior.mov
4.2 MB View Download
Expected behavior.mov
4.7 MB View Download
Cc: scottchen@chromium.org aee@chromium.org hcarmona@chromium.org
Labels: -Pri-1 Pri-2
Owner: ----
Status: Available (was: Assigned)
This is most likely due to a change we made recently on how the read-only text-field content is highlighted

Comment 2 by aee@chromium.org, Apr 3 2018

Cc: -aee@chromium.org
Owner: aee@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60cf55b8c782eb05d71b2b0887881594d5d0482e

commit 60cf55b8c782eb05d71b2b0887881594d5d0482e
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Wed Apr 04 21:23:04 2018

Settings WebUI: ensure input in view when focused

Bug:  820962 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6fba6413a7ad3668e792efd988304747a0e13701
Reviewed-on: https://chromium-review.googlesource.com/994234
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548203}
[modify] https://crrev.com/60cf55b8c782eb05d71b2b0887881594d5d0482e/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.js

Comment 4 by aee@chromium.org, Apr 4 2018

Status: Fixed (was: Started)
Labels: TE-Verified-M67 TE-Verified-67.0.3389.0
Update:-
 Re-tested this issue on Windows (7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.4) and Linux(14.04 LTS) machines using latest Chrome Canary build# 67.0.3389.0 and fix is working as expected.. Hence adding TE-Verified labels. 

Please find the attached screen-cast for reference.

Thanks..!
LatestCanary_behavior.mov
5.0 MB View Download

Sign in to add a comment