New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 820959 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 804868
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

NavigationMojoResponse: BrowserSideNavigationBaseBrowserTest.CancelRequestAfterReadyToCommit fails on Windows.

Project Member Reported by arthurso...@chromium.org, Mar 12 2018

Issue description

With NavigationMojoResponse, the test BrowserSideNavigationBaseBrowserTest.CancelRequestAfterReadyToCommit fails on Windows only.

It was previously failing on all platform. In   https://crbug.com/804868  , a fix was made. It now works on every platform except on Windows.
 
Description: Show this description
Description: Show this description
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be5626358d2a76d7376bb5c36ed9db06824eb23d

commit be5626358d2a76d7376bb5c36ed9db06824eb23d
Author: arthursonzogni <arthursonzogni@chromium.org>
Date: Wed Mar 14 11:36:17 2018

NavigationMojoResponse: Temporarily disable test on Windows.

See  https://crbug.com/820959  for more informations.
This CL temporarily disable
BrowserSideNavigationBaseBrowserTest.CancelRequestAfterReadyToCommit on
Windows with NavigationMojoResponse.

Bug:  820959 
Change-Id: I2b7f774baf161275834ae969532fa5abef292043
Reviewed-on: https://chromium-review.googlesource.com/958904
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543053}
[modify] https://crrev.com/be5626358d2a76d7376bb5c36ed9db06824eb23d/content/browser/browser_side_navigation_browsertest.cc

I have no Windows OS, so that's a bit difficult for me to debug.
I used https://chromium.googlesource.com/chromium/src/+/master/docs/win_cross.md
to build a Windows binary on Linux and execute it on bots. It works fine. I am very happy to know it it possible.

I confirmed the issue is the same as in  https://crbug.com/804868 . There are no additional issues caused by NavigationMojoResponse. The IOBuffer is not released on Windows.

jkarlin@: Do you have any idea why  https://crbug.com/804868  would not be fixed by your fix on Windows? I don't see any Windows specific code around the files you modified in https://chromium-review.googlesource.com/c/chromium/src/+/928845
Mergedinto: 804868
Status: Duplicate (was: Assigned)
Merging the issue into the original bug. I tried to start a separate discussion for the Windows case, but the discussion continued on the original one. It is better to close this one.
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 9 2018

Labels: merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e50607ae9ee5a1638244894af54f8d0a349dc532

commit e50607ae9ee5a1638244894af54f8d0a349dc532
Author: arthursonzogni <arthursonzogni@chromium.org>
Date: Mon Apr 09 15:28:21 2018

NavigationMojoResponse: Temporarily disable test on Windows. [M66 merge]

See  https://crbug.com/820959  for more informations.
This CL temporarily disable
BrowserSideNavigationBaseBrowserTest.CancelRequestAfterReadyToCommit on
Windows with NavigationMojoResponse.

Bug:  820959 
Change-Id: I2b7f774baf161275834ae969532fa5abef292043
Reviewed-on: https://chromium-review.googlesource.com/958904
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#543053}(cherry picked from commit be5626358d2a76d7376bb5c36ed9db06824eb23d)
Reviewed-on: https://chromium-review.googlesource.com/997372
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#618}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/e50607ae9ee5a1638244894af54f8d0a349dc532/content/browser/browser_side_navigation_browsertest.cc

Labels: -merge-merged-3359
Merge was requested in issue 828939

Sign in to add a comment