New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 820930 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac , Fuchsia
Pri: 2
Type: Bug



Sign in to add a comment

Merge probe trigger to M66.

Project Member Reported by philipel@chromium.org, Mar 12 2018

Issue description

With M66 a new API will be available to configure video tracks. This new API has been wired up to trigger probing to match the behavior of the current API.

Implemented over three Cls:
part1: https://webrtc-review.googlesource.com/c/src/+/58801
part2: https://webrtc-review.googlesource.com/c/src/+/58940
part3: https://webrtc-review.googlesource.com/c/src/+/59323




 
Project Member

Comment 1 by sheriffbot@chromium.org, Mar 13 2018

Labels: -Merge-Request-66 Merge-Approved-66 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by cmasso@google.com, Mar 13 2018

Please merge this change as soon as possible
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 16 2018

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 20 2018

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
philipel@, have these been merged to M66 yet?  If not, please do so asap.

Comment 6 by cmasso@google.com, Mar 29 2018

Please merge this today!
Sorry for letting this merge request lay open for so long.

I wanted to land an end-to-end test as well and kind of sneak merge the test with the functional changes. I had hoped it would just take one day to land the test, but one day turned into two weeks :(

Is it still OK if I use this merge request to merge my changes?

Comment 8 by cmasso@google.com, Apr 10 2018

Please merge today if this should be in the stable build

Comment 9 by cma...@chromium.org, Apr 11 2018

This merge will miss M66 train.
Sorry, I didn't want to merge with only a week until stable release. Should I just close the bug or should I add some label first?
Stable is next Tuesday and Android already has the release candidate
Labels: -Merge-Approved-66 Merge-Rejected-66
Status: WontFix (was: Assigned)

Sign in to add a comment