Regression:Header appears to be misplaced after scrolling page up/down.
Reported by
vku...@etouch.net,
Mar 12 2018
|
||||||||
Issue descriptionChrome Version: 66.0.3359.26 (Official Build)Revision b3471a2c378d1cfc5be97bb38b9c32038d1aef14-refs/branch-heads/3359@{#146}(32/64 bit) OS:Windows(7,8,8.1,10), Mac(10.13.1, 10.12.6, 10.13.4) & Linux (14.04 LTS)OS What steps will reproduce the problem? (1)Freshly launch chrome and navigate to http://www.latimes.com/ (2)Press 'end' button to scroll at bottom of page. (3)Now scroll up and observe the header of page. Actual: Header appears to be misplaced after scrolling page up/down. Expected: Header should appear properly even after scrolling page up/down This is a regression issue broken in 'M66' and below is the manual bisect info Good Build: 66.0.3344.0(Revision:535593) Bad Build: 66.0.3345.0(Revision:536026) Narrow bisect info: https://chromium.googlesource.com/chromium/src/+log/43e31b80075135d513ff10a19e8293aca21a0ed0..004f3b4b4000be325307d1c409a03411aa00beaa?pretty=fuller&n=50 (Unable to narrow down the range using per-revision bisect as chrome build crashes after launch) Suspecting: r535643 ? @pwnall: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Note: Issue is seen on latest canary 67.0.3368.0(Official build) as well.
,
Mar 12 2018
,
Mar 12 2018
,
Mar 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ae2a0ff5e84c0d29c84f02f02a1fe3d5cdd4b22 commit 1ae2a0ff5e84c0d29c84f02f02a1fe3d5cdd4b22 Author: Steve Kobes <skobes@chromium.org> Date: Thu Mar 15 00:00:33 2018 RLS: Add sticky elements to LFV::viewport_constrained_objects_. The code to do this was behind an "if (!RLS)" block, which was added by http://crrev.com/437671, but we need it with RLS also. Otherwise, non- composited sticky elements don't force main-thread scrolling, and jitter as the compositor tries to scroll them. This fix causes a test to reveal an existing bug in LayoutGeometryMap (see crbug.com/821216 ). Bug: 820921 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I0227b994fcabb84b3edbaa4c73943667a88b1ea5 Reviewed-on: https://chromium-review.googlesource.com/959567 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#543244} [modify] https://crrev.com/1ae2a0ff5e84c0d29c84f02f02a1fe3d5cdd4b22/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/1ae2a0ff5e84c0d29c84f02f02a1fe3d5cdd4b22/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinatorTest.cpp [modify] https://crrev.com/1ae2a0ff5e84c0d29c84f02f02a1fe3d5cdd4b22/third_party/WebKit/Source/core/paint/compositing/CompositingInputsUpdater.cpp
,
Mar 15 2018
,
Mar 15 2018
Verified in canary (67.0.3371.0).
,
Mar 16 2018
This bug requires manual review: M66 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 19 2018
Approved for M66 - branch:3359
,
Mar 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2af0bd3f8645dc0df95bf9fbad59ef2b4888a6d commit d2af0bd3f8645dc0df95bf9fbad59ef2b4888a6d Author: Steve Kobes <skobes@chromium.org> Date: Mon Mar 19 18:58:48 2018 RLS: Add sticky elements to LFV::viewport_constrained_objects_. The code to do this was behind an "if (!RLS)" block, which was added by http://crrev.com/437671, but we need it with RLS also. Otherwise, non- composited sticky elements don't force main-thread scrolling, and jitter as the compositor tries to scroll them. This fix causes a test to reveal an existing bug in LayoutGeometryMap (see crbug.com/821216 ). TBR=skobes@chromium.org (cherry picked from commit 1ae2a0ff5e84c0d29c84f02f02a1fe3d5cdd4b22) Bug: 820921 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I0227b994fcabb84b3edbaa4c73943667a88b1ea5 Reviewed-on: https://chromium-review.googlesource.com/959567 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#543244} Reviewed-on: https://chromium-review.googlesource.com/969332 Reviewed-by: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#318} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/d2af0bd3f8645dc0df95bf9fbad59ef2b4888a6d/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/d2af0bd3f8645dc0df95bf9fbad59ef2b4888a6d/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinatorTest.cpp [modify] https://crrev.com/d2af0bd3f8645dc0df95bf9fbad59ef2b4888a6d/third_party/WebKit/Source/core/paint/compositing/CompositingInputsUpdater.cpp
,
Mar 19 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by pwnall@chromium.org
, Mar 12 2018Owner: skobes@chromium.org