machenbach@, can you PTAL and get in touch with the Chrome Perf team to have them help address this?

If you can't do this in 1-2 days, can you let me know who we should talk to so that I can start to reach out?

Setting to Pri-1 since this is a user-visible error on every commit page.

Hey Ethan, Did anything changed on Chrome Perf Dashboard APIs wrt to authenticating its users. Looks like Chromium Dash is getting authentication error
Request:
https://chromeperf.appspot.com/api/alerts/rev/542158

Repose
{"error": "User authentication error"}

Please feel free to re-assign back to me if this is not related to Chrome Perf.

No, I don't think anything changed recently. What service account is Chromium Dash using? Can you confirm that it is present in the whitelist: https://github.com/catapult-project/catapult/blob/master/dashboard/dashboard/api/api_auth.py#L13

Yes, the Chromium Dash service account is avaialble in api_auth
"975044924533-p122oecs8h6eibv5j5a8fmj82b0ct0nk.apps.googleusercontent.com"
This was working last week, and there is no changes made to Chromium Dash in this area.
Could this be related to https://chromium-review.googlesource.com/c/catapult/+/956673/4/dashboard/dashboard/pinpoint/handlers/new.py#b20

That change should have just added a helper to api_auth not changed anything major.

Correct! I do see nothing major in this CL that could potentially impact authentication of Chromium Dash.
I'm clueless why this started appearing suddenly.

The perf dashboard log shows:

OAuth client id 975044924533-p122oecs8h6eibv5j5a8fmj82b0ct0nk.apps.googleusercontent.com for user hablich@chromium.org not in whitelist (/base/data/home/apps/s~chromeperf/clean-eakuefner-6fbfa7cb.408142309482323201/dashboard/api/api_auth.py:60)

But the client ID is clearly there:
https://chromium.googlesource.com/catapult.git/+/6fbfa7cb/dashboard/dashboard/api/api_auth.py#21

I'll deploy a dev instance with additional logging to see if we can get some more info here.

I see that it's missing from OAUTH_CLIENT_ID_WHITELIST in the currently deployed version.

If I deploy a new version it is present. Maybe someone went in manually and accidentally modified it?

There is a comma missing in the OAUTH_CLIENT_ID_WHITELIST here 
https://github.com/catapult-project/catapult/blob/master/dashboard/dashboard/api/api_auth.py
Not sure if this is causing any issue

Nice catch Prasad, fix is going through cq but I've deployed a dev instance with the fix.

Thank you Simon and Dave for the quick fix and deployment.
With the new deployed version of chromeperf which includes fix, we no longer see the authentication issue!

+kjharland, who added the Fuschia client id 4 days ago

The missing comma would just cause Python to concatenate the two strings. Since '113172445342431053212' is in the list twice (also a bug?) the only client id that's affected is the new fuchsia one.

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/4b356c746683e8e121179d050d15e3d09799be6f

commit 4b356c746683e8e121179d050d15e3d09799be6f
Author: Simon <simonhatch@chromium.org>
Date: Mon Mar 12 21:50:06 2018

Dashboard - Missing comma in api whitelist.

TBR=eakuefner@chromium.org

Bug:  chromium:820908 
Change-Id: I7cffb07f257305c60a19e959d6e31569e1a23fac
Reviewed-on: https://chromium-review.googlesource.com/959548
Commit-Queue: Simon Hatch <simonhatch@chromium.org>
Reviewed-by: Ethan Kuefner <eakuefner@chromium.org>
Reviewed-by: Simon Hatch <simonhatch@chromium.org>

[modify] https://crrev.com/4b356c746683e8e121179d050d15e3d09799be6f/dashboard/dashboard/api/api_auth.py

Ah! Apologies for the mistake. Thanks for fixing so quickly

Looks like this got resolved before I had a chance to look at it. Thanks a lot!

Thanks folks, works now.