New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 820892 link

Starred by 1 user
Status: Fixed
Owner:
█ dschuyler@chromium.org
Last visit > 30 days ago
Closed: Mar 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Hover effect is not seen properly on suggestion drop down list in omnibox

Reported by rp...@etouch.net, Mar 12 2018 
Version: 67.0.3368.0 Revision 0f36d3901569535a63173a1835f8dfbcf7b66d60-refs/heads/master@{#542340}(32/64-bit)
OS: Windows (7,8,8.1,10)

What steps will reproduce the problem?
1. Launch chrome, and type any url in omnibox(Ex.www.facebook.com)
2. Now hover mouse pointer over items displayed in suggestion list,observe

Actual: Hover effect is not seen properly on suggestion drop down list in omnibox
Expected: Hover effect should be seen properly on suggestion drop down list in omnibox

This is regression issue, broken in ‘M 67’ and will soon update other info :
Good build:67.0.3362.0
Bad build: 67.0.3364.0

Note : Issue is not seen on Mac OS X(10.12.6,10.13.1,10.13.4) and will soon update Linux info
Actual_video.mp4
375 KB View Download
Expected_video.mp4
308 KB View Download

Comment 1 by rp...@etouch.net, Mar 12 2018

Labels: hasbisect-per-revision RegressedIn-67 Target-67 FoundIn-67 OS-Linux
Owner: dschuyler@chromium.org
Status: Assigned (was: Unconfirmed)
This is regression issue, broken in ‘M 67’ and below is the bisect info :
Good build: 67.0.3362.0  (Revision: 540778).
Bad build: 67.0.3364.0 (Revision: 541279).

You are probably looking for a change made after 540910 (known good), but no later than 540911(first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/9bcacc5a585b849f2076b1a11434e57e8b542779..316a3702aa29b428bf8aea2c9386288338919889

Suspect : https://chromium.googlesource.com/chromium/src/+/316a3702aa29b428bf8aea2c9386288338919889

From the CL above, assigning the issue to the concern owner 

@dschuyler- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note : This issue is also seen on Linux (14.04 LTS)OS

Thanks!

Comment 2 by dschuyler@chromium.org, Mar 12 2018

Status: Started (was: Assigned)
Thank you for the bug report
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76748b2c1af8f8f04ecb4769a1341e08ee4612dc

commit 76748b2c1af8f8f04ecb4769a1341e08ee4612dc
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Thu Mar 15 18:34:26 2018

[Omnibox] fix hover over text and images.

This CL uses CanProcessEventsWithinSubtree to stop enter/exit events to
text and image elements.

Bug:  820892 
Change-Id: Ice5adc61ba617db3119eea9a99d10255888aa840
Reviewed-on: https://chromium-review.googlesource.com/962665
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Kevin Bailey <krb@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543456}
[modify] https://crrev.com/76748b2c1af8f8f04ecb4769a1341e08ee4612dc/chrome/browser/ui/views/omnibox/omnibox_result_view.cc
[modify] https://crrev.com/76748b2c1af8f8f04ecb4769a1341e08ee4612dc/chrome/browser/ui/views/omnibox/omnibox_result_view.h
[modify] https://crrev.com/76748b2c1af8f8f04ecb4769a1341e08ee4612dc/chrome/browser/ui/views/omnibox/omnibox_text_view.cc
[modify] https://crrev.com/76748b2c1af8f8f04ecb4769a1341e08ee4612dc/chrome/browser/ui/views/omnibox/omnibox_text_view.h

Comment 5 by dschuyler@chromium.org, Mar 15 2018

Status: Fixed (was: Started)

Comment 6 by rp...@etouch.net, Mar 16 2018

Labels: TE-Verified-M67 TE-Verified-67.0.3372.0
Update :
Rechecked the above issue on Windows (7,8,8.1,10) and Linux (14.04 LTS) OS with latest canary chrome:version 67.0.3372.0 and the issue is fixed.

Kindly refer attached screen cast for reference.
Latest_canary_behavior.mp4
331 KB View Download
►

Sign in to add a comment