New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 820891 link

Starred by 11 users

Issue metadata

Status: Fixed
Owner:
OOO until 2019-01-24
Closed: Aug 2
Components:
EstimatedDays: ----
NextAction: 2018-04-30
OS: Linux , Windows , Mac
Pri: 3
Type: Bug

Blocked on:
issue 808744
issue 823863
issue angleproject:2750

Blocking:
issue 870491
issue 867675
issue 867718


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

WebGL2: EXT_disjoint_timer_query_webgl2 Failing in Beta of 65

Reported by markus.m...@googlemail.com, Mar 12 2018

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.186 Safari/537.36

Steps to reproduce the problem:
API of EXT_disjoint_timer_query_webgl2 changed in Beta 65 ?

What is the expected behavior?
API working the same as in previous versions. MY problem is that we want to ship our WebGL2 app both via the Web and Electron. And Electron is on Chrome 61.

What went wrong?
Our disjoint timer code does not work with 65 Beta

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 64.0.3282.186  Channel: beta
OS Version: OS X 10.13.3
Flash Version:
 
Sorry 65 is already released and it breaks our code for this extension. Trying to find out why.
Basically

 gl.getExtension('EXT_disjoint_timer_query_webgl2');

returns null. Which worked fine up to 65.
Also seeing this problem; not sure if it adds anything useful, but it has also fallen out of the supported extensions list that is reported by the webgl2 context:

document.createElement("canvas").getContext("webgl2").getSupportedExtensions();

Chrome 64:
   (9) ["EXT_color_buffer_float", "EXT_disjoint_timer_query_webgl2", "EXT_texture_filter_anisotropic", "OES_texture_float_linear", "WEBGL_compressed_texture_s3tc", "WEBGL_compressed_texture_s3tc_srgb", "WEBGL_debug_renderer_info", "WEBGL_debug_shaders", "WEBGL_lose_context"]

Chrome 65:
   (8) ["EXT_color_buffer_float", "EXT_texture_filter_anisotropic", "OES_texture_float_linear", "WEBGL_compressed_texture_s3tc", "WEBGL_compressed_texture_s3tc_srgb", "WEBGL_debug_renderer_info", "WEBGL_debug_shaders", "WEBGL_lose_context"]

Labels: Needs-Triage-M64

Comment 5 by kbr@chromium.org, Mar 13 2018

Blockedon: 808744
Labels: -Pri-2 OS-Android OS-Linux OS-Windows Pri-3
Owner: kbr@chromium.org
Status: Assigned (was: Unconfirmed)
This is expected due to the needed fix for  Issue 808744  (sorry, restricted view for now).

We will consider reenabling this extension in a future Chrome release for certain classes of hardware.

Ups, that is very bad new for us.This extension was our only way to
monitor our path tracer's performance and to control "how much work it
got" so that it does not lock up the system. Without it we do not know
how to make our upcoming product work in a user friendly way :(

Comment 7 by pya...@gmail.com, Mar 14 2018

It's not acceptable to simply remove something for no reason given and point to some hypothetical future (nobody knows how far off) in which it might be re-enabled in some way.

This is essential functionality, and having it regress rather than advance harms the advancement of WebGL.

Comment 8 by kbr@chromium.org, Mar 14 2018

I'm sorry about the regression in functionality but we can't currently discuss the reasons for disabling of this extension. They'll be made public in the near future.

Guess the reason is: WebGL2 is dead.

Comment 10 by kbr@chromium.org, Mar 15 2018

That's not the reason.

When essential functionality gets removed on a whim and throwing our whole business model into jeopardy after 3 years of work: Certainly feels like it for us at least.

Comment 12 by kbr@chromium.org, Mar 15 2018

 Issue 822192  has been merged into this issue.

Comment 13 by kbr@chromium.org, Mar 20 2018

Blockedon: 823863

Comment 14 by kbr@chromium.org, Mar 20 2018

NextAction: 2018-04-30
The NextAction date has arrived: 2018-04-30

Comment 16 by reo...@gmail.com, Jun 18 2018

Any updates?

Comment 17 by kbr@chromium.org, Jun 20 2018

Site Isolation is close to being turned on in Chrome for Desktop, and is also being tested in Chrome for Android.

As soon as it ships, the EXT_disjoint_timer_query extensions will be re-enabled.

Blocking: 867675
Any updates on this ? Afaik the current Chrome already ships with site
isolation.
Blocking: 867718
Status: Started (was: Assigned)
https://chromium-review.googlesource.com/1147872
Project Member

Comment 22 by bugdroid1@chromium.org, Jul 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc1732e0386125c0c3aa04690663bfb43e6d7f68

commit cc1732e0386125c0c3aa04690663bfb43e6d7f68
Author: Kenneth Russell <kbr@chromium.org>
Date: Mon Jul 30 19:42:56 2018

Re-enable EXT_disjoint_timer_query WebGL extensions on desktop.

Site Isolation has shipped there so it is safe to expose this
extension again.

Improve the GPU test logs to include the disabled extensions and
WebGL extensions, to reduce confusion.

Bug:  820891 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I404bcab474046d90f82d9ba6d042fb3eaaf394bd
Reviewed-on: https://chromium-review.googlesource.com/1147872
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579125}
[modify] https://crrev.com/cc1732e0386125c0c3aa04690663bfb43e6d7f68/content/browser/gpu/compositor_util.cc
[modify] https://crrev.com/cc1732e0386125c0c3aa04690663bfb43e6d7f68/content/renderer/gpu/gpu_benchmarking_extension.cc
[modify] https://crrev.com/cc1732e0386125c0c3aa04690663bfb43e6d7f68/content/test/gpu/gpu_tests/gpu_process_integration_test.py
[modify] https://crrev.com/cc1732e0386125c0c3aa04690663bfb43e6d7f68/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/cc1732e0386125c0c3aa04690663bfb43e6d7f68/content/test/gpu/gpu_tests/webgl_conformance_expectations.py
[modify] https://crrev.com/cc1732e0386125c0c3aa04690663bfb43e6d7f68/gpu/config/gpu_driver_bug_list.json

Project Member

Comment 23 by bugdroid1@chromium.org, Jul 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/237ff499a8bc3abc3520dd85c03d13a1fd8ff09b

commit 237ff499a8bc3abc3520dd85c03d13a1fd8ff09b
Author: Kenneth Russell <kbr@chromium.org>
Date: Mon Jul 30 23:33:24 2018

Suppress WebglExtension_EXT_disjoint_timer_query on Linux Intel.

linux_optional_gpu_tests_tel doesn't run the WebGL 1.0 conformance
tests on Linux/Intel on the CQ (it should) so this was missed.

Bug:  820891 ,  867675 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I77b898b4ddd83cc1e1ec8fcdcc19918c203433d7
Tbr: kainino@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1155807
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579233}
[modify] https://crrev.com/237ff499a8bc3abc3520dd85c03d13a1fd8ff09b/content/test/gpu/gpu_tests/webgl_conformance_expectations.py

Blockedon: angleproject:2750
Blocking: 870491
Labels: -OS-Android
Status: Fixed (was: Started)
Filed a follow-on bug about re-enabling these extensions on Android once Site Isolation ships there. Calling this Fixed.

Labels: M-70
Chrome 69 has come but still no sign of the extension making it back again. Any update on an ETA ?
According to #27 and https://chromiumdash.appspot.com/commit/cc1732e0386125c0c3aa04690663bfb43e6d7f68 , it will be in Chrome 70.

Sign in to add a comment