New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 8 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment
link

Issue 820876: Scrollbar didn't appear in Chrome Extension Option

Reported by dangngoc...@gmail.com, Mar 12 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.146 Safari/537.36

Steps to reproduce the problem:
1. Install the super dark mode extension.
2. Right click on program icon
3. Choose Option
4. The option page is longer than window view, in previous version of Chrome, the scrollbar will appear and I can choose other items in the bottom of the option page. In this version of Chrome, I cannot choose them, because the scrollbar didn't appear.

What is the expected behavior?
Bring the scrollbar back to the option page of Chrome extension. 

What went wrong?
Scrollbar didn't appear in Option page of Chrome extension.

WebStore page: https://chrome.google.com/webstore/detail/super-dark-mode/nlgphodeccebbcnkgmokeegopgpnjfkc

Did this work before? Yes I don't know exactly, but this bug just has appeared few days ago.

Chrome version: 65.0.3325.146  Channel: stable
OS Version: 10.0
Flash Version:
 
Bug.PNG
251 KB View Download

Comment 1 by gov...@chromium.org, Mar 12 2018

Labels: Needs-Triage-M65

Comment 2 by viswa.karala@chromium.org, Mar 12 2018

Labels: Triaged-ET Needs-Feedback
Unable to reproduce the issue on chrome reported version 65.0.3325.146 using Windows-10 with steps mentioned below:
1) Launched chrome reported version and installed super dark mode extension from URL: https://chrome.google.com/webstore/detail/super-dark-mode/nlgphodeccebbcnkgmokeegopgpnjfkc (as provided in comment#0)
2) Right click on extension icon and clicked on "options"
3) Able to see the scroll bar on new opened window

@Reporter: Please find the attached screen cast for your reference and let us know if we missed anything in reproducing the issue, try to test this issue by creating new profile and let us know if the issue still persists.

Thanks!
820876.mp4
1.5 MB View Download

Comment 3 by dangngoc...@gmail.com, Mar 12 2018

Your Chrome interface for option page is different to mine. I attach the screenshot of option page and screenshot of Chrome version here. Scrollbar still doesn't appear for me.
option-page.PNG
140 KB View Download
version.PNG
161 KB View Download

Comment 4 by sheriffbot@chromium.org, Mar 12 2018

Project Member
Cc: viswa.karala@chromium.org
Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by krajshree@chromium.org, Mar 13 2018

 Issue 820792  has been merged into this issue.

Comment 6 by viswa.karala@chromium.org, Mar 13 2018

Components: UI>Browser>ExtensionsManagement
Labels: -Pri-2 hasbisect-per-revision Target-67 RegressedIn-64 Target-66 M-67 FoundIn-66 FoundIn-67 Target-65 FoundIn-65 OS-Linux OS-Mac Pri-1
Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on reported version 65.0.3325.146 and latest chrome 67.0.3368.0 using Mac 10.12.6, Ubuntu 14.04 and Windows-10, hence providing Bisect Info

Bisect Info:
================
Good build: 64.0.3280.0
Bad build: 64.0.3281.0

You are probably looking for a change made after 520352 (known good), but no later than 520353 (first known bad).

https://chromium.googlesource.com/chromium/src/+log/12b8d4ba28076fdfe6e947d3c18d0a95c70861fc..08c0cf8984048bc5c40d01fc679c11b97c17e5a5

Reviewed-on: https://chromium-review.googlesource.com/786084

@dpapad: Please confirm the issue and help in re-assigning if it is not related to your change.

Thanks!

Comment 7 by dpa...@chromium.org, Mar 13 2018

Cc: szager@chromium.org
I am able to bring back the scrollbar, by removing the line at [1], but unfortunately that also causes some unnecessary scrolling to appear (see white line at the bottom of screenshots).

+szager, since the latter is possibly related to root layers issue 821143.

[1] https://cs.chromium.org/chromium/src/chrome/browser/resources/md_extensions/options_dialog.html?l=31
Screen Shot 2018-03-13 at 10.05.17.png
81.7 KB View Download
Screen Shot 2018-03-13 at 10.05.44.png
389 KB View Download

Comment 8 by dpa...@chromium.org, Mar 13 2018

Status: Started (was: Assigned)
Candidate fix is at https://chromium-review.googlesource.com/c/chromium/src/+/960968.

Comment 9 by bugdroid1@chromium.org, Mar 13 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4912b2051e7f264221deacb9b7ecfbeadddee9d

commit d4912b2051e7f264221deacb9b7ecfbeadddee9d
Author: Demetrios Papadopoulos <dpapad@chromium.org>
Date: Tue Mar 13 21:14:49 2018

MD Extensions: Allow scrolling in options dialog.

This makes it possible for the user to reach extension provided options that
don't fit in the viewport.

Bug:  820876 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Idf3ef16f0cead1da99bf255b32b4669072518c19
Reviewed-on: https://chromium-review.googlesource.com/960968
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542910}
[modify] https://crrev.com/d4912b2051e7f264221deacb9b7ecfbeadddee9d/chrome/browser/resources/md_extensions/options_dialog.html

Comment 10 by dpa...@chromium.org, Mar 13 2018

Status: Fixed (was: Started)

Comment 11 by dpa...@chromium.org, Mar 13 2018

Labels: Merge-Request-66

Comment 12 by abdulsyed@google.com, Mar 14 2018

Labels: -Target-65 -Merge-Request-66 Merge-Approved-66
Approving for M66. Branch:3359

Comment 13 by viswa.karala@chromium.org, Mar 15 2018

Labels: Needs-Feedback
Tested the issue on chrome version 67.0.3371.0 on Ubuntu 14.04, Mac 10.12.6 & Windows-10 with steps mentioned below:
1) Launched chrome reported version and installed extension from URL: https://chrome.google.com/webstore/detail/super-dark-mode/nlgphodeccebbcnkgmokeegopgpnjfkc
2) Enabled "enable-md-extensions" from chrome://flags, right click on extension icon and clicked on "options" and observations are as follows

Observations:
1) Able to see scroll bar on enabling and disabling of "enable-md-extensions" from chrome://flags which is as excepted but the layout of scroll bar is different when compared to reported version(it was thin and red)
2) On reported version able to see scroll bar on disabling of "enable-md-extensions", unable to see scroll bar on enabling and disabling of "enable-md-extensions" from chrome://flags on Mac 10.12.6 and Windows 10, 

@dpapad: Please find the attached screen cast and screenshots of Ubuntu, Mac and Windows and help us confirming the fix on all three OS.

Thanks!
Ubuntu 820876.ogv
4.7 MB View Download
Mac-10.12.6 - 820876.png
180 KB View Download
Windwos 10 - 820876.PNG
416 KB View Download

Comment 14 by dpa...@chromium.org, Mar 15 2018

Labels: -Needs-Feedback
> scroll bar is different when compared to reported version(it was thin and red)

I am noticing this too. This seems like a lower priority aesthetic issue that can probably be addressed at a later point. The functionality bug of not being able to reach all options is still fixed, so I consider this fixed.

Comment 15 by dpa...@chromium.org, Mar 16 2018

So, after further investigation, I think that the different scrollbar is not just aesthetic.

It reveals that the sizing logic was different before than now. I have a revised CL for this at [1], which restores the same style scrollbars as before (see screenshots).


[1] https://chromium-review.googlesource.com/#/c/chromium/src/+/967456
height.png
152 KB View Download
height_100percent.png
131 KB View Download

Comment 16 by dpa...@chromium.org, Mar 17 2018

Cc: scottchen@chromium.org
After discussing with scottchen@, it seems that the latest CL can wait for M67. The already approved CL fixes the immediate functionality issue, so will go ahead with merging that one, and will file a separate bug for the toolbar look.

Comment 17 by vamshi.kommuri@chromium.org, Mar 19 2018

Cc: vamshi.kommuri@chromium.org
 Issue 823143  has been merged into this issue.

Comment 18 by sheriffbot@chromium.org, Mar 19 2018

Project Member
Cc: abdulsyed@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 19 by bugdroid1@chromium.org, Mar 19 2018

Project Member
Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a87f418f89c261921a111eb4340d840af872761

commit 3a87f418f89c261921a111eb4340d840af872761
Author: dpapad <dpapad@chromium.org>
Date: Mon Mar 19 16:46:27 2018

[M66 merge] MD Extensions: Allow scrolling in options dialog.

This makes it possible for the user to reach extension provided options that
don't fit in the viewport.

TBR=dpapad@chromium.org

(cherry picked from commit d4912b2051e7f264221deacb9b7ecfbeadddee9d)

Bug:  820876 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Idf3ef16f0cead1da99bf255b32b4669072518c19
Reviewed-on: https://chromium-review.googlesource.com/960968
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#542910}
Reviewed-on: https://chromium-review.googlesource.com/969108
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#307}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/3a87f418f89c261921a111eb4340d840af872761/chrome/browser/resources/md_extensions/options_dialog.html

Comment 20 by viswa.karala@chromium.org, Mar 21 2018

Labels: Needs-Feedback
Tested the issue on chrome version 66.0.3359.45 on Ubuntu 14.04, Mac 10.12.6 & Windows-10 with steps mentioned below:
1) Launched chrome version and installed extension from URL: https://chrome.google.com/webstore/detail/super-dark-mode/nlgphodeccebbcnkgmokeegopgpnjfkc
2) Enabled "enable-md-extensions" from chrome://flags, right click on extension icon and clicked on "options" and observations are as follows

Observations:
1) Able to see scroll bar on enabling and disabling of "enable-md-extensions" from chrome://flags which is as excepted on Ubuntu 14.04
2) Unable to see scroll bar on enabling and disabling of "enable-md-extensions" from chrome://flags on Mac 10.12.6 and Windows 10

@dpapad: Please find the attached screenshots of Ubuntu, Mac and Windows and help us confirming the fix on Mac and Windows.

Thanks!
820876 - Ubuntu 14.04.png
231 KB View Download
820876 - Windows10.PNG
429 KB View Download
820876 - Mac 10.12.6.png
189 KB View Download

Comment 21 by dpa...@chromium.org, Mar 21 2018

The Mac and Windows screenshot don't have any scrollbar because there is no overflowing happening. Note that there is available space below the dialog. Does the scrollbar show if if you make the window smaller before opening the dialog?

Comment 22 by sindhu.chelamcherla@chromium.org, Mar 26 2018

Cc: sindhu.chelamcherla@chromium.org
 Issue 825516  has been merged into this issue.

Comment 23 by reyron...@gmail.com, Apr 4 2018

Hello guys!

Does anyone have an ETA on when this will land in Chrome Stable? I've been seeing the same buggy behavior with the extension I develop and my users are currently not able to interact with the entirety of the Options page, see details here: https://github.com/refined-bitbucket/refined-bitbucket/issues/195

Comment 24 by dpa...@chromium.org, Apr 7 2018

Once M66 goes to Stable this fix will be out, and should address the problem of having some options being unreachable by the user. Then on M67 there will be a better fix (more aligned with what the old UI did).

Sign in to add a comment