Set suites to missing power tests and run them properly |
||||
Issue descriptionI found some media power tests have no suite. A test doesn't run if suite is not specified in its control file. Such tests are video_HangoutHardwarePerf/control.power.vp8 video_PlaybackPerf/control.power_h264 video_PlaybackPerf/control.power_vp8 video_PlaybackPerf/control.power_vp9 video_WebRtcPerf/control.power https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/845250 I created set suites to them. But cywang@ said they should run in server side, not on DUT. video_PowerComsumption (server tests) actually calls video_PlaybackPerf tests. I don't know there are server tests for video_HangoutHardwarePerf and video_WebRtcPerf. How should we deal with them?
,
Mar 12 2018
I did't look at them. Should I remove client tests? What do you think about current suite settings in video_PowerConsumption?
,
Mar 12 2018
Does look like video_PowerConsumption server test is running all but hw_hangout on a regular basis, grep ATT control.* control.h264:ATTRIBUTES = "suite:bvt-perbuild" control.hw_hangout.vp8:ATTRIBUTES = "suite:bvt-perbuild" control.vp8:ATTRIBUTES = "suite:bvt-perbuild" control.vp9:ATTRIBUTES = "suite:bvt-perbuild" control.webrtc:ATTRIBUTES = "suite:bvt-perbuild" https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/testDetails?testName=video_PowerConsumption&suite=&daysBack=7&board=&architecture=&boardFamily=&buildConfig=release&reason=&version=&milestone=&dut= And absence of hw_hangout is due to: START ---- video_PowerConsumption.hw_hangout.vp8 timestamp=1520866233 localtime=Mar 12 07:50:33 TEST_NA ---- video_PowerConsumption.hw_hangout.vp8 timestamp=1520866233 localtime=Mar 12 07:50:33 Skipping: test not supported on this board/pool. END TEST_NA ---- video_PowerConsumption.hw_hangout.vp8 timestamp=1520866233 localtime=Mar 12 07:50:33 I suspect because of this DEPENDENCIES: hw_video_ac_enc_vp8 which was added here: https://chromium-review.googlesource.com/275452 +Wu-cheng for any background on that dep which I can't seem to find for any device in lab currently ('atest host list | grep hw_video_ac_enc_vp8' )
,
Mar 12 2018
I see. I will investigate TEST_NA in hw_hangout. I am going to add (or change) crosbolt_perf_perbuild to their suites for crosboltv2. cywang@, which do you think to prefer, add or change? It's interesting they run even though no device has "rpm" label.
,
Mar 13 2018
Yes, append the crosbolt_perf_perbuild for now please.
,
Mar 13 2018
I created the CL to delete unused control files, crosreview.com/845250 remove rpm and add crosbolt_perf_perbuild to video_PowerConsumption, crosreview.com/958309 PTAL, Thanks
,
Mar 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/505588158ddae04b921c58a4b880048bc1c3b4c9 commit 505588158ddae04b921c58a4b880048bc1c3b4c9 Author: Hirokazu Honda <hiroh@chromium.org> Date: Tue Mar 13 14:36:58 2018 video_PowerConsumption: add crosbolt_perf_perbuild and remove rpm label Remove unused "rpm" label. Add crosbolt_perf_perbuild to suite for crosboltv2 BUG= 820875 TEST=None Change-Id: I5c50e73225ceede60fcff71ceb6c3b6e158ccf50 Reviewed-on: https://chromium-review.googlesource.com/958309 Commit-Ready: Hirokazu Honda <hiroh@chromium.org> Tested-by: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Chung-yih Wang <cywang@chromium.org> [modify] https://crrev.com/505588158ddae04b921c58a4b880048bc1c3b4c9/server/site_tests/video_PowerConsumption/control.vp8 [modify] https://crrev.com/505588158ddae04b921c58a4b880048bc1c3b4c9/server/site_tests/video_PowerConsumption/control.vp9 [modify] https://crrev.com/505588158ddae04b921c58a4b880048bc1c3b4c9/server/site_tests/video_PowerConsumption/control.hw_hangout.vp8 [modify] https://crrev.com/505588158ddae04b921c58a4b880048bc1c3b4c9/server/site_tests/video_PowerConsumption/control.webrtc [modify] https://crrev.com/505588158ddae04b921c58a4b880048bc1c3b4c9/server/site_tests/video_PowerConsumption/control.h264
,
Mar 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/2451a7a09b90cb040e8e1e5c99cd49e8806d1272 commit 2451a7a09b90cb040e8e1e5c99cd49e8806d1272 Author: Hirokazu Honda <hiroh@chromium.org> Date: Wed Mar 14 16:42:18 2018 Add Annotatation for power consumption tests which don't run on client The following power consumption tests don't run on client. They are redundant with a repspect to calls made in server test, video_PowerComsumption. The control files, however, are useful to measure power consumption in local macines. I add the annotation to not confuse their existenses. video_HangoutHardwarePerf/control.power.vp8 video_PlaybackPerf/control.power_h264 video_PlaybackPerf/control.power_vp8 video_PlaybackPerf/control.power_vp9 video_WebRtcPerf/control.power BUG= chromium:820875 TEST=None Change-Id: I6652026a9f8e935c02c3166bab4ef1279e1f6810 Reviewed-on: https://chromium-review.googlesource.com/845250 Commit-Ready: Hirokazu Honda <hiroh@chromium.org> Tested-by: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Ilja H. Friedel <ihf@chromium.org> Reviewed-by: Todd Broch <tbroch@chromium.org> [modify] https://crrev.com/2451a7a09b90cb040e8e1e5c99cd49e8806d1272/client/site_tests/video_HangoutHardwarePerf/control.power.vp8 [modify] https://crrev.com/2451a7a09b90cb040e8e1e5c99cd49e8806d1272/client/site_tests/video_PlaybackPerf/control.power_vp8 [modify] https://crrev.com/2451a7a09b90cb040e8e1e5c99cd49e8806d1272/client/site_tests/video_PlaybackPerf/control.power_vp9 [modify] https://crrev.com/2451a7a09b90cb040e8e1e5c99cd49e8806d1272/client/site_tests/video_PlaybackPerf/control.power_h264 [modify] https://crrev.com/2451a7a09b90cb040e8e1e5c99cd49e8806d1272/client/site_tests/video_WebRtcPerf/control.power
,
Mar 16 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by cywang@chromium.org
, Mar 12 2018