caroline informational PFQ failed HWtest because of crashes |
|||
Issue descriptionSee https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/caroline-tot-chrome-pfq-informational/builds/1161 as an example. It has been failing since Mar 9th. Callstack: 0 chrome!ChromeAppListModelUpdater::AddItemToOemFolder(std::__1::unique_ptr<ChromeAppListItem, std::__1::default_delete<ChromeAppListItem> >, app_list::AppListSyncableService::SyncItem*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, syncer::Ordinal<syncer::StringOrdinalTraits> const&) [chrome_app_list_model_updater.cc : 405 1 chrome!app_list::AppListSyncableService::AddItem(std::__1::unique_ptr<ChromeAppListItem, std::__1::default_delete<ChromeAppListItem> >) [app_list_syncable_service.cc : 478 + 0x12] 2 chrome!AppListModelBuilder::InsertApp(std::__1::unique_ptr<ChromeAppListItem, std::__1::default_delete<ChromeAppListItem> >) [app_list_model_builder.cc : 32 + 0x5] 3 chrome!non-virtual thunk to ArcAppModelBuilder::OnAppRegistered(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, ArcAppListPrefs::AppInfo const&) [arc_app_model_builder.cc : 53 + 0x8] 4 chrome!ArcAppListPrefs::AddAppAndShortcut(bool, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, bool, bool, bool, bool, arc::mojom::OrientationLock) [arc_app_list_prefs.cc : 988 + 0xb] 5 chrome!ArcAppListPrefs::RegisterDefaultApps() [arc_app_list_prefs.cc : 821 + 0x1c] 6 chrome!ArcAppListPrefs::OnDefaultAppsReady() [arc_app_list_prefs.cc : 790 + 0x8] 7 chrome!ArcDefaultAppList::OnAppsReady(std::__1::unique_ptr<std::__1::map<std::__1::basic_ Suspicious CL: https://chromium-review.googlesource.com/c/chromium/src/+/954355
,
Mar 12 2018
Taken. Should be a bug in the following CL: https://chromium-review.googlesource.com/c/chromium/src/+/954355
,
Mar 12 2018
,
Mar 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9adc23633934dd4399596b08cb575acddf0e3b79 commit 9adc23633934dd4399596b08cb575acddf0e3b79 Author: Jiaquan He <hejq@google.com> Date: Mon Mar 12 17:29:11 2018 app_list: fix some folder issues. Fix 1: If app_list_controller_ is not ready, which means the model adapter is inactive, we add this item in Chrome first. Fix 2: While sending a whole trunk of model data to Ash, we also send folders in case folder information was updated. Bug: 733662 Bug: 820873 Change-Id: I60aa899acff2a5a5203496498b278f2d6e6cfddb Reviewed-on: https://chromium-review.googlesource.com/958244 Commit-Queue: Jiaquan He <hejq@google.com> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#542525} [modify] https://crrev.com/9adc23633934dd4399596b08cb575acddf0e3b79/ash/app_list/app_list_controller_impl.cc [modify] https://crrev.com/9adc23633934dd4399596b08cb575acddf0e3b79/chrome/browser/ui/app_list/chrome_app_list_item.cc [modify] https://crrev.com/9adc23633934dd4399596b08cb575acddf0e3b79/chrome/browser/ui/app_list/chrome_app_list_item.h [modify] https://crrev.com/9adc23633934dd4399596b08cb575acddf0e3b79/chrome/browser/ui/app_list/chrome_app_list_model_updater.cc
,
Mar 16 2018
Marked as fixed. Please reopen if problems reproduce. |
|||
►
Sign in to add a comment |
|||
Comment 1 by x...@chromium.org
, Mar 12 2018