New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 820844 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

ASSERT: GTK_IS_WIDGET (widget)

Project Member Reported by ClusterFuzz, Mar 11 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5755085569916928

Fuzzer: mbarbella_js_mutation_layout
Job Type: linux_lsan_chrome_mp
Platform Id: linux

Crash Type: ASSERT
Crash Address: 
Crash State:
  GTK_IS_WIDGET (widget)
  mojo::internal::InterfacePtrState<ukm::mojom::UkmRecorderInterface>::ConfigurePr
  instance
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_lsan_chrome_mp&range=523898:523900

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5755085569916928

Additional requirements: Requires Gestures

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Mar 11 2018

Components: Internals>Mojo
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by sheriffbot@chromium.org, Mar 12 2018

Labels: M-66
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 12 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 12 2018

Labels: Pri-1
Project Member

Comment 5 by sheriffbot@chromium.org, Mar 13 2018

Labels: -Security_Impact-Head Security_Impact-Beta

Comment 6 by est...@chromium.org, Mar 14 2018

Cc: sky@chromium.org
Owner: timbrown@chromium.org
Status: Assigned (was: Untriaged)
timbrown, can you please take a look? https://chromium-review.googlesource.com/822160 is in the regression range and looks possibly relevant.

Comment 7 by sky@chromium.org, Mar 14 2018

Cc: thomasanderson@chromium.org
I haven't been able to reproduce the issue locally yet. Also I very strongly doubt that the linked CL has anything to do with this issue. Most of the changes in that CL are comment changes, and the rest simply delete dead code. Any executed code paths should not have been changed by that CL.

I will continue to investigate to see what I can find.

Comment 9 by mmoroz@chromium.org, Mar 28 2018

Friendly ping from Chrome Security Sheriff. This is a high severity security issue affecting Beta branch. timbrown@, could you please take another look, or should we try to find another owner?
I looked at this again yesterday. My thoughts so far:

1. In terms of my CL being the culprit, the only code (not comments) that were changed were:
 - removing 2 unused files (and an unused build config)
 - changing some enums, mainly in mojo

The enums that were changed don't even exist in the code base anymore. So it's not even possible to revert the change.

In summary, I'm very confident the referenced CL isn't the cause of any issues.

2. The clusterfuzz output is not reproducible locally. I'm trying to reproduce as close as possible (from the information I have) the environment that the clusterfuzz bots actually use, but this is starting to really get outside of my experience.

Note that have been 4 clusterfuzz found bugs which have been blamed on this cl (this one, 824616, 817595, and another that I've already unassigned from myself and can't find now).
Just a heads up, M66 Stable cut is on April 12th, 10 days away. This issue is marked as RB-Stable for 66. Please make sure to address this issue prior to stable cut. Thanks! 
Labels: -ReleaseBlock-Stable
Project Member

Comment 13 by sheriffbot@chromium.org, Apr 3 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Security_Severity-High -Security_Impact-Beta -ReleaseBlock-Stable
This is a non-regression issue.  That is, a production environment already had this problem and we're merely seeing it in our tests now.  Please feel free to remove ReleaseBlock-Stable if sheriffbot adds it back again.
Labels: Security_Severity-High Security_Impact-Beta
Hi thomasanderson@, I have to add back a couple of security labels so that it can get off security sheriff's queue. 
Project Member

Comment 16 by sheriffbot@chromium.org, Apr 6 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -ReleaseBlock-Stable ReleaseBlock-NA
Status: WontFix (was: Assigned)
Seems flaky and we haven't hit this crash in a while. Closing this out to let CF file a new bug if we start hitting it again, but I don't think there's anything actionable here.
Project Member

Comment 19 by ClusterFuzz, Apr 19 2018

Labels: Needs-Feedback
ClusterFuzz testcase 5755085569916928 is still reproducing on tip-of-tree build (trunk).

If this testcase was not reproducible locally or unworkable, ignore this notification and we will file another bug soon with hopefully a better and workable testcase.

Otherwise, if this is not intended to be fixed (e.g. this is an intentional crash), please add ClusterFuzz-Ignore label to prevent future bug filing with similar crash stacktrace.
Project Member

Comment 20 by sheriffbot@chromium.org, Jul 20

Labels: -Restrict-View-SecurityTeam allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment