New issue
Advanced search Search tips

Issue 820825 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocking:
issue 864711



Sign in to add a comment

CHECK failure: buffer->discard_padding().first == base::TimeDelta() (NUMBER s vs. 0 s) in ffmpe

Project Member Reported by ClusterFuzz, Mar 11 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5813463100948480

Fuzzer: libFuzzer_media_pipeline_integration_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  buffer->discard_padding().first == base::TimeDelta() (NUMBER s vs. 0 s) in ffmpe
  media::FFmpegDemuxerStream::EnqueuePacket
  media::FFmpegDemuxer::OnReadFrameDone
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=523270:523295

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5813463100948480

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Mar 11 2018

Components: Internals>Core Internals>Media
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Mar 11 2018

Labels: Test-Predator-Auto-Owner
Owner: posciak@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/a4b1e71fd3146e936ab1668233218ab86eccdd2b (Add additional owners to media/gpu/vaapi/OWNERS).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Cc: posciak@chromium.org
Owner: wolenetz@chromium.org
Not sure where this started coming from...
Labels: Test-Predator-Wrong-CLs
Labels: -Pri-1 Pri-2
Owner: tguilbert@chromium.org
=>tguilbert as part of new ffmpeg roll.
Blocking: 864711
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b375b47c2d3120c63adbdd824cfb8fedc6737f9

commit 7b375b47c2d3120c63adbdd824cfb8fedc6737f9
Author: Thomas Guilbert <tguilbert@chromium.org>
Date: Thu Oct 11 23:57:27 2018

Fix clusterfuzz DCHECK crash

It is possible for the first part of the discard padding to be non-zero
when fixing up negative timestamps. This causes a DCHECK crash.

This CL fixes the issue by removing the DCHECK and keeping the max
values of pre-buffer discard padding in the relevant code branch.

Bug:  820825 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Idaceff2188b1e88c97285bf8f571042e936d0797
Reviewed-on: https://chromium-review.googlesource.com/c/1277809
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599019}
[modify] https://crrev.com/7b375b47c2d3120c63adbdd824cfb8fedc6737f9/media/filters/ffmpeg_demuxer.cc

Project Member

Comment 9 by ClusterFuzz, Oct 12

ClusterFuzz has detected this issue as fixed in range 599018:599020.

Detailed report: https://clusterfuzz.com/testcase?key=5813463100948480

Fuzzer: libFuzzer_media_pipeline_integration_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  buffer->discard_padding().first == base::TimeDelta() (NUMBER s vs. 0 s) in ffmpe
  media::FFmpegDemuxerStream::EnqueuePacket
  media::FFmpegDemuxer::OnReadFrameDone
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=523270:523295
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=599018:599020

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5813463100948480

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Oct 12

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 5813463100948480 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment