New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 820784 link

Starred by 1 user
Status: Fixed
Owner:
chenghan@chromium.org
Closed: Mar 2018
Cc:
█ yhong@chromium.org
chromeos-factory-eng@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

hwid: build database fail when using default item

Project Member Reported by chenghan@chromium.org, Mar 11 2018 
Chrome Version: ToT
OS: Chrome

What steps will reproduce the problem?
(1) Use a DUT with some essential components not probeable (e.g. mosys not ready for dram)
(2) Run `hwid build-database`
(3) When prompt "Do you want to add a default item?", enter "y"

What is the expected result?
Succesfully create hwid database

What happens instead?
KeyError in database.py line 1118
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/9ca33444216f6b4bd913f96497abfe2d140f3160

commit 9ca33444216f6b4bd913f96497abfe2d140f3160
Author: Cheng-Han Yang <chenghan@google.com>
Date: Sun Mar 11 14:54:34 2018

hwid: fix KeyError when default item is used.

BUG= chromium:820784 
TEST=make test, manually test on DUT

Change-Id: Ieb65fb2ead035cb8aa0bdf07d6877e8e4dfed54f
Reviewed-on: https://chromium-review.googlesource.com/957569
Commit-Ready: Yong Hong <yhong@google.com>
Tested-by: Cheng-Han Yang <chenghan@chromium.org>
Reviewed-by: Yong Hong <yhong@google.com>

[modify] https://crrev.com/9ca33444216f6b4bd913f96497abfe2d140f3160/py/hwid/v3/database.py

Comment 2 by chenghan@chromium.org, Mar 12 2018

Status: Fixed (was: Untriaged)
►

Sign in to add a comment