New issue
Advanced search Search tips

Issue 820759 link

Starred by 2 users
Status: Fixed
Owner: ----
Closed: Apr 2018
Cc:
jdoerrie@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Saved Passwords are displayed truncated without indication that they're longer

Reported by claudio....@gmail.com, Mar 11 2018 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.167 Safari/537.36

Steps to reproduce the problem:
1. Save a long password (>20 characters) for a website
2. Go to Settings > Manage Passwords > Saved Passwords
3. Reveal the password for the website

What is the expected behavior?
The password is displayed in full, or the password is displayed truncated with ellipses (...) and an indication that the password is actually longer, with a way to see it in full.

What went wrong?
The password is displayed truncated without indication that it is truncated e.g. ellipses (...). Only the first ~20 characters are displayed.

This may lead to negative consequences when copying the password or typing it into another device, e.g. resulting into locked accounts for too many failed login attempts.

The field is actually scrollable, but there is no indication that the field can be scrolled. You can scroll the field with the mouse or select-drag.

Did this work before? No 

Chrome version: 64.0.3282.167  Channel: stable
OS Version: OS X 10.11.6
Flash Version:
repro.mov
3.7 MB View Download

Comment 1 by meh...@chromium.org, Mar 11 2018 

 Issue 820760  has been merged into this issue.

Comment 2 by meh...@chromium.org, Mar 11 2018

Components: -UI UI>Browser>Passwords

Comment 3 Deleted

Comment 4 by krajshree@chromium.org, Mar 11 2018

Labels: Needs-Triage-M64

Comment 5 by battre@chromium.org, Mar 12 2018

Cc: jdoerrie@chromium.org
Labels: OS-Chrome OS-Linux OS-Windows
Status: Available (was: Unconfirmed)

Comment 6 by battre@chromium.org, Mar 12 2018

Labels: Hotlist-GoodFirstBug
Maybe we should add
  text-overflow: ellipsis;
to .password-field

Comment 7 by qi1988.y...@samsung.com, Mar 20 2018 

Patch is submited in https://chromium-review.googlesource.com/c/chromium/src/+/970223

PTAL, thanks

Comment 8 by qi1988.y...@samsung.com, Mar 21 2018 

This is the fixed result for password field.
For long password case, ellipsis is shown, and can be dragged and copied by mouse.
For short password case, no ellipsis is shown.
Fixed.png
51.1 KB View Download

Comment 9 by claudio....@gmail.com, Mar 23 2018 

This looks great! Thanks for taking the time to submit a patch! Only potential issue with ellipsis is that the password itself may contain periods but I guess that's really an edge case.

Comment 10 by viswa.karala@chromium.org, Mar 27 2018

Labels: TE-Verified-M67 TE-Verified-67.0.3381.0
Able to reproduce the issue on chrome reported version 64.0.3282.167
Verified the fix on Mac 10.12.6, Windows-10 & Ubuntu 14.04 on Chrome version #67.0.3381.0 as per the comment#0
Attaching screenshot for reference.
Observed "Password displayed is truncated with ellipses(...) with a way to see it in full"
Hence, the fix is working as expected.
Adding the verified label.

Thanks!
820759.PNG
332 KB View Download

Comment 11 by hcarmona@chromium.org, Apr 10 2018

Status: Fixed (was: Available)
►

Sign in to add a comment