New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 820736 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Merge to M66: Update webrtc related browser tests data. whitelist new GetStats metric.

Project Member Reported by ilnik@chromium.org, Mar 10 2018

Issue description

Change landed in Chromium here:
https://chromium.googlesource.com/chromium/src/+/360c12a3e5b56d5d93089f1ceac713b7c055d3c4

This is the update for tests, which are broken by the merge to M66 from here:
https://bugs.chromium.org/p/chromium/issues/detail?id=81932


 

Comment 1 by ilnik@chromium.org, Mar 10 2018

Cc: abdulsyed@chromium.org
+abdulsyed

The change doesn't touch any production code and updates only tests. It has to be done separately from the change breaking the tests, because the feature is added in WebRTC repository and tests are in the Chromium repository.

Comment 2 by ilnik@chromium.org, Mar 10 2018

Description: Show this description
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 11 2018

Labels: -Merge-Request-66 Merge-Approved-66 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 12 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11193961ebf43230d39eec7af7ee4bdcacc452af

commit 11193961ebf43230d39eec7af7ee4bdcacc452af
Author: Ilya Nikolaevskiy <ilnik@chromium.org>
Date: Mon Mar 12 09:02:00 2018

Merge to M66: Update webrtc related browser tests data
Whitelist new GetStats metric.

TBR=ilnik@chromium.org,hta@chromium.org,emircan@chromium.org

(cherry picked from commit 360c12a3e5b56d5d93089f1ceac713b7c055d3c4)

Bug:  webrtc:8901 , chromium:820736 
Change-Id: I026a181636fd4c27cd4739a6f580529768aeda72
Reviewed-on: https://chromium-review.googlesource.com/950776
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#541080}
Reviewed-on: https://chromium-review.googlesource.com/958422
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#154}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/11193961ebf43230d39eec7af7ee4bdcacc452af/chrome/test/data/webrtc/peerconnection_getstats.js

Comment 5 by ilnik@chromium.org, Mar 12 2018

Status: Fixed (was: Assigned)

Sign in to add a comment