New issue
Advanced search Search tips

Issue 820723 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

13.6% regression in angle_perftests at 541975:542049

Project Member Reported by jmadill@google.com, Mar 10 2018

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Mar 10 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=820723

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=7e853dfc47021552e21080ffe50876d9af0c0c186e3f1458818d66cf06782d01


Bot(s) for this bug's original alert(s):

chromium-rel-win7-gpu-nvidia
Cc: -jmadill@google.com
Components: Internals>GPU>ANGLE
Labels: OS-Windows
Owner: jmad...@chromium.org
Status: Assigned (was: Untriaged)
Cc: jmad...@chromium.org
Owner: jdarpinian@chromium.org
James, I think this is probably related to your buffer binding changes. Can you investigate?
Also filed  issue 820977  about the pinpoint job not recursing into third_party/angle.
Looks like the major reason for the slowdown in Bindings_gl_100_objects_allocated_every_iteration is that I added the three loops here: https://cs.chromium.org/chromium/src/third_party/angle/src/libANGLE/State.cpp?l=1448&rcl=64e5ed2abd8a4cc77d3647e4b245db57a8c42ae5

Before, we weren't checking those binding points when detaching buffers.

For the other tests, it's simply the overhead of doing more refcounting, which these microbenchmarks exercise a lot. For WebGL it's necessary for spec compliance. If you think it's necessary I can add some checks to see whether it's a WebGL context or not before doing the refcounting.
Maybe you could add an early out if the ref count == 0? It should be this in many cases where the app deletes an unbound buffer.
Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Can confirm graph has recovered: https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICQ0uOw5AgM

Sign in to add a comment