New issue
Advanced search Search tips

Issue 820721 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 2
Type: Bug



Sign in to add a comment

"ServiceWorkerHandleTest.DispatchExtendableMessageEvent_FromClient" is flaky on fuchsia_x64

Project Member Reported by chromium...@appspot.gserviceaccount.com, Mar 10 2018

Issue description

"ServiceWorkerHandleTest.DispatchExtendableMessageEvent_FromClient" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyTAsSBUZsYWtlIkFTZXJ2aWNlV29ya2VySGFuZGxlVGVzdC5EaXNwYXRjaEV4dGVuZGFibGVNZXNzYWdlRXZlbnRfRnJvbUNsaWVudAw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by tapted@chromium.org, Mar 12 2018

Cc: w...@chromium.org
Components: Blink>ServiceWorker
Labels: OS-Fuchsia
only flake is on fuchsia_x64

[ RUN      ] ServiceWorkerHandleTest.DispatchExtendableMessageEvent_FromClient
[160077:626950491:0309/223947.373589:269794585:ERROR:base_paths_fuchsia.cc(37)] Not implemented reached in bool base::PathProviderFuchsia(int, base::FilePath *)
[160077:755400943:0309/223947.614121:270035155:FATAL:url_request_job_factory.cc(19)] Check failed: (thread_checker_).CalledOnValidThread().

Comment 2 by tapted@chromium.org, Mar 12 2018

Summary: "ServiceWorkerHandleTest.DispatchExtendableMessageEvent_FromClient" is flaky on fuchsia_x64 (was: "ServiceWorkerHandleTest.DispatchExtendableMessageEvent_FromClient" is flaky)

Comment 3 by tapted@chromium.org, Mar 12 2018

Labels: -Pri-1 Pri-2

Comment 4 by tapted@chromium.org, Mar 12 2018

Labels: -Sheriff-Chromium
Owner: leon....@intel.com
Status: Assigned (was: Untriaged)
Related to  Issue 820620 ?

Comment 5 by w...@chromium.org, Mar 12 2018

Components: Internals>PlatformIntegration
ServiceWorkerHandleTest.DispatchExtendableMessageEvent_FromClient crashed with:

[00270.285] 04060.04110> [ RUN      ] ServiceWorkerHandleTest.DispatchExtendableMessageEvent_FromClient
[00270.285] 04060.04110> [160077:626950491:0309/223947.373589:269794585:ERROR:base_paths_fuchsia.cc(37)] Not implemented reached in bool base::PathProviderFuchsia(int, base::FilePath *)
[00270.285] 04060.04110> [160077:755400943:0309/223947.614121:270035155:FATAL:url_request_job_factory.cc(19)] Check failed: (thread_checker_).CalledOnValidThread().
#00: base::debug::StackTrace::StackTrace(unsigned long) at base/debug/stack_trace_fuchsia.cc:174
#01: endl<char, std::__1::char_traits<char> > at buildtools/third_party/libc++/trunk/include/ostream:1001
      (inlined by) operator<< at buildtools/third_party/libc++/trunk/include/ostream:195
      (inlined by) ~LogMessage at base/logging.cc:595
#02: ~URLRequestJobFactory at net/url_request/url_request_job_factory.cc:20
#03: ~URLRequestJobFactoryImpl at net/url_request/url_request_job_factory_impl.cc:23
#04: reset at buildtools/third_party/libc++/trunk/include/memory:2596
      (inlined by) ~unique_ptr at buildtools/third_party/libc++/trunk/include/memory:2553
      (inlined by) ~URLRequestContextStorage at net/url_request/url_request_context_storage.cc:40
#05: reset at buildtools/third_party/libc++/trunk/include/memory:2596
      (inlined by) ~unique_ptr at buildtools/third_party/libc++/trunk/include/memory:2553
      (inlined by) ~TestURLRequestContext at net/url_request/url_request_test_util.cc:66
#06: ~TestContextURLRequestContextGetter at content/public/test/test_browser_context.cc:39
      (inlined by) ~TestContextURLRequestContextGetter at content/public/test/test_browser_context.cc:39
#07: OnDestruct at net/url_request/url_request_context_getter.cc:37
#08: DoDelete at base/sequenced_task_runner_helpers.h:24
#09: Run at base/callback.h:95
      (inlined by) RunTask at base/debug/task_annotator.cc:61
#10: ~ScopedTracer at base/trace_event/trace_event.h:1106
      (inlined by) RunOrSkipTask at base/task_scheduler/task_tracker.cc:461
#11: RunOrSkipTask at base/task_scheduler/task_tracker_posix.cc:25
#12: RunOrSkipTask at base/test/scoped_task_environment.cc:286
#13: RunAndPopNextTask at base/task_scheduler/task_tracker.cc:353
#14: swap<base::internal::Sequence *> at buildtools/third_party/libc++/trunk/include/type_traits:4646
      (inlined by) swap at base/memory/scoped_refptr.h:231
      (inlined by) operator= at base/memory/scoped_refptr.h:227
      (inlined by) ThreadMain at base/task_scheduler/scheduler_worker.cc:85
#15: ThreadFunc at base/threading/platform_thread_posix.cc:78
#16: pc 0x76699e20bde6 (libc.so,0x10de6)
#17: pc 0x76699e281549 (libc.so,0x86549)
[00270.292] 04060.04110>
[00270.292] 04060.04110> [2205/5377] ServiceWorkerHandleTest.DispatchExtendableMessageEvent_FromClient (CRASHED)


Comment 6 by w...@chromium.org, Mar 12 2018

Labels: M-67

Comment 7 by leon....@intel.com, Mar 12 2018

The explicit crash stack provided at c#5 (Thanks wez@ !) is different with  issue 820620 , but I suspect probably this may also be caused by the same root cause.

I prepared a fix CL https://chromium-review.googlesource.com/c/chromium/src/+/958126 for  issue 820620 , which will re-enable this _FromClient test, I think we can land it and then observe whether this flake will appear again, if not then we are all happy, if flake appears again then we need more investigation..

Comment 8 by leon....@intel.com, Mar 14 2018

Just a update:
The flaky test ServiceWorkerHandleTest.DispatchExtendableMessageEvent_FromClient has already been re-enabled yesterday by the CL mentioned at c#7, and we can see that no new flakes are detected until now (24 hours passed).
Suppose this has been fixed.

Comment 9 by falken@chromium.org, Mar 16 2018

Status: Fixed (was: Assigned)
Thanks Leon, marking fixed. As far as I can tell, this is just a crash in the test code fixed by https://chromium-review.googlesource.com/c/chromium/src/+/958126 and we don't need merges anywhere.

Sign in to add a comment