New issue
Advanced search Search tips

Issue 820709 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Crash happens when select "Leave" of the dialog "Leave incognito mode"

Project Member Reported by xfzhang...@gmail.com, Mar 10 2018

Issue description

Steps to reproduce the problem:
1. Open a incognito tab in Chrome
2. Open a video website like "https://www.youku.com"
3. Open any video, there is a dialog shows:
    "Leave incognito mode? ...."
4. Select "Leave". 

What is the expected behavior?
Browser works well

What went wrong?
Chrome crashs.

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 64.0.3282.123  Channel: n/a
OS Version: 8.0
Flash Version: 

03-10 16:21:49.753 19260-19260/? E/AndroidRuntime: FATAL EXCEPTION: main
                                                   Process: com.android.chrome, PID: 19260
                                                   android.content.ActivityNotFoundException: No Activity found to handle Intent { act=android.intent.action.VIEW cat=[android.intent.category.BROWSABLE] dat=market://details?id=com.youku.phone&referrer=com.android.chrome flg=0x10000000 pkg=com.android.vending (has extras) }
                                                       at android.app.Instrumentation.checkStartActivityResult(Instrumentation.java:1981)
                                                       at android.app.Instrumentation.execStartActivity(Instrumentation.java:1636)
                                                       at android.app.Activity.startActivityForResult(Activity.java:4754)
                                                       at android.support.v4.app.i.startActivityForResult(BaseFragmentActivityApi16.java:5)
                                                       at android.support.v4.app.p.startActivityForResult(FragmentActivity.java:349)
                                                       at android.app.Activity.startActivityForResult(Activity.java:4694)
                                                       at android.support.v4.app.p.startActivityForResult(FragmentActivity.java:313)
                                                       at android.app.Activity.startActivity(Activity.java:5115)
                                                       at android.app.Activity.startActivity(Activity.java:5083)
                                                       at org.chromium.chrome.browser.externalnav.ExternalNavigationDelegateImpl.startActivity(ExternalNavigationDelegateImpl.java:117)
                                                       at org.chromium.chrome.browser.externalnav.ExternalNavigationDelegateImpl$3.onClick(ExternalNavigationDelegateImpl.java:2)
                                                       at android.support.v7.app.C.handleMessage(AlertController.java:5)
                                                       at android.os.Handler.dispatchMessage(Handler.java:108)
                                                       at android.os.Looper.loop(Looper.java:166)
                                                       at android.app.ActivityThread.main(ActivityThread.java:7406)
                                                       at java.lang.reflect.Method.invoke(Native Method)
                                                       at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:245)
                                                       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:926)
03-10 16:21:49.760 743-2673/? I/iMonitor: create: 901001001
03-10 16:21:49.761 743-2673/? I/iMonitor: send: 901001001
03-10 16:21:49.936 19260-19260/? W/google-breakpad: Output crash dump file:
03-10 16:21:49.936 19260-19260/? W/google-breakpad: /data/user/0/com.android.chrome/cache/Crash Reports/c89b9b69-1029-4d28-84948ba3-b262306f.dmp
03-10 16:21:49.937 19260-19260/? W/google-breakpad: ### ### ### ### ### ### ### ### ### ### ### ### ###
03-10 16:21:49.937 19260-19260/? W/google-breakpad: Chrome build fingerprint:
03-10 16:21:49.937 19260-19260/? W/google-breakpad: 64.0.3282.123
03-10 16:21:49.937 19260-19260/? W/google-breakpad: 328212300
03-10 16:21:49.937 19260-19260/? W/google-breakpad: ### ### ### ### ### ### ### ### ### ### ### ### ###
03-10 16:21:49.973 20111-19260/? A/google-breakpad: -----BEGIN BREAKPAD MICRODUMP-----
03-10 16:21:49.973 20111-19260/? A/google-breakpad: V Chrome_Android:64.0.3282.123
03-10 16:21:49.973 20111-19260/? A/google-breakpad: O A arm 08 armv7l HUAWEI/MHA-AL00/HWMHA:8.0.0/HUAWEIMHA-AL00/340(C00):user/release-keys
03-10 16:21:49.973 20111-19260/? A/google-breakpad: P browser
03-10 16:21:49.973 20111-19260/? A/google-breakpad: R FFFFFFFF DUMP_REQUESTED AC525589
03-10 16:21:49.973 20111-19260/? A/google-breakpad: G UNKNOWN
03-10 16:21:49.975 20111-19260/? A/google-breakpad: H 12C00000 FFD5C000 009F 3398F000 651DC000 0C:11 0D:0B 0E:0B 0F:0D 10:14 11:2D 12:1C 13:03 14:06 15:02 1C:02 1D:01
03-10 16:21:49.975 20111-19260/? A/google-breakpad: S 0 FFD58DA8 FFD58000 00004000
 
Labels: Needs-triage-Mobile
Cc: pnangunoori@chromium.org
Components: Platform>ARC
Labels: Needs-Feedback Triaged-Mobile
Tested on Pixel Android 8.1 using reported Chrome #64.0.3282.123 and latest Stable #65.0.3325.109 and was not able to reproduce the issue by following the below steps:

1. Launch Chrome application.
2. Open an incognito tab.
3. Navigate to the URL: https://www.youku.com
4. Play any video, where user asks to leave the browser.
5. Tap on "Leave" button when "Leave incognito mode? This site is about to share information with an app outside of incognito mode." alert is displayed.
6. Observed that user is redirected to the Play Store and Chrome is still noticed in the background. 


xfzhang632@ -- Thanks for reporting this issue. Please let us know if we have missed anything. You can also try by updating your Chrome to latest Stable ##65.0.3325.109.

If the Chrome browser crashes, please provide the Crash ID generated by navigating to chrome://crashes. Also, please share your device details along with the screen cast for better understanding.

Thanks in advance!
 pnangunoori@, thanks for you update.
I read the source code. I think if your device has the google play store or Youku app, if you select the "leave", it will redirect into play store or the video app, but if the device has none of them, the crash happens.
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 13 2018

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: FoundIn-66 Target-67 M-67 FoundIn-67 FoundIn-65
Status: Untriaged (was: Unconfirmed)
Tested the issue in Android and able to reproduce the issue. Similar behavior is observed since Chrome #60.0.3072.0

Prerequisites - Disable Play Store application from Device Settings >> Apps & notifications >> Google Play Store

Steps Followed:
1. Launched the Chrome Browser and open an incognito tab.
2. Navigate to the URL: https://www.youku.com
3. Tap on any video to play the video, where user asks to leave the browser.
4. Tap on "Leave" button when "Leave incognito mode? This site is about to share information with an app outside of incognito mode." alert is displayed.
5. Observed that Chrome gets closed and when launched again incognito section gets closed.

Chrome versions tested:
60.0.3072.0, 65.0.3325.109(Stable), 67.0.3368.0(Canary)

OS:
Android 8.1

Android Devices:
Pixel

This seems to be a Non-Regression issue as same behavior is seen since M60. Untriaged for further input's on this issue.

Please navigate to below link for log's and screen cast--
go/chrome-androidlogs/820709

Note: 
1. This issue is not observed in Desktop.
2. Issue is not observed on FireFox mobile version as alert with "Leave" option is never displayed in Private Mode.

Thanks!
Components: Mobile Mobile>Intents
Owner: thildebr@chromium.org
Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5438c80cb4b1bdb301674659ee330e64999810a8

commit 5438c80cb4b1bdb301674659ee330e64999810a8
Author: Troy Hildebrandt <thildebr@chromium.org>
Date: Mon Jul 09 19:27:09 2018

Fix crash selecting Leave in Leave Incognito Mode dialog.

When selecting the Leave option in the Leave Incognito Mode dialog that
launches an intent to the Play Store, Chrome crashes if the store is
disabled/uninstalled.

This fix checks whether the intent can be handled before showing the
dialog, and just avoids showing the dialog if not. It also removes the
need to check for ActivityNotFoundExceptions, and instead performs this
check first.

Tests are added to test behaviour with the Play Store installed and
uninstalled.

Bug:  820709 
Change-Id: Ic6fec319887f77368262e825a95c419c1644b81b
Reviewed-on: https://chromium-review.googlesource.com/1113900
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573402}
[modify] https://crrev.com/5438c80cb4b1bdb301674659ee330e64999810a8/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
[modify] https://crrev.com/5438c80cb4b1bdb301674659ee330e64999810a8/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java

Status: Fixed (was: Started)

Sign in to add a comment