Heap-use-after-free in GrTextureStripAtlas::unlockRow |
||||||||||||||||||||
Issue descriptionDetailed report: https://clusterfuzz.com/testcase?key=5613357621837824 Fuzzer: inferno_canvas_wrecker Job Type: mac_asan_chrome Platform Id: mac Crash Type: Heap-use-after-free READ 8 Crash Address: 0x60700019c018 Crash State: GrTextureStripAtlas::unlockRow GrGradientEffect::~GrGradientEffect TwoPointConicalEffect::~TwoPointConicalEffect Sanitizer: address (ASAN) Recommended Security Severity: High Regressed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=542231:542242 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5613357621837824 Issue filed automatically. See https://github.com/google/clusterfuzz-tools for more information.
,
Mar 10 2018
Automatically adding ccs based on suspected regression changelists: Make GrTextureStripAtlas DDL friendly by robertphillips@google.com - https://skia.googlesource.com/skia/+/41a3b87846553e9d77e0e113bfaf4ec74a068e96 If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label.
,
Mar 10 2018
,
Mar 10 2018
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it. If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 10 2018
,
Mar 10 2018
,
Mar 11 2018
,
Mar 12 2018
,
Mar 12 2018
,
Mar 13 2018
,
Mar 14 2018
,
Mar 15 2018
This crash occurs very frequently on mac platform and is likely preventing the fuzzer inferno_canvas_wrecker from making much progress. Fixing this will allow more bugs to be found. Marking this bug as a blocker for next Beta release. If this is incorrect, please add ClusterFuzz-Wrong label and remove the ReleaseBlock-Beta label.
,
Mar 19 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/96b6d537c2466ec760af816cde1fd665d2011fab commit 96b6d537c2466ec760af816cde1fd665d2011fab Author: Robert Phillips <robertphillips@google.com> Date: Mon Mar 19 15:36:26 2018 Fix GrTextureStripAtlasManager cleanup order bug Bug: 820703 Change-Id: I6f1a895ceb213d38361bc03a472cf2a48e4720a5 Reviewed-on: https://skia-review.googlesource.com/115001 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com> [add] https://crrev.com/96b6d537c2466ec760af816cde1fd665d2011fab/tests/TextureStripAtlasManagerTest.cpp [modify] https://crrev.com/96b6d537c2466ec760af816cde1fd665d2011fab/gn/tests.gni [modify] https://crrev.com/96b6d537c2466ec760af816cde1fd665d2011fab/src/gpu/GrTextureStripAtlas.h [modify] https://crrev.com/96b6d537c2466ec760af816cde1fd665d2011fab/src/effects/SkTableColorFilter.cpp [modify] https://crrev.com/96b6d537c2466ec760af816cde1fd665d2011fab/src/shaders/gradients/SkGradientShaderPriv.h [modify] https://crrev.com/96b6d537c2466ec760af816cde1fd665d2011fab/src/gpu/effects/GrTextureStripAtlas.cpp [modify] https://crrev.com/96b6d537c2466ec760af816cde1fd665d2011fab/src/shaders/gradients/SkGradientShader.cpp
,
Mar 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/caeb6d1dfc11249acf062b4f9106b94c5274e12d commit caeb6d1dfc11249acf062b4f9106b94c5274e12d Author: skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Mon Mar 19 18:43:24 2018 Roll src/third_party/skia/ 8d2ba44c9..c9a642edf (10 commits) https://skia.googlesource.com/skia.git/+log/8d2ba44c9cba..c9a642edf2d1 $ git log 8d2ba44c9..c9a642edf --date=short --no-merges --format='%ad %ae %s' 2018-03-19 bsalomon New read pixels implementation that is simpler but does all conversions on CPU. 2018-03-19 reed handle divide by zero in paint 2018-03-19 herb Remove a ctor from SkAutoGlyphCache; removal continues. 2018-03-19 egdaniel Make sure we set stencil layout when doing copy as draw 2018-03-19 robertphillips Fix GrTextureStripAtlasManager cleanup order bug 2018-03-16 kdonev Support x86 build with VS 2015 2018-03-14 kjlubick [skpbench] Use android's perf settings for Pixel C 2018-03-19 kjlubick Avoid bad alloc in SkReadBuffer 2018-03-19 angle-skia-autoroll Roll skia/third_party/externals/angle2/ dfebe9b2d..3761dc7bf (1 commit) 2018-03-19 caryclark fix op fuzz Created with: roll-dep src/third_party/skia BUG= chromium:820703 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I6e098e7b7056791ccf28d22a30e854bc24312c1e Reviewed-on: https://chromium-review.googlesource.com/969117 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544082} [modify] https://crrev.com/caeb6d1dfc11249acf062b4f9106b94c5274e12d/DEPS
,
Mar 20 2018
ClusterFuzz has detected this issue as fixed in range 544073:544099. Detailed report: https://clusterfuzz.com/testcase?key=5613357621837824 Fuzzer: inferno_canvas_wrecker Job Type: mac_asan_chrome Platform Id: mac Crash Type: Heap-use-after-free READ 8 Crash Address: 0x60700019c018 Crash State: GrTextureStripAtlas::unlockRow GrGradientEffect::~GrGradientEffect TwoPointConicalEffect::~TwoPointConicalEffect Sanitizer: address (ASAN) Recommended Security Severity: High Regressed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=542231:542242 Fixed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=544073:544099 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5613357621837824 See https://github.com/google/clusterfuzz-tools for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
Mar 20 2018
ClusterFuzz testcase 5613357621837824 is verified as fixed, so closing issue as verified. If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
,
Mar 20 2018
,
Apr 27 2018
,
Apr 27 2018
This bug requires manual review: DEPS changes referenced in bugdroid comments. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 27 2018
+awhalley@ for M67 merge review.
,
Apr 27 2018
Already in M67, no merge needed.
,
Apr 28 2018
,
Apr 30 2018
,
Jun 26 2018
This bug has been closed for more than 14 weeks. Removing security view restrictions. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||
Comment 1 by ClusterFuzz
, Mar 10 2018Labels: Test-Predator-Auto-Components