New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 820701 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Integer-overflow in blink::BaseRenderingContext2D::getImageData

Project Member Reported by ClusterFuzz, Mar 10 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4809781521678336

Fuzzer: inferno_twister
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  blink::BaseRenderingContext2D::getImageData
  getImageDataMethod
  blink::V8CanvasRenderingContext2D::getImageDataMethodCallback
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=523880:523906

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4809781521678336

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Mar 10 2018

Components: Blink>Canvas
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Mar 10 2018

Labels: Test-Predator-Auto-Owner
Owner: zakerinasab@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/2c863229da24ed1cb180759c9342e7a5125fd6f5 (Add ImageData constructor from StaticBitmapImage).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07f4ef13b27fb071a101055d8a2f52581fc7bfbb

commit 07f4ef13b27fb071a101055d8a2f52581fc7bfbb
Author: Reza.Zakerinasab <zakerinasab@chromium.org>
Date: Fri Mar 16 13:44:47 2018

Check negative getImageData params for Integer overflow

Bug:  820701 
Change-Id: Ic4d4f28c9b34c41f22ff2f4daca25128f2fdf987
Reviewed-on: https://chromium-review.googlesource.com/964927
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543686}
[modify] https://crrev.com/07f4ef13b27fb071a101055d8a2f52581fc7bfbb/third_party/WebKit/Source/modules/canvas/canvas2d/BaseRenderingContext2D.cpp
[modify] https://crrev.com/07f4ef13b27fb071a101055d8a2f52581fc7bfbb/third_party/WebKit/Source/modules/canvas/canvas2d/CanvasRenderingContext2DAPITest.cpp

Status: Fixed (was: Assigned)
Project Member

Comment 5 by ClusterFuzz, Mar 17 2018

ClusterFuzz has detected this issue as fixed in range 543685:543686.

Detailed report: https://clusterfuzz.com/testcase?key=4809781521678336

Fuzzer: inferno_twister
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  blink::BaseRenderingContext2D::getImageData
  getImageDataMethod
  blink::V8CanvasRenderingContext2D::getImageDataMethodCallback
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=523880:523906
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=543685:543686

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4809781521678336

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Mar 17 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 4809781521678336 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment