Pre-CQ Exonerator should re-apply the same label that was removed by the failure. |
||
Issue descriptionIf a CL fails pre-CQ after getting a CQ+1 label, Pre-CQ Exonerator should give it CQ+1, not Trybot-Ready+1.
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/infra/cl_exonerator/+/f038023e9f472a9431c6002738f404e776e4a205 commit f038023e9f472a9431c6002738f404e776e4a205 Author: Paul Hobbs <phobbs@google.com> Date: Tue Apr 17 17:36:52 2018 gerrit_precq: Add the same label that was removed. This is way more complicated than it has to be because we don't have all the information we need in cidb (specifically, the labels that were removed for a given build), so we have to parse it out from the Gerrit comments. This is further complicated by Code-Review+2 being a special case - we want to apply Trybot-Ready+1 to forgive failed pre-CQ builds which were kicked off due to CR+2. TEST=Unit tests BUG= chromium:820699 Change-Id: Ic7f4dc350624988d533e5a32bc0877b7479ac371 [modify] https://crrev.com/f038023e9f472a9431c6002738f404e776e4a205/exonerator/gerrit_precq_test.py [modify] https://crrev.com/f038023e9f472a9431c6002738f404e776e4a205/main.py [modify] https://crrev.com/f038023e9f472a9431c6002738f404e776e4a205/exonerator/gerrit_precq.py
,
Apr 21 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by pho...@chromium.org
, Mar 29 2018