Chrome should immediately discard passwords that you tell it not to save
Reported by
93m4qau...@gmail.com,
Mar 10 2018
|
|||||||
Issue descriptionChrome Version: 67.0.3366.0 OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Steps to reproduce: 1. Open mail.google.com. 2. Enter your password to sign in to Gmail. 3. When the bubble comes up asking you if you want Chrome to save your password, click "Never". 4. Click on the password manager icon in the omnibox. Expected behavior: After clicking "Never", the password manager icon disappears from the omnibox and Chrome discards your password from its memory. Actual behavior: Clicking "Never" tells the password manager not to write the password to the disk, but the password manager icon remains in the omnibox and Chrome still remembers your password in memory. Please do *not* treat this as a security bug report, as I know this is not considered to be a security issue.
,
Mar 12 2018
I agree.
,
May 14 2018
Vasilii: what was the rationale not to discard a save bubble after a user clicks "Never"?
,
May 14 2018
The motivation was that the user may recover from accidental "Never" click. We can change it. Hiding the icon doesn't seem right because there may be other credentials saved for the site. We can keep the icon and move the bubble to the "Manage passwords" state. Max, what's your opinion?
,
May 15 2018
That sounds reasonable to me, too. So we would keep the icon if the user has other saved passwords ("Saved passwords for this site") and hide it otherwise, correct?
,
May 15 2018
Right, should we fix it like this?
,
May 15 2018
SGTM
,
May 24 2018
,
May 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c78f48018c1caea0e0e332b482ded89184a37b8 commit 2c78f48018c1caea0e0e332b482ded89184a37b8 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Fri May 25 08:13:37 2018 Hide the password icon if the user clicks "Never" in the bubble. Previously we didn't change the state. Now it's gonna be inactive when there are no credentials for the page and "manage passwords" when there is something to manage. Bug: 820696 Change-Id: Ic80b24e97496c104ea807d55a6105bee23b4deaf Reviewed-on: https://chromium-review.googlesource.com/1071789 Reviewed-by: Dominic Battré <battre@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#561807} [modify] https://crrev.com/2c78f48018c1caea0e0e332b482ded89184a37b8/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc [modify] https://crrev.com/2c78f48018c1caea0e0e332b482ded89184a37b8/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
,
May 25 2018
,
Jul 12
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by krajshree@chromium.org
, Mar 11 2018Labels: Needs-Triage-M67