Marking as P2 for M-67 since the warning specifically mentions March 2018. Weifang - could you confirm when this feature will be removed?

juditahudiova120@gmail.com ▼

Deleted: Downloads 1.8 KB

Downloads 1.8 KB View Download

All our engineers currently have work assigned for M-67, and it looks like this isn't going to happen for March 2018 anyway. Will look at investigating in M-68.

I believe that the 2 files of concern here are polymer v1 components iron-flex-layout and paper-styles/color which include style tags inside the imported html.

* https://cs.chromium.org/chromium/src/third_party/polymer/v1_0/components-chromium/iron-flex-layout/iron-flex-layout.html?rcl=84b61dd5c80811524c945d4b30346149ade3c31c

* https://cs.chromium.org/chromium/src/third_party/polymer/v1_0/components-chromium/paper-styles/color.html?rcl=ac183c99a73ff67079332c0c00bb334d3387c1f0

I believe we are pulling in both of these from paper-progress:
https://cs.chromium.org/chromium/src/third_party/polymer/v1_0/components-chromium/paper-progress/paper-progress.html?rcl=92f311a37ada1e439ba3fbb12c2dfc813460bf1e

https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/foreground/elements/elements_bundle.html?l=9&rcl=dc66a2c9139b4cfe2cbadeb2738df545f41ea538

I expect that the current polymer 2 migration work will resolve this.
https://groups.google.com/a/google.com/d/topic/chrome-webui/_BtqV6aErFA/discussion

Update:  I'm not quite sure if migrating to polymer 2 will fix this.

Info at https://github.com/TakayoshiKochi/deprecate-style-in-html-imports calls out polymer v1 and v2 usage of the <custom-style> with <style> tag which is responsible for us seeing the warning message.

Fix suggested at https://github.com/Polymer/polymer/issues/4679 and https://github.com/Polymer/polymer/issues/5017 is to update <style> tag inside <custom-style> to include |type="custom"| attribute.  This is supported in polymer v 1.10.1+ or v 2.1.1+.

I've just tried to update iron-flex-layout.html and color.html under third_party/v1_0/components-chromium to set <style type="custom">.  The warning goes away, but it causes the paper-progress to stop working.

I believe we have polymer v1.11.2 (done by dpapad on 2017-12-16) which should support this fix, so I'm not sure what is going wrong.
https://cs.chromium.org/chromium/src/third_party/polymer/v1_0/components-chromium/polymer/bower.json?l=3&rcl=42dcb573d0aff2e2e1b349c4c200dbbaaf0405de

> I've just tried to update iron-flex-layout.html and color.html under third_party/v1_0/components-chromium to set <style type="custom">.  The warning goes away, but it causes the paper-progress to stop working.

@joelhockey: Can you share a CL that exhibits the issue. Maybe there is something trivial that causes the styling breakage? It should in theory work.

I've just looked now, and I'm no longer seeing the warning for custom style elements:

[Deprecation] Styling master document from stylesheets defined in HTML Imports is deprecated, and is planned to be removed in M65, around March 2018. Please refer to https://goo.gl/EGXzpw for possible migration paths.

This warning was changed in https://chromium-review.googlesource.com/c/chromium/src/+/1192866.  It no longer checks custom style sheets, but only checks for use of <link rel="import" href="...">

The warning now shows:

[Deprecation] HTML Imports is deprecated and will be removed in M73, around March 2019. Please use ES modules instead. See https://www.chromestatus.com/features/5144752345317376 for more details.

I also see 3 other warnings:
[Deprecation] :unresolved pseudo selector is deprecated and will be removed in M73, around March 2019. Please use :not(:defined) instead. See https://www.chromestatus.com/features/4642138092470272 for more details.
polymer-micro-extracted.js:442 

[Deprecation] document.registerElement is deprecated and will be removed in M73, around March 2019. Please use window.customElements.define instead. See https://www.chromestatus.com/features/4642138092470272 for more details.
polymer-mini-extracted.js:2083 

[Deprecation] Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details.


So I don't know if we still need to make any changes relating to the custom style.  I assume the current polymer migration will take care of these 4 warnings that now show in FilesApp?

Regarding ":unresolved" I have already fixed this at https://chromium-review.googlesource.com/c/chromium/src/+/1249840. We still need the ":unresolved" until we migrate to Polymer 2, so nothing to do there.