New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 820650 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

If you enter VR while searching a page the results indicator does not go away

Project Member Reported by offenwanger@chromium.org, Mar 9 2018

Issue description

Open a page, use the Find in Page function (accessed from menu in top right), instead phone into daydream.

Expected Result: Page opens in VR as usual

Actual Result: That bar on the right where it shows you where the in page your search results are doesn't go away.

Not really a big deal, but slightly annoying as you can't click anything behind it and it covers most top right menu buttons
 
Cc: mthiesse@chromium.org asimjour@chromium.org
Labels: -Pri-3 M-67 Pri-2
Status: Available (was: Untriaged)

Comment 2 by ericde@google.com, May 18 2018

Labels: -M-67 M-68
Owner: asimjour@chromium.org
Status: Assigned (was: Available)
sounds like something we should target for M68. 
Labels: -M-68 M-69
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b3a4187240ade3ce58b276172d50d42acf1622d

commit 1b3a4187240ade3ce58b276172d50d42acf1622d
Author: Amirhossein Simjour <asimjour@chromium.org>
Date: Tue Jul 10 17:49:15 2018

Hide search results after entering VR

FindInPage result should be hidden in VR.

Bug:  820650 
Change-Id: I54a23ef246242eaf565a698774efe2162fe88cc4
Reviewed-on: https://chromium-review.googlesource.com/1131676
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573801}
[modify] https://crrev.com/1b3a4187240ade3ce58b276172d50d42acf1622d/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

Status: Fixed (was: Assigned)

Sign in to add a comment