New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 820649 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

while Force Sign in feature is enabled, when all users sign out, as long Chrome is not quit, user can still use chrome as guest

Project Member Reported by yini...@chromium.org, Mar 9 2018

Issue description

Chrome Version: 67.0.3365.0
OS: Mac


What steps will reproduce the problem?
(1) Enable Force Sign in feature
(2) launch Chrome, sign out of all user accounts
(3) notice a Chrome icon is still present on taskbar
(4) right click Chrome icon
(5) click New Window option

What is the expected result?
Chrome is not usable because no signed in user

What happens instead?
chrome is usable as a guest

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/027059d89aa2c92dccb867acd5aa5bd83cf9084d

commit 027059d89aa2c92dccb867acd5aa5bd83cf9084d
Author: Owen Min <zmin@chromium.org>
Date: Tue Mar 13 22:17:36 2018

Check if |lastProfile| is a guest profile when execute menu Items.

When user picks a menu item without key window, show UserManager if
the |lastProfile| is a guest profile and guest mode is disabled.

Bug:  820649 
Change-Id: I6e20446de0b89a25e37c4d8aaa48a943878fd0c8
Reviewed-on: https://chromium-review.googlesource.com/959627
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542936}
[modify] https://crrev.com/027059d89aa2c92dccb867acd5aa5bd83cf9084d/chrome/browser/app_controller_mac.mm

Comment 2 by zmin@chromium.org, Mar 15 2018

Labels: Merge-Request-66
I have verified the fix on Chrome 67.0.3371.0. 

And I'd like to merge this patch to 66 because we plan to launch force-sign-in policy on Mac in M66 and user will be able to escape from the policy due to this issue.

The patch has been verified manually on canary. And the browser test will be landed soon.
https://chromium-review.googlesource.com/c/chromium/src/+/961541

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6e1bf29bda856d459a73e363e2b86843f8ee77a

commit b6e1bf29bda856d459a73e363e2b86843f8ee77a
Author: Owen Min <zmin@chromium.org>
Date: Thu Mar 15 18:31:52 2018

Add browser test for AppController

Browser test for crrev.com/027059d89aa2c92dccb867acd5aa5bd83cf9084d.

Bug:  820649 
Change-Id: I8f9cd3a53b702ce67b62fd6986b469c426ad1f84
Reviewed-on: https://chromium-review.googlesource.com/961541
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543453}
[modify] https://crrev.com/b6e1bf29bda856d459a73e363e2b86843f8ee77a/chrome/browser/app_controller_mac_browsertest.mm

Project Member

Comment 4 by sheriffbot@chromium.org, Mar 16 2018

Labels: -Merge-Request-66 Merge-Review-66 Hotlist-Merge-Review
This bug requires manual review: M66 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by zmin@chromium.org, Mar 19 2018

Cc: abdulsyed@chromium.org georgesak@chromium.org
Hi Abdul,

Could you please take a look this issue?
Labels: -Merge-Review-66 Merge-Approved-66
Approved. branch:3359
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 19 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8cef6407747f9ddfbb51030eea4920a084dc73f

commit c8cef6407747f9ddfbb51030eea4920a084dc73f
Author: Owen Min <zmin@chromium.org>
Date: Mon Mar 19 19:39:03 2018

Merge "Check if |lastProfile| is a guest profile when execute menu Items." to 66.

When user picks a menu item without key window, show UserManager if
the |lastProfile| is a guest profile and guest mode is disabled.

Bug:  820649 
Change-Id: I6e20446de0b89a25e37c4d8aaa48a943878fd0c8
Reviewed-on: https://chromium-review.googlesource.com/959627
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#542936}(cherry picked from commit 027059d89aa2c92dccb867acd5aa5bd83cf9084d)
Reviewed-on: https://chromium-review.googlesource.com/969402
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#322}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/c8cef6407747f9ddfbb51030eea4920a084dc73f/chrome/browser/app_controller_mac.mm

Cc: yini...@chromium.org
yiningc@ Could you please verify this issue on Mac with chrome #66.0.3359.45
this bug is verified fixed on chrome #66.0.3359.45 build.

Comment 10 by zmin@chromium.org, Mar 26 2018

Status: Verified (was: Assigned)

Sign in to add a comment