ShellExtensionLoaderTest tests in app_shell_unittests failing on chromium.memory/Linux CFI |
|||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of michaelpg@google.com ShellExtensionLoaderTest.Extension and 6 other(s) in app_shell_unittests failing on chromium.memory/Linux CFI Builders failed on: - Linux CFI: https://build.chromium.org/p/chromium.memory/builders/Linux%20CFI These tests are from https://chromium-review.googlesource.com/c/chromium/src/+/950342. They seem to pass on other bots, so I'll investigate why they fail on CFI on try to fix the root cause.
,
Mar 10 2018
Fix at https://chromium-review.googlesource.com/c/chromium/src/+/957871 was verified with a local CFI build. Landing now.
,
Mar 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/242098c21dc6953d75c938b37a85cee51f6db614 commit 242098c21dc6953d75c938b37a85cee51f6db614 Author: Michael Giuffrida <michaelpg@chromium.org> Date: Sat Mar 10 01:12:45 2018 ShellExtensionLoaderTest should use existing PrefService ShellExtensionLoaderTest associates a new TestingPrefServiceSimple with the BrowserContext, but instead should associate the existing PrefService created by ExtensionsTest. Creating its own TestingPrefServiceSimple, besides being unnecessary, leads to invalid casts of its PrefRegistrySimple to a PrefRegistrySyncable (breaking the Linux CFI bots). TBR=rdevlin.cronin@chromium.org Bug: 820647 Change-Id: I2ae62a396622d034c8c5b04bbe9dabb529b5bd25 Reviewed-on: https://chromium-review.googlesource.com/957871 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#542302} [modify] https://crrev.com/242098c21dc6953d75c938b37a85cee51f6db614/extensions/shell/browser/shell_extension_loader_unittest.cc
,
Mar 10 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by michae...@chromium.org
, Mar 9 2018Status: Assigned (was: Available)