New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 820632 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

UKM entry whitelist should be strict when there's no whitelist

Project Member Reported by rkaplow@chromium.org, Mar 9 2018

Issue description

Currently UKM will emit all entries when there is no whitelist. This is not ideal as that is possible if it hasn't been supplied from field trial params (ex. during first run).

Changing so it is strict (but will always require a whitelist).
 
EBD15201-BEA0-43AC-BEBB-F0ADB17C507C.jpeg
633 KB View Download
Indeed - originally UKM base::Feature was not on, so we reasoned if UKM is on, then the server config would be there and thus would specify whatever whitelist is set.

But now that it's on by default, that is no longer guaranteed.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f83c851bbefb29afd2af2acdc5ac0061509495d

commit 6f83c851bbefb29afd2af2acdc5ac0061509495d
Author: Robert Kaplow <rkaplow@chromium.org>
Date: Mon Mar 19 15:18:41 2018

Strict UKM entry whitelisting.

Currently if there is no whitelist, we record everything. We shouldn't do this since if a user has no field trial params (first run, etc.), they will record everything, avoiding the whitelist.

Also changed a bitwise and to && while I was making a change. No-op but seems bad style (and apparently can be different as & doesn't shortcut).

Bug:  820632 
Change-Id: I3fd3b1ca6669294e61467bb0f4d0ad87fb2ff576
Reviewed-on: https://chromium-review.googlesource.com/957384
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544034}
[modify] https://crrev.com/6f83c851bbefb29afd2af2acdc5ac0061509495d/components/metrics_services_manager/metrics_services_manager.cc
[modify] https://crrev.com/6f83c851bbefb29afd2af2acdc5ac0061509495d/components/ukm/test_ukm_recorder.cc
[modify] https://crrev.com/6f83c851bbefb29afd2af2acdc5ac0061509495d/components/ukm/test_ukm_recorder.h
[modify] https://crrev.com/6f83c851bbefb29afd2af2acdc5ac0061509495d/components/ukm/ukm_recorder_impl.cc
[modify] https://crrev.com/6f83c851bbefb29afd2af2acdc5ac0061509495d/components/ukm/ukm_recorder_impl.h
[modify] https://crrev.com/6f83c851bbefb29afd2af2acdc5ac0061509495d/components/ukm/ukm_service_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment